OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-13 20:12:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Release class loader when a plugin fails to load (#6030)

Browse Source
This commit is contained in:
Basil Crow authored and GitHub committed 2021-12-14 08:27:41 +00:00
1 parent 3dcabc4b02
commit 91675c5d44
1 file changed
+5 -1
Download Patch File Download Diff File Expand all files Collapse all files
core/src/main/java/hudson/PluginManager.java
+5 -1
View File
@@ -543,11 +543,13 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
failedPlugins.add(new FailedPlugin(p, e));
activePlugins.remove(p);
plugins.remove(p);
p.releaseClassLoader();
LOGGER.log(Level.SEVERE, "Failed to install {0}: {1}", new Object[] { p.getShortName(), e.getMessage() });
} catch (IOException e) {
failedPlugins.add(new FailedPlugin(p, e));
activePlugins.remove(p);
plugins.remove(p);
p.releaseClassLoader();
throw e;
}
}
@@ -568,6 +570,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
failedPlugins.add(new FailedPlugin(p, e));
activePlugins.remove(p);
plugins.remove(p);
p.releaseClassLoader();
throw e;
}
}
@@ -928,9 +931,10 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
}
} catch (Exception e) {
failedPlugins.add(new FailedPlugin(sn, e));
failedPlugins.add(new FailedPlugin(p, e));
activePlugins.remove(p);
plugins.remove(p);
p.releaseClassLoader();
throw new IOException("Failed to install "+ sn +" plugin",e);
}