diff --git a/core/src/main/java/hudson/ClassicPluginStrategy.java b/core/src/main/java/hudson/ClassicPluginStrategy.java index 61f7a05604..bc4b350c0c 100644 --- a/core/src/main/java/hudson/ClassicPluginStrategy.java +++ b/core/src/main/java/hudson/ClassicPluginStrategy.java @@ -613,7 +613,7 @@ public class ClassicPluginStrategy implements PluginStrategy { synchronized (this) { localTransitiveDependencies = transitiveDependencies; if (localTransitiveDependencies == null) { - CyclicGraphDetector cgd = new CyclicGraphDetector() { + CyclicGraphDetector cgd = new CyclicGraphDetector<>() { @Override protected List getEdges(PluginWrapper pw) { List dep = new ArrayList<>(); diff --git a/core/src/main/java/hudson/DescriptorExtensionList.java b/core/src/main/java/hudson/DescriptorExtensionList.java index 7c9fbbddcc..c92b6ae206 100644 --- a/core/src/main/java/hudson/DescriptorExtensionList.java +++ b/core/src/main/java/hudson/DescriptorExtensionList.java @@ -251,7 +251,7 @@ public class DescriptorExtensionList, D extends Descrip * List up all the legacy instances currently in use. */ public static Iterable listLegacyInstances() { - return new Iterable() { + return new Iterable<>() { @Override public Iterator iterator() { return new AdaptedIterator, Descriptor>( diff --git a/core/src/main/java/hudson/ExtensionList.java b/core/src/main/java/hudson/ExtensionList.java index 7bae8ff5d8..090d2172ca 100644 --- a/core/src/main/java/hudson/ExtensionList.java +++ b/core/src/main/java/hudson/ExtensionList.java @@ -169,7 +169,7 @@ public class ExtensionList extends AbstractList implements OnMaster { @Override public @NonNull Iterator iterator() { // we need to intercept mutation, so for now don't allow Iterator.remove - return new AdaptedIterator, T>(Iterators.readOnly(ensureLoaded().iterator())) { + return new AdaptedIterator<>(Iterators.readOnly(ensureLoaded().iterator())) { @Override protected T adapt(ExtensionComponent item) { return item.getInstance(); @@ -198,7 +198,7 @@ public class ExtensionList extends AbstractList implements OnMaster { * Gets the read-only view of this {@link ExtensionList} where components are reversed. */ public List reverseView() { - return new AbstractList() { + return new AbstractList<>() { @Override public T get(int index) { return ExtensionList.this.get(size() - index - 1); diff --git a/core/src/main/java/hudson/ExtensionListView.java b/core/src/main/java/hudson/ExtensionListView.java index 0127752e46..2b10152b5c 100644 --- a/core/src/main/java/hudson/ExtensionListView.java +++ b/core/src/main/java/hudson/ExtensionListView.java @@ -56,7 +56,7 @@ public class ExtensionListView { * Creates a plain {@link List} backed by the current {@link ExtensionList}. */ public static List createList(final Class type) { - return new AbstractList() { + return new AbstractList<>() { private ExtensionList storage() { return Jenkins.get().getExtensionList(type); } @@ -103,7 +103,7 @@ public class ExtensionListView { * Creates a seriously hacked up {@link CopyOnWriteList} that acts as a view to the current {@link ExtensionList}. */ public static CopyOnWriteList createCopyOnWriteList(final Class type) { - return new CopyOnWriteList() { + return new CopyOnWriteList<>() { private ExtensionList storage() { return Jenkins.get().getExtensionList(type); } diff --git a/core/src/main/java/hudson/PluginManager.java b/core/src/main/java/hudson/PluginManager.java index 568ad7df43..231a68a3de 100644 --- a/core/src/main/java/hudson/PluginManager.java +++ b/core/src/main/java/hudson/PluginManager.java @@ -467,7 +467,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas @Override public void run(Reactor reactor) throws Exception { try { - CyclicGraphDetector cgd = new CyclicGraphDetector() { + CyclicGraphDetector cgd = new CyclicGraphDetector<>() { @Override protected List getEdges(PluginWrapper p) { List next = new ArrayList<>(); diff --git a/core/src/main/java/hudson/console/ConsoleAnnotationOutputStream.java b/core/src/main/java/hudson/console/ConsoleAnnotationOutputStream.java index d2ac95da65..256211a726 100644 --- a/core/src/main/java/hudson/console/ConsoleAnnotationOutputStream.java +++ b/core/src/main/java/hudson/console/ConsoleAnnotationOutputStream.java @@ -113,7 +113,7 @@ public class ConsoleAnnotationOutputStream extends LineTransformationOutputSt if (a != null) { if (annotators == null) annotators = new ArrayList<>(); - annotators.add(new ConsoleAnnotator() { + annotators.add(new ConsoleAnnotator<>() { @Override public ConsoleAnnotator annotate(T context, MarkupText text) { return a.annotate(context, text, charPos); diff --git a/core/src/main/java/hudson/diagnosis/OldDataMonitor.java b/core/src/main/java/hudson/diagnosis/OldDataMonitor.java index b29ec1a80f..ba589758cb 100644 --- a/core/src/main/java/hudson/diagnosis/OldDataMonitor.java +++ b/core/src/main/java/hudson/diagnosis/OldDataMonitor.java @@ -149,7 +149,7 @@ public class OldDataMonitor extends AdministrativeMonitor { }; @Extension - public static final RunListener runDeleteListener = new RunListener() { + public static final RunListener runDeleteListener = new RunListener<>() { @Override public void onDeleted(Run run) { remove(run, true); diff --git a/core/src/main/java/hudson/logging/LogRecorder.java b/core/src/main/java/hudson/logging/LogRecorder.java index 4e49c019a1..84ae1e1f1e 100644 --- a/core/src/main/java/hudson/logging/LogRecorder.java +++ b/core/src/main/java/hudson/logging/LogRecorder.java @@ -574,7 +574,7 @@ public class LogRecorder extends AbstractModelObject implements Saveable { * @since 1.519 */ public Map> getSlaveLogRecords() { - Map> result = new TreeMap<>(new Comparator() { + Map> result = new TreeMap<>(new Comparator<>() { final Collator COLL = Collator.getInstance(); @Override diff --git a/core/src/main/java/hudson/logging/LogRecorderManager.java b/core/src/main/java/hudson/logging/LogRecorderManager.java index 964d90a025..70856024df 100644 --- a/core/src/main/java/hudson/logging/LogRecorderManager.java +++ b/core/src/main/java/hudson/logging/LogRecorderManager.java @@ -247,7 +247,7 @@ public class LogRecorderManager extends AbstractModelObject implements ModelObje entryType = level; } - RSS.forwardToRss("Jenkins:log (" + entryType + " entries)", "", logs, new FeedAdapter() { + RSS.forwardToRss("Jenkins:log (" + entryType + " entries)", "", logs, new FeedAdapter<>() { @Override public String getEntryTitle(LogRecord entry) { return entry.getMessage(); diff --git a/core/src/main/java/hudson/model/AbstractBuild.java b/core/src/main/java/hudson/model/AbstractBuild.java index f147cdb879..e19a8b17a5 100644 --- a/core/src/main/java/hudson/model/AbstractBuild.java +++ b/core/src/main/java/hudson/model/AbstractBuild.java @@ -158,7 +158,7 @@ public abstract class AbstractBuild

, R extends A */ protected transient List buildEnvironments; - private final transient LazyBuildMixIn.RunMixIn runMixIn = new LazyBuildMixIn.RunMixIn() { + private final transient LazyBuildMixIn.RunMixIn runMixIn = new LazyBuildMixIn.RunMixIn<>() { @Override protected R asRun() { return _this(); } @@ -1194,11 +1194,11 @@ public abstract class AbstractBuild

, R extends A public Iterable> getDownstreamBuilds(final AbstractProject that) { final Iterable nums = getDownstreamRelationship(that).listNumbers(); - return new Iterable>() { + return new Iterable<>() { @Override public Iterator> iterator() { return Iterators.removeNull( - new AdaptedIterator>(nums) { + new AdaptedIterator<>(nums) { @Override protected AbstractBuild adapt(Integer item) { return that.getBuildByNumber(item); diff --git a/core/src/main/java/hudson/model/AbstractProject.java b/core/src/main/java/hudson/model/AbstractProject.java index 7851de0983..16b832c043 100644 --- a/core/src/main/java/hudson/model/AbstractProject.java +++ b/core/src/main/java/hudson/model/AbstractProject.java @@ -268,7 +268,7 @@ public abstract class AbstractProject

, R extends } private LazyBuildMixIn createBuildMixIn() { - return new LazyBuildMixIn() { + return new LazyBuildMixIn<>() { @SuppressWarnings("unchecked") // untypable @Override protected P asJob() { return (P) AbstractProject.this; diff --git a/core/src/main/java/hudson/model/ComputerSet.java b/core/src/main/java/hudson/model/ComputerSet.java index ecef09a90f..211c795ee9 100644 --- a/core/src/main/java/hudson/model/ComputerSet.java +++ b/core/src/main/java/hudson/model/ComputerSet.java @@ -146,7 +146,7 @@ public final class ComputerSet extends AbstractModelObject implements Describabl * Gets all the agent names. */ public List get_slaveNames() { - return new AbstractList() { + return new AbstractList<>() { final List nodes = Jenkins.get().getNodes(); @Override diff --git a/core/src/main/java/hudson/model/DependencyGraph.java b/core/src/main/java/hudson/model/DependencyGraph.java index 3788e2aefd..0f0c4110a9 100644 --- a/core/src/main/java/hudson/model/DependencyGraph.java +++ b/core/src/main/java/hudson/model/DependencyGraph.java @@ -103,7 +103,7 @@ public class DependencyGraph implements Comparator { * See https://en.wikipedia.org/wiki/Tarjan's_strongly_connected_components_algorithm */ private void topologicalDagSort() { - DirectedGraph g = new DirectedGraph() { + DirectedGraph g = new DirectedGraph<>() { @Override protected Collection nodes() { final Set nodes = new HashSet<>(); @@ -342,7 +342,7 @@ public class DependencyGraph implements Comparator { return Collections.unmodifiableMap(m); } - private static final Comparator NAME_COMPARATOR = new Comparator() { + private static final Comparator NAME_COMPARATOR = new Comparator<>() { @Override public int compare(DependencyGroup lhs, DependencyGroup rhs) { int cmp = lhs.getUpstreamProject().getName().compareTo(rhs.getUpstreamProject().getName()); diff --git a/core/src/main/java/hudson/model/Executor.java b/core/src/main/java/hudson/model/Executor.java index 7ffc181dd7..1214a277d8 100644 --- a/core/src/main/java/hudson/model/Executor.java +++ b/core/src/main/java/hudson/model/Executor.java @@ -356,7 +356,7 @@ public class Executor extends Thread implements ModelObject { SubTask task; // transition from idle to building. // perform this state change as an atomic operation wrt other queue operations - task = Queue.withLock(new Callable() { + task = Queue.withLock(new Callable<>() { @Override public SubTask call() throws Exception { if (!owner.isOnline()) { diff --git a/core/src/main/java/hudson/model/Fingerprint.java b/core/src/main/java/hudson/model/Fingerprint.java index d4b57badae..d492579671 100644 --- a/core/src/main/java/hudson/model/Fingerprint.java +++ b/core/src/main/java/hudson/model/Fingerprint.java @@ -362,10 +362,10 @@ public class Fingerprint implements ModelObject, Saveable { */ public Iterable listNumbers() { final List ranges = getRanges(); - return new Iterable() { + return new Iterable<>() { @Override public Iterator iterator() { - return new Iterators.FlattenIterator(ranges) { + return new Iterators.FlattenIterator<>(ranges) { @Override protected Iterator expand(Range range) { return Iterators.sequence(range.start, range.end).iterator(); @@ -380,10 +380,10 @@ public class Fingerprint implements ModelObject, Saveable { */ public Iterable listNumbersReverse() { final List ranges = getRanges(); - return new Iterable() { + return new Iterable<>() { @Override public Iterator iterator() { - return new Iterators.FlattenIterator(Iterators.reverse(ranges)) { + return new Iterators.FlattenIterator<>(Iterators.reverse(ranges)) { @Override protected Iterator expand(Range range) { return Iterators.reverseSequence(range.start, range.end).iterator(); @@ -1164,7 +1164,7 @@ public class Fingerprint implements ModelObject, Saveable { this.transientFacets = Collections.unmodifiableList(transientFacets); } - return new AbstractCollection() { + return new AbstractCollection<>() { @Override public Iterator iterator() { return Iterators.sequence(facets.iterator(), transientFacets.iterator()); @@ -1208,7 +1208,7 @@ public class Fingerprint implements ModelObject, Saveable { */ public @NonNull Collection getSortedFacets() { List r = new ArrayList<>(getFacets()); - r.sort(new Comparator() { + r.sort(new Comparator<>() { @Override public int compare(FingerprintFacet o1, FingerprintFacet o2) { long a = o1.getTimestamp(); diff --git a/core/src/main/java/hudson/model/Job.java b/core/src/main/java/hudson/model/Job.java index 449475ef2a..d7444c2304 100644 --- a/core/src/main/java/hudson/model/Job.java +++ b/core/src/main/java/hudson/model/Job.java @@ -624,7 +624,7 @@ public abstract class Job, RunT extends Run(this, getBuilds(), HISTORY_ADAPTER); } - public static final HistoryWidget.Adapter HISTORY_ADAPTER = new Adapter() { + public static final HistoryWidget.Adapter HISTORY_ADAPTER = new Adapter<>() { @Override public int compare(Run record, String key) { try { @@ -1121,7 +1121,7 @@ public abstract class Job, RunT extends Run() { + entries, new FeedAdapter<>() { @Override public String getEntryTitle(FeedItem item) { return "#" + item.getBuild().number + ' ' + item.e.getMsg() + " (" + item.e.getAuthor() + ")"; diff --git a/core/src/main/java/hudson/model/Label.java b/core/src/main/java/hudson/model/Label.java index 12426e8ba9..c285a1a28f 100644 --- a/core/src/main/java/hudson/model/Label.java +++ b/core/src/main/java/hudson/model/Label.java @@ -185,7 +185,7 @@ public abstract class Label extends Actionable implements Comparable