From 35b00941372eafcf8991ff9c10f2d9ec7ac1b347 Mon Sep 17 00:00:00 2001 From: Daniel Beck Date: Thu, 17 Apr 2014 21:49:15 +0200 Subject: [PATCH] [FIXED JENKINS-22670] Less aggressive word breaking --- core/src/main/java/hudson/Functions.java | 2 +- core/src/test/java/hudson/FunctionsTest.java | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/hudson/Functions.java b/core/src/main/java/hudson/Functions.java index f6730b44ca..7be66d3ec6 100644 --- a/core/src/main/java/hudson/Functions.java +++ b/core/src/main/java/hudson/Functions.java @@ -1834,7 +1834,7 @@ public class Functions { public static String breakableString(final String plain) { return plain.replaceAll("([\\p{Punct}&&[^;]]+\\w)", "$1") - .replaceAll("([^\\p{Punct}\\s-]{10})(?=[^\\p{Punct}\\s-]{3})", "$1") + .replaceAll("([^\\p{Punct}\\s-]{20})(?=[^\\p{Punct}\\s-]{10})", "$1") ; } diff --git a/core/src/test/java/hudson/FunctionsTest.java b/core/src/test/java/hudson/FunctionsTest.java index 6bc0b11664..f0e5213900 100644 --- a/core/src/test/java/hudson/FunctionsTest.java +++ b/core/src/test/java/hudson/FunctionsTest.java @@ -309,7 +309,9 @@ public class FunctionsTest { assertBrokenAs("Hello world!", "Hello world!"); assertBrokenAs("Hello-world!", "Hello", "-world!"); - assertBrokenAs("ALongStringThatCanNotBeBrokenByDefault", "ALongStrin", "gThatCanNo", "tBeBrokenB", "yDefault"); + assertBrokenAs("ALongStringThatCanNotBeBrokenByDefaultAndNeedsToUseTheBreakableElement", + "ALongStringThatCanNo", "tBeBrokenByDefaultAn", "dNeedsToUseTheBreaka", "bleElement"); + assertBrokenAs("DontBreakShortStringBefore-Hyphen", "DontBreakShortStringBefore", "-Hyphen"); assertBrokenAs("jenkins_main_trunk", "jenkins", "_main", "_trunk"); assertBrokenAs("<<<<<", "", "<", "<", "<", "<", "<"); @@ -319,7 +321,7 @@ public class FunctionsTest { assertBrokenAs("A;String>Full]Of)Weird}Punctuation", "A;String", ">Full", "]Of", ")Weird", "}Punctuation"); assertBrokenAs("<<a<bc<def<ghi<", "", "<", "<a", "<bc", "<def", "<ghi", "<"); assertBrokenAs("H,e.l/l:o=w_o+|d", "H", ",e", ".l", "/l", ":o", "=w", "_o", "+|d"); - assertBrokenAs("a¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷ", "a¶‱ﻷa¶‱ﻷa¶", "‱ﻷa¶‱ﻷa¶‱ﻷ", "a¶‱ﻷa¶‱ﻷa¶‱ﻷ"); + assertBrokenAs("a¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷ", "a¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷa¶‱ﻷ", "a¶‱ﻷa¶‱ﻷa¶‱ﻷ"); } private void assertBrokenAs(String plain, String... chunks) {