From a95ce545f529e302a7aa877a086eeb84522f341d Mon Sep 17 00:00:00 2001 From: kohsuke Date: Thu, 7 Jun 2007 05:56:36 +0000 Subject: [PATCH] when there's just one module, showing a checkbox is silly. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@3405 71c3de6d-444a-0410-be80-ed276b4c234a --- .../src/main/java/hudson/scm/SubversionTagAction.java | 4 ++-- .../hudson/scm/SubversionTagAction/tagForm.jelly | 11 ++++++++--- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/core/src/main/java/hudson/scm/SubversionTagAction.java b/core/src/main/java/hudson/scm/SubversionTagAction.java index c58cc37716..cbe1db42c2 100644 --- a/core/src/main/java/hudson/scm/SubversionTagAction.java +++ b/core/src/main/java/hudson/scm/SubversionTagAction.java @@ -108,8 +108,8 @@ public class SubversionTagAction extends AbstractScmTagAction { int i=-1; for (Entry e : tags.entrySet()) { i++; - if(req.getParameter("tag"+i)==null) - continue; + if(tags.size()>1 && req.getParameter("tag"+i)==null) + continue; // when tags.size()==1, UI won't show the checkbox. newTags.put(e.getKey(),req.getParameter("name" + i)); } diff --git a/core/src/main/resources/hudson/scm/SubversionTagAction/tagForm.jelly b/core/src/main/resources/hudson/scm/SubversionTagAction/tagForm.jelly index 9a0c54c9c1..abd733252e 100644 --- a/core/src/main/resources/hudson/scm/SubversionTagAction/tagForm.jelly +++ b/core/src/main/resources/hudson/scm/SubversionTagAction/tagForm.jelly @@ -9,16 +9,21 @@

Build #${it.build.number}

+
- + + + - + - + + +
Module URL Tag URL