mirror of
https://github.com/jenkinsci/jenkins.git
synced 2026-11-17 22:12:25 +00:00
Hudson now suggests to users to create a view if there are too many jobs but no jobs yet.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@16781 71c3de6d-444a-0410-be80-ed276b4c234a
This commit is contained in:
1 parent
bfd251bce6
commit
aaacb877bc
5 files changed
+183
-2
No files matched your search
@@ -0,0 +1,62 @@
|
||||
/*
|
||||
* The MIT License
|
||||
*
|
||||
* Copyright (c) 2004-2009, Sun Microsystems, Inc.
|
||||
*
|
||||
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
||||
* of this software and associated documentation files (the "Software"), to deal
|
||||
* in the Software without restriction, including without limitation the rights
|
||||
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
||||
* copies of the Software, and to permit persons to whom the Software is
|
||||
* furnished to do so, subject to the following conditions:
|
||||
*
|
||||
* The above copyright notice and this permission notice shall be included in
|
||||
* all copies or substantial portions of the Software.
|
||||
*
|
||||
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
||||
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
||||
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
||||
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
||||
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
||||
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
||||
* THE SOFTWARE.
|
||||
*/
|
||||
package hudson.diagnosis;
|
||||
|
||||
import hudson.model.AdministrativeMonitor;
|
||||
import hudson.model.Hudson;
|
||||
import hudson.Extension;
|
||||
import org.kohsuke.stapler.StaplerRequest;
|
||||
import org.kohsuke.stapler.StaplerResponse;
|
||||
|
||||
import java.io.IOException;
|
||||
|
||||
/**
|
||||
* If Hudson is run with a lot of jobs but no views, suggest the user that they can create views.
|
||||
*
|
||||
* <p>
|
||||
* I noticed at an user visit that some users didn't notice the '+' icon in the tab bar.
|
||||
*
|
||||
* @author Kohsuke Kawaguchi
|
||||
*/
|
||||
@Extension
|
||||
public class TooManyJobsButNoView extends AdministrativeMonitor {
|
||||
public boolean isActivated() {
|
||||
Hudson h = Hudson.getInstance();
|
||||
return h.getViews().size()==1 && h.getItemMap().size()> THRESHOLD;
|
||||
}
|
||||
|
||||
/**
|
||||
* Depending on whether the user said "yes" or "no", send him to the right place.
|
||||
*/
|
||||
public void doAct(StaplerRequest req, StaplerResponse rsp) throws IOException {
|
||||
if(req.hasParameter("no")) {
|
||||
disable(true);
|
||||
rsp.sendRedirect(req.getContextPath()+"/manage");
|
||||
} else {
|
||||
rsp.sendRedirect(req.getContextPath()+"/newView");
|
||||
}
|
||||
}
|
||||
|
||||
public static final int THRESHOLD = 16;
|
||||
}
|
||||
@@ -991,6 +991,17 @@ public final class Hudson extends Node implements ItemGroup<TopLevelItem>, Stapl
|
||||
return new ArrayList<TopLevelItem>(items.values());
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the read-only view of all the {@link TopLevelItem}s keyed by their names.
|
||||
* <p>
|
||||
* This method is efficient, as it doesn't involve any copying.
|
||||
*
|
||||
* @since 1.296
|
||||
*/
|
||||
public Map<String,TopLevelItem> getItemMap() {
|
||||
return Collections.unmodifiableMap(items);
|
||||
}
|
||||
|
||||
/**
|
||||
* Gets just the immediate children of {@link Hudson} but of the given type.
|
||||
*/
|
||||
@@ -1074,6 +1085,11 @@ public final class Hudson extends Node implements ItemGroup<TopLevelItem>, Stapl
|
||||
return copy;
|
||||
}
|
||||
|
||||
public void addView(View v) throws IOException {
|
||||
views.add(v);
|
||||
save();
|
||||
}
|
||||
|
||||
public synchronized void deleteView(View view) throws IOException {
|
||||
if(views.size()<=1)
|
||||
throw new IllegalStateException();
|
||||
@@ -2348,8 +2364,7 @@ public final class Hudson extends Node implements ItemGroup<TopLevelItem>, Stapl
|
||||
public synchronized void doCreateView( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException {
|
||||
try {
|
||||
checkPermission(View.CREATE);
|
||||
views.add(View.create(req,rsp, this));
|
||||
save();
|
||||
addView(View.create(req,rsp, this));
|
||||
} catch (ParseException e) {
|
||||
sendError(e,req,rsp);
|
||||
} catch (FormException e) {
|
||||
|
||||
Reference in new issue
Block a user