From abe1def90e3b408dcedcf43d8e760cc81dd57dce Mon Sep 17 00:00:00 2001 From: kohsuke Date: Fri, 16 Jan 2009 23:10:56 +0000 Subject: [PATCH] Added a convenience method. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14566 71c3de6d-444a-0410-be80-ed276b4c234a --- .../java/hudson/scm/SubversionChangeLogBuilder.java | 2 +- core/src/main/java/hudson/scm/SubversionSCM.java | 11 +++++++++++ .../src/main/java/hudson/scm/SubversionTagAction.java | 2 +- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/hudson/scm/SubversionChangeLogBuilder.java b/core/src/main/java/hudson/scm/SubversionChangeLogBuilder.java index 496c4ab46e..3d9a73ad61 100644 --- a/core/src/main/java/hudson/scm/SubversionChangeLogBuilder.java +++ b/core/src/main/java/hudson/scm/SubversionChangeLogBuilder.java @@ -61,7 +61,7 @@ public final class SubversionChangeLogBuilder { public boolean run(Collection externals, Result changeLog) throws IOException, InterruptedException { boolean changelogFileCreated = false; - final SVNClientManager manager = SubversionSCM.createSvnClientManager(createAuthenticationProvider()); + final SVNClientManager manager = SubversionSCM.createSvnClientManager(); try { SVNLogClient svnlc = manager.getLogClient(); TransformerHandler th = createTransformerHandler(); diff --git a/core/src/main/java/hudson/scm/SubversionSCM.java b/core/src/main/java/hudson/scm/SubversionSCM.java index 63c198d36f..6fd6961f6b 100644 --- a/core/src/main/java/hudson/scm/SubversionSCM.java +++ b/core/src/main/java/hudson/scm/SubversionSCM.java @@ -524,6 +524,17 @@ public class SubversionSCM extends SCM implements Serializable { return SVNClientManager.newInstance(SVNWCUtil.createDefaultOptions(true),sam); } + /** + * Creates {@link SVNClientManager} for code running on the master. + *

+ * CAUTION: this code only works when invoked on master. On slaves, use + * {@link #createSvnClientManager(ISVNAuthenticationProvider)} and get {@link ISVNAuthenticationProvider} + * from the master via remoting. + */ + public static SVNClientManager createSvnClientManager() { + return createSvnClientManager(DescriptorImpl.DESCRIPTOR.createAuthenticationProvider()); + } + public static final class SvnInfo implements Serializable, Comparable { /** * Decoded repository URL. diff --git a/core/src/main/java/hudson/scm/SubversionTagAction.java b/core/src/main/java/hudson/scm/SubversionTagAction.java index b667caa426..3f87af4901 100644 --- a/core/src/main/java/hudson/scm/SubversionTagAction.java +++ b/core/src/main/java/hudson/scm/SubversionTagAction.java @@ -165,7 +165,7 @@ public class SubversionTagAction extends AbstractScmTagAction { @Override protected void perform(TaskListener listener) { try { - final SVNClientManager cm = SubversionSCM.createSvnClientManager(SubversionSCM.DescriptorImpl.DESCRIPTOR.createAuthenticationProvider()); + final SVNClientManager cm = SubversionSCM.createSvnClientManager(); try { for (Entry e : tagSet.entrySet()) { PrintStream logger = listener.getLogger();