From adcfcedd7ba93e0eba7dca4ea2dbb22947c4f405 Mon Sep 17 00:00:00 2001 From: Josh Soref Date: Wed, 20 Feb 2019 18:59:20 -0500 Subject: [PATCH] Dropping unnecessary public modifiers --- core/src/main/java/hudson/model/ModifiableViewGroup.java | 2 +- .../main/java/jenkins/model/ModelObjectWithChildren.java | 2 +- .../main/java/jenkins/model/ModelObjectWithContextMenu.java | 6 +++--- core/src/main/java/jenkins/security/CustomClassFilter.java | 4 ++-- core/src/main/java/jenkins/tasks/SimpleBuildStep.java | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/core/src/main/java/hudson/model/ModifiableViewGroup.java b/core/src/main/java/hudson/model/ModifiableViewGroup.java index 6a2542af38..4ec97000b3 100644 --- a/core/src/main/java/hudson/model/ModifiableViewGroup.java +++ b/core/src/main/java/hudson/model/ModifiableViewGroup.java @@ -38,5 +38,5 @@ public interface ModifiableViewGroup extends ViewGroup { /** * Add new {@link View} to this {@link ViewGroup}. */ - public void addView(@Nonnull View view) throws IOException; + void addView(@Nonnull View view) throws IOException; } diff --git a/core/src/main/java/jenkins/model/ModelObjectWithChildren.java b/core/src/main/java/jenkins/model/ModelObjectWithChildren.java index 4d3fe475d2..c8d544e03e 100644 --- a/core/src/main/java/jenkins/model/ModelObjectWithChildren.java +++ b/core/src/main/java/jenkins/model/ModelObjectWithChildren.java @@ -20,5 +20,5 @@ public interface ModelObjectWithChildren extends ModelObject { /** * Generates the context menu to list up all the children. */ - public ContextMenu doChildrenContextMenu(StaplerRequest request, StaplerResponse response) throws Exception; + ContextMenu doChildrenContextMenu(StaplerRequest request, StaplerResponse response) throws Exception; } diff --git a/core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java b/core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java index 5b450a0c97..3073ebb84d 100644 --- a/core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java +++ b/core/src/main/java/jenkins/model/ModelObjectWithContextMenu.java @@ -53,7 +53,7 @@ public interface ModelObjectWithContextMenu extends ModelObject { * which implements the default behaviour. See {@link ContextMenu#from(ModelObjectWithContextMenu, StaplerRequest, StaplerResponse)} * for more details of what it does. This should suit most implementations. */ - public ContextMenu doContextMenu(StaplerRequest request, StaplerResponse response) throws Exception; + ContextMenu doContextMenu(StaplerRequest request, StaplerResponse response) throws Exception; /** * Data object that represents the context menu. @@ -61,7 +61,7 @@ public interface ModelObjectWithContextMenu extends ModelObject { * Via {@link HttpResponse}, this class is capable of converting itself to JSON that {@code } understands. */ @ExportedBean - public class ContextMenu implements HttpResponse { + class ContextMenu implements HttpResponse { /** * The actual contents of the menu. */ @@ -225,7 +225,7 @@ public interface ModelObjectWithContextMenu extends ModelObject { * Menu item in {@link ContextMenu} */ @ExportedBean - public class MenuItem { + class MenuItem { /** * Target of the link. * diff --git a/core/src/main/java/jenkins/security/CustomClassFilter.java b/core/src/main/java/jenkins/security/CustomClassFilter.java index f73068f097..979f0d8e7a 100644 --- a/core/src/main/java/jenkins/security/CustomClassFilter.java +++ b/core/src/main/java/jenkins/security/CustomClassFilter.java @@ -84,7 +84,7 @@ public interface CustomClassFilter extends ExtensionPoint { */ @Restricted(NoExternalUse.class) @Extension - public class Static implements CustomClassFilter { + class Static implements CustomClassFilter { /** * Map from {@link Class#getName} to true to permit, false to reject. @@ -132,7 +132,7 @@ public interface CustomClassFilter extends ExtensionPoint { */ @Restricted(NoExternalUse.class) @Extension - public class Contributed implements CustomClassFilter { + class Contributed implements CustomClassFilter { /** * Map from {@link Class#getName} to true to permit, false to reject. diff --git a/core/src/main/java/jenkins/tasks/SimpleBuildStep.java b/core/src/main/java/jenkins/tasks/SimpleBuildStep.java index 83a6c5a9ce..5482dff279 100644 --- a/core/src/main/java/jenkins/tasks/SimpleBuildStep.java +++ b/core/src/main/java/jenkins/tasks/SimpleBuildStep.java @@ -105,7 +105,7 @@ public interface SimpleBuildStep extends BuildStep { @SuppressWarnings("rawtypes") @Restricted(NoExternalUse.class) @Extension - public static final class LastBuildActionFactory extends TransientActionFactory { + final class LastBuildActionFactory extends TransientActionFactory { @Override public Class type() {