diff --git a/core/src/main/java/hudson/FilePath.java b/core/src/main/java/hudson/FilePath.java index cee15b41a7..ecd2b97ce5 100644 --- a/core/src/main/java/hudson/FilePath.java +++ b/core/src/main/java/hudson/FilePath.java @@ -497,7 +497,7 @@ public final class FilePath implements Serializable { private static void unzip(File dir, InputStream in) throws IOException { File tmpFile = File.createTempFile("tmpzip", null); // uses java.io.tmpdir try { - // XXX why does this not simply use ZipInputStream? + // TODO why does this not simply use ZipInputStream? IOUtils.copy(in, tmpFile); unzip(dir,tmpFile); } diff --git a/core/src/main/java/hudson/PluginManager.java b/core/src/main/java/hudson/PluginManager.java index b2aa0e59da..8bdb17ae89 100644 --- a/core/src/main/java/hudson/PluginManager.java +++ b/core/src/main/java/hudson/PluginManager.java @@ -797,7 +797,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas Jenkins.getInstance().checkPermission(Jenkins.ADMINISTER); List> jobs = new ArrayList>(); UpdateCenter uc = Jenkins.getInstance().getUpdateCenter(); - // XXX call uc.updateAllSites() when available? perhaps not, since we should not block on network here + // TODO call uc.updateAllSites() when available? perhaps not, since we should not block on network here for (Map.Entry requestedPlugin : parseRequestedPlugins(configXml).entrySet()) { PluginWrapper pw = getPlugin(requestedPlugin.getKey()); if (pw == null) { // install new diff --git a/core/src/main/java/hudson/Util.java b/core/src/main/java/hudson/Util.java index d91b85fa75..47ad0bc665 100644 --- a/core/src/main/java/hudson/Util.java +++ b/core/src/main/java/hudson/Util.java @@ -1075,14 +1075,14 @@ public class Util { // we still prefer to try JNA first as PosixAPI supports even smaller platforms. POSIX posix = PosixAPI.jnr(); if (posix.isNative()) { - // XXX should we rethrow PosixException as IOException here? + // TODO should we rethrow PosixException as IOException here? r = posix.symlink(targetPath,symlinkFile.getAbsolutePath()); } } } if (r==null) { // if all else fail, fall back to the most expensive approach of forking a process - // XXX is this really necessary? JavaPOSIX should do this automatically + // TODO is this really necessary? JavaPOSIX should do this automatically r = new LocalProc(new String[]{ "ln","-s", targetPath, symlinkPath}, new String[0],listener.getLogger(), baseDir).join(); diff --git a/core/src/main/java/hudson/model/Fingerprint.java b/core/src/main/java/hudson/model/Fingerprint.java index e30143f452..c1b40239aa 100644 --- a/core/src/main/java/hudson/model/Fingerprint.java +++ b/core/src/main/java/hudson/model/Fingerprint.java @@ -724,7 +724,7 @@ public class Fingerprint implements ModelObject, Saveable { } void addWithoutSaving(String jobFullName, int n) { - synchronized(usages) { // XXX why not synchronized (this) like some, though not all, other accesses? + synchronized(usages) { // TODO why not synchronized (this) like some, though not all, other accesses? RangeSet r = usages.get(jobFullName); if(r==null) { r = new RangeSet(); diff --git a/core/src/main/java/hudson/model/JDK.java b/core/src/main/java/hudson/model/JDK.java index 73ca0c9db1..dbf9b2dcad 100644 --- a/core/src/main/java/hudson/model/JDK.java +++ b/core/src/main/java/hudson/model/JDK.java @@ -149,7 +149,7 @@ public final class JDK extends ToolInstallation implements NodeSpecific, En public static class DescriptorImpl extends ToolDescriptor { public String getDisplayName() { - return "JDK"; // XXX I18N + return "JDK"; // TODO I18N } public @Override JDK[] getInstallations() { diff --git a/core/src/main/java/hudson/model/Run.java b/core/src/main/java/hudson/model/Run.java index 474738068b..ef98acb584 100644 --- a/core/src/main/java/hudson/model/Run.java +++ b/core/src/main/java/hudson/model/Run.java @@ -1369,7 +1369,7 @@ public abstract class Run ,RunT extends Run,RunT extends Run getUnprotectedRootActions() { Set names = new TreeSet(); - names.add("jnlpJars"); // XXX cleaner to refactor doJnlpJars into a URA - // XXX consider caching (expiring cache when actions changes) + names.add("jnlpJars"); // TODO cleaner to refactor doJnlpJars into a URA + // TODO consider caching (expiring cache when actions changes) for (Action a : getActions()) { if (a instanceof UnprotectedRootAction) { names.add(a.getUrlName()); diff --git a/core/src/main/java/jenkins/model/lazy/BuildReferenceMapAdapter.java b/core/src/main/java/jenkins/model/lazy/BuildReferenceMapAdapter.java index acc5a10372..362138a2ac 100644 --- a/core/src/main/java/jenkins/model/lazy/BuildReferenceMapAdapter.java +++ b/core/src/main/java/jenkins/model/lazy/BuildReferenceMapAdapter.java @@ -100,7 +100,7 @@ class BuildReferenceMapAdapter implements SortedMap { } public boolean containsValue(Object value) { - return core.containsValue(value); // XXX should this be core.containsValue(wrap(value))? + return core.containsValue(value); // TODO should this be core.containsValue(wrap(value))? } public R get(Object key) { @@ -126,7 +126,7 @@ class BuildReferenceMapAdapter implements SortedMap { @Override public boolean equals(Object o) { - return core.equals(o); // XXX this is wrong + return core.equals(o); // TODO this is wrong } @Override diff --git a/core/src/main/resources/hudson/AboutJenkins/index.jelly b/core/src/main/resources/hudson/AboutJenkins/index.jelly index 4b4a5ba458..8b43cd979f 100644 --- a/core/src/main/resources/hudson/AboutJenkins/index.jelly +++ b/core/src/main/resources/hudson/AboutJenkins/index.jelly @@ -48,7 +48,7 @@ THE SOFTWARE.

${%plugin.dependencies}