From b682a5b28d2b60efa294efeee61cd8a2d7f210e5 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Sat, 5 Jun 2010 06:06:52 +0000 Subject: [PATCH] added an ability to use a separate object for a lock. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31751 71c3de6d-444a-0410-be80-ed276b4c234a --- .../main/java/hudson/util/OneShotEvent.java | 41 +++++++++++++------ 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/core/src/main/java/hudson/util/OneShotEvent.java b/core/src/main/java/hudson/util/OneShotEvent.java index e41ab5094d..4c8a0b41c3 100644 --- a/core/src/main/java/hudson/util/OneShotEvent.java +++ b/core/src/main/java/hudson/util/OneShotEvent.java @@ -39,14 +39,25 @@ package hudson.util; */ public final class OneShotEvent { private boolean signaled; + private final Object lock; + + public OneShotEvent() { + this.lock = this; + } + + public OneShotEvent(Object lock) { + this.lock = lock; + } /** * Non-blocking method that signals this event. */ - public synchronized void signal() { - if(signaled) return; - this.signaled = true; - notifyAll(); + public void signal() { + synchronized (lock) { + if(signaled) return; + this.signaled = true; + lock.notifyAll(); + } } /** @@ -55,9 +66,11 @@ public final class OneShotEvent { *

* This method blocks infinitely until a value is offered. */ - public synchronized void block() throws InterruptedException { - while(!signaled) - wait(); + public void block() throws InterruptedException { + synchronized (lock) { + while(!signaled) + lock.wait(); + } } /** @@ -67,15 +80,19 @@ public final class OneShotEvent { * If the specified amount of time elapses, * this method returns null even if the value isn't offered. */ - public synchronized void block(long timeout) throws InterruptedException { - if(!signaled) - wait(timeout); + public void block(long timeout) throws InterruptedException { + synchronized (lock) { + if(!signaled) + lock.wait(timeout); + } } /** * Returns true if a value is offered. */ - public synchronized boolean isSignaled() { - return signaled; + public boolean isSignaled() { + synchronized (lock) { + return signaled; + } } }