From bfb1f246eee2258ccd7b239de29d03f4361b6a3d Mon Sep 17 00:00:00 2001 From: kohsuke Date: Thu, 14 Jun 2007 05:41:48 +0000 Subject: [PATCH] lsof report from an user (Ray V) revealed file handle leaks here, so maybe some XSLT implementations don't close the stream correctly. So I decided to open/close streams by myself. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@3442 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/scm/SubversionSCM.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/scm/SubversionSCM.java b/core/src/main/java/hudson/scm/SubversionSCM.java index 9695a44c3d..2903f08a75 100644 --- a/core/src/main/java/hudson/scm/SubversionSCM.java +++ b/core/src/main/java/hudson/scm/SubversionSCM.java @@ -56,6 +56,8 @@ import java.io.IOException; import java.io.PrintWriter; import java.io.Serializable; import java.io.StringWriter; +import java.io.BufferedOutputStream; +import java.io.OutputStream; import java.util.ArrayList; import java.util.Arrays; import java.util.HashMap; @@ -173,7 +175,15 @@ public class SubversionSCM extends SCM implements Serializable { return createEmptyChangeLog(changelogFile, listener, "log"); } - if(!new SubversionChangeLogBuilder(build,listener,this).run(externals,new StreamResult(changelogFile))) + OutputStream os = new BufferedOutputStream(new FileOutputStream(changelogFile)); + boolean r; + try { + r = new SubversionChangeLogBuilder(build, listener, this).run(externals, new StreamResult(changelogFile)); + } finally { + os.close(); + } + + if(!r) createEmptyChangeLog(changelogFile, listener, "log"); return true;