From bfcc96bbc94899cb0ede173dca41a3e6c17f5235 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Fri, 16 Jan 2009 15:14:14 +0000 Subject: [PATCH] If a build has no change, e-mail shouldn't link to the empty changeset page. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@14541 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/tasks/MailSender.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/core/src/main/java/hudson/tasks/MailSender.java b/core/src/main/java/hudson/tasks/MailSender.java index 4b0cb56761..8d5efaec51 100644 --- a/core/src/main/java/hudson/tasks/MailSender.java +++ b/core/src/main/java/hudson/tasks/MailSender.java @@ -14,8 +14,6 @@ import javax.mail.internet.InternetAddress; import javax.mail.internet.MimeMessage; import java.io.File; import java.io.IOException; -import java.io.PrintWriter; -import java.io.StringWriter; import java.util.Date; import java.util.LinkedHashSet; import java.util.List; @@ -149,7 +147,10 @@ public class MailSender { private void appendBuildUrl(AbstractBuild build, StringBuffer buf) { String baseUrl = Mailer.DESCRIPTOR.getUrl(); if (baseUrl != null) { - buf.append("See ").append(baseUrl).append(Util.encode(build.getUrl())).append("changes\n\n"); + buf.append("See ").append(baseUrl).append(Util.encode(build.getUrl())); + if(!build.getChangeSet().isEmptySet()) + buf.append("changes"); + buf.append("\n\n"); } }