From c467e67e46d43b6e868ae97ee555d3dcfc8e3a85 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Sat, 20 Jan 2007 06:50:23 +0000 Subject: [PATCH] more bug fixes. git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1830 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/model/Hudson.java | 8 ++++++-- core/src/main/java/hudson/model/User.java | 8 ++++---- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/core/src/main/java/hudson/model/Hudson.java b/core/src/main/java/hudson/model/Hudson.java index a65f85c4d3..201255f8fd 100644 --- a/core/src/main/java/hudson/model/Hudson.java +++ b/core/src/main/java/hudson/model/Hudson.java @@ -398,7 +398,11 @@ public final class Hudson extends View implements ItemGroup, Node } /** - * Gets the snapshot of all the projects. + * Gets the list of all the projects. + * + *

+ * Since {@link Project} can only show up under {@link Hudson}, + * no need to search recursively. */ public List getProjects() { return Util.createSubList(items.values(),Project.class); @@ -1308,7 +1312,7 @@ public final class Hudson extends View implements ItemGroup, Node */ public Set getAllCvsRoots() { Set r = new TreeSet(); - for( Project p : getProjects() ) { + for( AbstractProject p : getAllItems(AbstractProject.class) ) { SCM scm = p.getScm(); if (scm instanceof CVSSCM) { CVSSCM cvsscm = (CVSSCM) scm; diff --git a/core/src/main/java/hudson/model/User.java b/core/src/main/java/hudson/model/User.java index 7b4e267b25..305f290548 100644 --- a/core/src/main/java/hudson/model/User.java +++ b/core/src/main/java/hudson/model/User.java @@ -153,10 +153,10 @@ public class User extends AbstractModelObject { * * TODO: do we need some index for this? */ - public List getBuilds() { - List r = new ArrayList(); - for (Project p : Hudson.getInstance().getProjects()) { - for (Build b : p.getBuilds()) { + public List getBuilds() { + List r = new ArrayList(); + for (AbstractProject p : Hudson.getInstance().getAllItems(AbstractProject.class)) { + for (AbstractBuild b : p.getBuilds()) { for (ChangeLogSet.Entry e : b.getChangeSet()) { if(e.getAuthor()==this) { r.add(b);