From c9db91664dc66f4307d8d5aa4aaa14e840a08698 Mon Sep 17 00:00:00 2001 From: mindless Date: Sun, 5 Jul 2009 20:17:39 +0000 Subject: [PATCH] [FIXED HUDSON-3590] don't create new in-memory user when someone attempts login with invalid username git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19411 71c3de6d-444a-0410-be80-ed276b4c234a --- .../main/java/hudson/security/HudsonPrivateSecurityRealm.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java b/core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java index cd18c92d30..2566be6228 100644 --- a/core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java +++ b/core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java @@ -384,7 +384,8 @@ public class HudsonPrivateSecurityRealm extends SecurityRealm implements ModelOb */ public static final class HudsonUserDetailsService implements UserDetailsService { public UserDetails loadUserByUsername(String username) { - Details p = User.get(username).getProperty(Details.class); + User u = User.get(username,false); + Details p = u!=null ? u.getProperty(Details.class) : null; if(p==null) throw new UsernameNotFoundException("Password is not set: "+username); if(p.getUser()==null)