diff --git a/changelog.html b/changelog.html
index a19a3ded8e..af90ef25b5 100644
--- a/changelog.html
+++ b/changelog.html
@@ -58,15 +58,19 @@ Upcoming changes
Master labels disappear when system configuration is updated.
(issue 23966)
-
- After recent Java security updates, Jenkins would not gracefully recover from a deleted secrets/master.key.
- (issue 25937)
-
+
+
+ -
+ After recent Java security updates, Jenkins would not gracefully recover from a deleted
secrets/master.key.
+ (issue 25937)
+
+
+
-
-
diff --git a/cli/pom.xml b/cli/pom.xml
index 41afe85d6b..4b40627511 100644
--- a/cli/pom.xml
+++ b/cli/pom.xml
@@ -5,7 +5,7 @@
pom
org.jenkins-ci.main
- 1.594-SNAPSHOT
+ 1.595-SNAPSHOT
cli
diff --git a/core/pom.xml b/core/pom.xml
index f417985049..87c29d78a7 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -29,7 +29,7 @@ THE SOFTWARE.
org.jenkins-ci.main
pom
- 1.594-SNAPSHOT
+ 1.595-SNAPSHOT
../pom.xml
diff --git a/core/src/main/java/hudson/tools/JDKInstaller.java b/core/src/main/java/hudson/tools/JDKInstaller.java
index 28d9947abe..2cddb4d69c 100644
--- a/core/src/main/java/hudson/tools/JDKInstaller.java
+++ b/core/src/main/java/hudson/tools/JDKInstaller.java
@@ -234,13 +234,15 @@ public class JDKInstaller extends ToolInstaller {
- http://java.sun.com/j2se/1.5.0/sdksilent.html
- http://java.sun.com/j2se/1.4.2/docs/guide/plugin/developer_guide/silent.html
*/
- String logFile = jdkBundle+".install.log";
expectedLocation = expectedLocation.trim();
if (expectedLocation.endsWith("\\")) {
// Prevent a trailing slash from escaping quotes
expectedLocation = expectedLocation.substring(0, expectedLocation.length() - 1);
}
+ String logFile = new FilePath(launcher.getChannel(), expectedLocation).getParent().createTempFile("install", "log").getRemote();
+
+
ArgumentListBuilder args = new ArgumentListBuilder();
assert (new File(expectedLocation).exists()) : expectedLocation
+ " must exist, otherwise /L will cause the installer to fail with error 1622";
@@ -248,20 +250,19 @@ public class JDKInstaller extends ToolInstaller {
// Installer uses InstallShield.
args.add("CMD.EXE", "/C");
+ // see http://docs.oracle.com/javase/1.5.0/docs/guide/deployment/deployment-guide/silent.html
// CMD.EXE /C must be followed by a single parameter (do not split it!)
args.add(jdkBundle + " /s /v\"/qn REBOOT=ReallySuppress INSTALLDIR=\\\""
- + expectedLocation + "\\\" /L \\\"" + expectedLocation
- + "\\jdk.exe.install.log\\\"\"");
+ + expectedLocation + "\\\" /L \\\"" + logFile + "\\\"\"");
} else {
// Installed uses Windows Installer (MSI)
args.add(jdkBundle, "/s");
// Create a private JRE by omitting "PublicjreFeature"
// @see http://docs.oracle.com/javase/7/docs/webnotes/install/windows/jdk-installation-windows.html#jdk-silent-installation
- args.add("ADDLOCAL=\"ToolsFeature\"");
-
- args.add("REBOOT=ReallySuppress", "INSTALLDIR=" + expectedLocation,
- "/L \\\"" + expectedLocation + "\\jdk.exe.install.log\\\"");
+ args.add("ADDLOCAL=\"ToolsFeature\"",
+ "REBOOT=ReallySuppress", "INSTALLDIR=" + expectedLocation,
+ "/L", logFile);
}
int r = launcher.launch().cmds(args).stdout(out)
.pwd(new FilePath(launcher.getChannel(), expectedLocation)).join();
@@ -716,7 +717,7 @@ public class JDKInstaller extends ToolInstaller {
if (value) {
return FormValidation.ok();
} else {
- return FormValidation.error(Messages.JDKInstaller_DescriptorImpl_doCheckAcceptLicense());
+ return FormValidation.error(Messages.JDKInstaller_DescriptorImpl_doCheckAcceptLicense());
}
}
diff --git a/debian/debian/changelog b/debian/debian/changelog
index 5e62ab72b7..69281d0bf9 100644
--- a/debian/debian/changelog
+++ b/debian/debian/changelog
@@ -1,3 +1,9 @@
+jenkins (1.593) unstable; urgency=low
+
+ * See http://jenkins-ci.org/changelog for more details.
+
+ -- Kohsuke Kawaguchi Sun, 07 Dec 2014 21:02:37 -0800
+
jenkins (1.592) unstable; urgency=low
* See http://jenkins-ci.org/changelog for more details.
diff --git a/plugins/pom.xml b/plugins/pom.xml
index 4420f7a17f..2ef88c6eb5 100644
--- a/plugins/pom.xml
+++ b/plugins/pom.xml
@@ -11,7 +11,7 @@
org.jenkins-ci.plugins
plugin
Jenkins plugin POM
- 1.594-SNAPSHOT
+ 1.595-SNAPSHOT
pom