Fix SIC_INNER_SHOULD_BE_STATIC SpotBugs violations

This commit is contained in:
Basil Crow committed 2021-12-06 14:02:59 -08:00
1 parent f7bc2b5da6
commit cd91b39f56
7 files changed
+8 -21

No files matched your search

+2 -2
View File
@@ -1035,7 +1035,7 @@ public final class FilePath implements SerializableOnlyOverRemoting {
}
// this reads from arbitrary URL
private final class Unpack extends MasterToSlaveFileCallable<Void> {
private static final class Unpack extends MasterToSlaveFileCallable<Void> {
private final URL archive;
Unpack(URL archive) {
this.archive = archive;
@@ -2938,7 +2938,7 @@ public final class FilePath implements SerializableOnlyOverRemoting {
public @CheckForNull String validateAntFileMask(final String fileMasks, final int bound, final boolean caseSensitive) throws IOException, InterruptedException {
return act(new ValidateAntFileMask(fileMasks, caseSensitive, bound));
}
private class ValidateAntFileMask extends MasterToSlaveFileCallable<String> {
private static class ValidateAntFileMask extends MasterToSlaveFileCallable<String> {
private final String fileMasks;
private final boolean caseSensitive;
private final int bound;
+2 -2
View File
@@ -1738,7 +1738,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
void cleanup();
}
class FileUploadPluginCopier implements PluginCopier {
static class FileUploadPluginCopier implements PluginCopier {
private FileItem fileItem;
FileUploadPluginCopier(FileItem fileItem) {
@@ -1756,7 +1756,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
}
}
class UrlPluginCopier implements PluginCopier {
static class UrlPluginCopier implements PluginCopier {
private String url;
UrlPluginCopier(String url) {
@@ -51,7 +51,7 @@ public final class MemoryUsageMonitor extends PeriodicWork {
/**
* A memory group is conceptually a set of memory pools.
*/
public final class MemoryGroup {
public static final class MemoryGroup {
private final List<MemoryPoolMXBean> pools = new ArrayList<>();
/**
+1 -1
View File
@@ -2453,7 +2453,7 @@ public class Queue extends ResourceController implements Saveable {
@Restricted(NoExternalUse.class)
@ExportedBean(defaultVisibility = 999)
@SuppressFBWarnings(value = "URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD", justification = "it is exported, so it might be used")
public class StubItem {
public static class StubItem {
@Exported public StubTask task;
@@ -62,7 +62,7 @@ public class LogRotator extends BuildDiscarder {
/** @deprecated Replaced by more generic {@link CompositeIOException}. */
@Deprecated
public class CollatedLogRotatorException extends IOException {
public static class CollatedLogRotatorException extends IOException {
private static final long serialVersionUID = 5944233808072651101L;
public final Collection<Exception> collated;
@@ -94,7 +94,7 @@ public class SlowTriggerAdminMonitor extends AdministrativeMonitor {
return HttpResponses.redirectViaContextPath("/manage");
}
public class Value {
public static class Value {
private final LocalDateTime time;
private Class<? extends TriggerDescriptor> trigger;