From cd92d7f88fdcf7c83d9103ffa097b53298d0e532 Mon Sep 17 00:00:00 2001 From: Basil Crow Date: Fri, 3 Dec 2021 12:25:01 -0800 Subject: [PATCH] Fix `PublicConstructorForAbstractClass` Error Prone violations (#5951) --- core/src/main/java/hudson/FilePath.java | 2 +- core/src/main/java/hudson/Launcher.java | 2 +- core/src/main/java/hudson/PluginManager.java | 2 +- .../java/hudson/console/ConsoleAnnotationDescriptor.java | 4 ++-- core/src/main/java/hudson/model/Computer.java | 2 +- .../src/main/java/hudson/model/FullDuplexHttpChannel.java | 2 +- core/src/main/java/hudson/model/Label.java | 2 +- core/src/main/java/hudson/model/ParameterDefinition.java | 4 ++-- core/src/main/java/hudson/model/Project.java | 2 +- core/src/main/java/hudson/model/Slave.java | 8 ++++---- .../main/java/hudson/model/labels/LabelExpression.java | 2 +- .../hudson/node_monitors/AbstractDiskSpaceMonitor.java | 4 ++-- core/src/main/java/hudson/slaves/AbstractCloudSlave.java | 6 +++--- .../main/java/hudson/slaves/ComputerLauncherFilter.java | 2 +- core/src/main/java/hudson/tasks/CommandInterpreter.java | 2 +- .../main/java/hudson/tools/AbstractCommandInstaller.java | 2 +- .../main/java/hudson/tools/DownloadFromUrlInstaller.java | 2 +- core/src/main/java/hudson/tools/ToolInstallation.java | 6 +++--- core/src/main/java/hudson/util/FormFieldValidator.java | 2 +- core/src/main/java/hudson/util/XStream2.java | 2 +- .../main/java/jenkins/security/RSAConfidentialKey.java | 4 ++-- .../java/jenkins/util/InterceptingExecutorService.java | 2 +- .../main/java/jenkins/util/MarkFindingOutputStream.java | 2 +- .../jenkins/util/groovy/AbstractGroovyViewModule.java | 2 +- .../java/org/acegisecurity/AcegiSecurityException.java | 4 ++-- .../java/org/acegisecurity/AuthenticationException.java | 6 +++--- .../providers/AbstractAuthenticationToken.java | 4 ++-- 27 files changed, 42 insertions(+), 42 deletions(-) diff --git a/core/src/main/java/hudson/FilePath.java b/core/src/main/java/hudson/FilePath.java index ef4867ea0a..08ace200fe 100644 --- a/core/src/main/java/hudson/FilePath.java +++ b/core/src/main/java/hudson/FilePath.java @@ -1197,7 +1197,7 @@ public final class FilePath implements SerializableOnlyOverRemoting { private final DelegatingCallable callable; - public AbstractInterceptorCallableWrapper(DelegatingCallable callable) { + protected AbstractInterceptorCallableWrapper(DelegatingCallable callable) { this.callable = callable; } diff --git a/core/src/main/java/hudson/Launcher.java b/core/src/main/java/hudson/Launcher.java index b14cee5418..85fc42ea5b 100644 --- a/core/src/main/java/hudson/Launcher.java +++ b/core/src/main/java/hudson/Launcher.java @@ -97,7 +97,7 @@ public abstract class Launcher { @Restricted(Beta.class) protected EnvVarsFilterRuleWrapper envVarsFilterRuleWrapper; - public Launcher(@NonNull TaskListener listener, @CheckForNull VirtualChannel channel) { + protected Launcher(@NonNull TaskListener listener, @CheckForNull VirtualChannel channel) { this.listener = listener; this.channel = channel; } diff --git a/core/src/main/java/hudson/PluginManager.java b/core/src/main/java/hudson/PluginManager.java index 957f161895..e45bc76ba1 100644 --- a/core/src/main/java/hudson/PluginManager.java +++ b/core/src/main/java/hudson/PluginManager.java @@ -351,7 +351,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas */ private final PluginStrategy strategy; - public PluginManager(ServletContext context, File rootDir) { + protected PluginManager(ServletContext context, File rootDir) { this.context = context; this.rootDir = rootDir; diff --git a/core/src/main/java/hudson/console/ConsoleAnnotationDescriptor.java b/core/src/main/java/hudson/console/ConsoleAnnotationDescriptor.java index 1cfbbbfd4f..3f9a17d143 100644 --- a/core/src/main/java/hudson/console/ConsoleAnnotationDescriptor.java +++ b/core/src/main/java/hudson/console/ConsoleAnnotationDescriptor.java @@ -42,11 +42,11 @@ import org.kohsuke.stapler.WebMethod; * @since 1.349 */ public abstract class ConsoleAnnotationDescriptor extends Descriptor> implements ExtensionPoint { - public ConsoleAnnotationDescriptor(Class> clazz) { + protected ConsoleAnnotationDescriptor(Class> clazz) { super(clazz); } - public ConsoleAnnotationDescriptor() { + protected ConsoleAnnotationDescriptor() { } /** diff --git a/core/src/main/java/hudson/model/Computer.java b/core/src/main/java/hudson/model/Computer.java index efd82044bd..c6586cd354 100644 --- a/core/src/main/java/hudson/model/Computer.java +++ b/core/src/main/java/hudson/model/Computer.java @@ -251,7 +251,7 @@ public /*transient*/ abstract class Computer extends Actionable implements Acces return new ArrayList<>(terminatedBy); } - public Computer(Node node) { + protected Computer(Node node) { setNode(node); } diff --git a/core/src/main/java/hudson/model/FullDuplexHttpChannel.java b/core/src/main/java/hudson/model/FullDuplexHttpChannel.java index f7da784a93..6251bddec8 100644 --- a/core/src/main/java/hudson/model/FullDuplexHttpChannel.java +++ b/core/src/main/java/hudson/model/FullDuplexHttpChannel.java @@ -44,7 +44,7 @@ public abstract class FullDuplexHttpChannel extends FullDuplexHttpService { private Channel channel; private final boolean restricted; - public FullDuplexHttpChannel(UUID uuid, boolean restricted) throws IOException { + protected FullDuplexHttpChannel(UUID uuid, boolean restricted) throws IOException { super(uuid); this.restricted = restricted; } diff --git a/core/src/main/java/hudson/model/Label.java b/core/src/main/java/hudson/model/Label.java index 367a25f360..0e38b876f8 100644 --- a/core/src/main/java/hudson/model/Label.java +++ b/core/src/main/java/hudson/model/Label.java @@ -97,7 +97,7 @@ public abstract class Label extends Actionable implements Comparable