From cf45c6a8f2eed7bdd8bb74c8d756fb34598ff06e Mon Sep 17 00:00:00 2001 From: Jesse Glick Date: Tue, 5 Nov 2013 14:33:56 -0500 Subject: [PATCH] Another case where RunAction2 is needed: SCM tag actions. --- .../main/java/hudson/scm/AbstractScmTagAction.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/core/src/main/java/hudson/scm/AbstractScmTagAction.java b/core/src/main/java/hudson/scm/AbstractScmTagAction.java index a3889259a9..e4477ad213 100644 --- a/core/src/main/java/hudson/scm/AbstractScmTagAction.java +++ b/core/src/main/java/hudson/scm/AbstractScmTagAction.java @@ -26,6 +26,7 @@ package hudson.scm; import hudson.model.AbstractBuild; import hudson.model.TaskAction; import hudson.model.BuildBadgeAction; +import hudson.model.Run; import hudson.security.Permission; import hudson.security.ACL; import org.kohsuke.stapler.StaplerRequest; @@ -33,6 +34,7 @@ import org.kohsuke.stapler.StaplerResponse; import javax.servlet.ServletException; import java.io.IOException; +import jenkins.model.RunAction2; /** * Common part of CVSSCM.TagAction and SubversionTagAction. @@ -44,8 +46,8 @@ import java.io.IOException; * * @author Kohsuke Kawaguchi */ -public abstract class AbstractScmTagAction extends TaskAction implements BuildBadgeAction { - protected final AbstractBuild build; +public abstract class AbstractScmTagAction extends TaskAction implements BuildBadgeAction, RunAction2 { + protected transient /*final*/ AbstractBuild build; protected AbstractScmTagAction(AbstractBuild build) { this.build = build; @@ -93,4 +95,12 @@ public abstract class AbstractScmTagAction extends TaskAction implements BuildBa return "tagForm.jelly"; } + @Override public void onAttached(Run r) { + // unnecessary, constructor already does this + } + + @Override public void onLoad(Run r) { + build = (AbstractBuild) r; + } + }