Prevent new SpotBugs violations from being introduced (#6015)

This commit is contained in:
Basil Crow authored and GitHub committed 2021-12-06 13:52:38 -08:00
1 parent 6767b4660d
commit d5cea69751
58 files changed
+902 -89

No files matched your search

+4 -2
View File
@@ -2687,6 +2687,7 @@ public final class FilePath implements SerializableOnlyOverRemoting {
scanner.scan(base, reading(new FileVisitor() {
private boolean exceptionEncountered;
private boolean logMessageShown;
@SuppressFBWarnings(value = "PATH_TRAVERSAL_IN", justification = "TODO needs triage")
@Override
public void visit(File f, String relativePath) throws IOException {
if (f.isFile()) {
@@ -2720,6 +2721,7 @@ public final class FilePath implements SerializableOnlyOverRemoting {
public boolean understandsSymlink() {
return true;
}
@SuppressFBWarnings(value = "PATH_TRAVERSAL_IN", justification = "TODO needs triage")
@Override
public void visitSymlink(File link, String target, String relativePath) throws IOException {
try {
@@ -2917,7 +2919,7 @@ public final class FilePath implements SerializableOnlyOverRemoting {
* Default bound for {@link #validateAntFileMask(String, int, boolean)}.
* @since 1.592
*/
@SuppressFBWarnings("MS_SHOULD_BE_FINAL")
@SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "for script console")
public static int VALIDATE_ANT_FILE_MASK_BOUND = SystemProperties.getInteger(FilePath.class.getName() + ".VALIDATE_ANT_FILE_MASK_BOUND", 10000);
/**
@@ -3298,7 +3300,7 @@ public final class FilePath implements SerializableOnlyOverRemoting {
private static final long serialVersionUID = 1L;
@SuppressFBWarnings("MS_SHOULD_BE_FINAL")
@SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "TODO needs triage")
public static int SIDE_BUFFER_SIZE = 1024;
private static final Logger LOGGER = Logger.getLogger(FilePath.class.getName());