[JENKINS-37041] Address Code review comments

This commit is contained in:
Stephen Connolly committed 2016-07-28 16:30:17 +01:00
1 parent 2a450e5ac2
commit d92fd4cc63
2 files changed
+9 -13

No files matched your search

+3 -3
View File
@@ -720,11 +720,11 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
final Set<ClassicPluginStrategy.DetachedPlugin> forceUpgrade = new HashSet<>();
for (ClassicPluginStrategy.DetachedPlugin p : ClassicPluginStrategy.getDetachedPlugins()) {
VersionNumber installedVersion = getPluginVersion(rootDir, p.getShortName());
VersionNumber requireVersion = p.getRequireVersion();
if (installedVersion != null && installedVersion.isOlderThan(requireVersion)) {
VersionNumber requiredVersion = p.getRequiredVersion();
if (installedVersion != null && installedVersion.isOlderThan(requiredVersion)) {
LOGGER.log(Level.WARNING,
"Detached plugin {0} found at version {1}, required minimum version is {2}",
new Object[]{p.getShortName(), installedVersion, requireVersion});
new Object[]{p.getShortName(), installedVersion, requiredVersion});
forceUpgrade.add(p);
}
}