From df259d7a898ee5f004e4491e7e6362b61fffbce2 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Fri, 2 Dec 2011 15:36:37 -0800 Subject: [PATCH] fixing NPE. getUrlName() contract allows returning null. --- core/src/main/java/hudson/model/View.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/model/View.java b/core/src/main/java/hudson/model/View.java index 4b3959d9cc..de1316aae4 100644 --- a/core/src/main/java/hudson/model/View.java +++ b/core/src/main/java/hudson/model/View.java @@ -454,9 +454,12 @@ public abstract class View extends AbstractModelObject implements AccessControll } public Object getDynamic(String token) { - for (Action a : getActions()) + for (Action a : getActions()) { + String url = a.getUrlName(); + if (url==null) continue; if(a.getUrlName().equals(token)) return a; + } return null; }