From 40f3b095aae871589b296e455dfad04f368c3dc3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gl=C3=B6ckle=20Bastian?= Date: Wed, 3 Jul 2013 14:56:14 +0200 Subject: [PATCH] [FIXES JENKINS-15976] After de-serializing changed job settings after "Save", the maven settings done by config-file-provider-plugin were overwritten blindly (presumably with fallback values). These fallback values should be set correctly in the constructor of the "Maven" class and do not need to be set explicitly after deserialization. --- core/src/main/java/hudson/tasks/Maven.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/core/src/main/java/hudson/tasks/Maven.java b/core/src/main/java/hudson/tasks/Maven.java index c2fe89b465..078129d2e3 100644 --- a/core/src/main/java/hudson/tasks/Maven.java +++ b/core/src/main/java/hudson/tasks/Maven.java @@ -435,10 +435,7 @@ public class Maven extends Builder { @Override public Builder newInstance(StaplerRequest req, JSONObject formData) throws FormException { - Maven m = req.bindJSON(Maven.class,formData); - m.setSettings(GlobalMavenConfig.get().getSettingsProvider()); - m.setGlobalSettings(GlobalMavenConfig.get().getGlobalSettingsProvider()); - return m; + return req.bindJSON(Maven.class,formData); } }