diff --git a/core/src/main/java/hudson/scm/SubversionTagAction.java b/core/src/main/java/hudson/scm/SubversionTagAction.java index cbe1db42c2..87a61cdaa1 100644 --- a/core/src/main/java/hudson/scm/SubversionTagAction.java +++ b/core/src/main/java/hudson/scm/SubversionTagAction.java @@ -136,22 +136,31 @@ public class SubversionTagAction extends AbstractScmTagAction { @Override protected void perform(TaskListener listener) { - SVNClientManager cm = SubversionSCM.createSvnClientManager(SubversionSCM.DescriptorImpl.DESCRIPTOR.createAuthenticationProvider()); + try { + SVNClientManager cm = SubversionSCM.createSvnClientManager(SubversionSCM.DescriptorImpl.DESCRIPTOR.createAuthenticationProvider()); - for (Entry e : tagSet.entrySet()) { - PrintStream logger = listener.getLogger(); - logger.println("Tagging "+e.getKey()+" to "+e.getValue()); + for (Entry e : tagSet.entrySet()) { + PrintStream logger = listener.getLogger(); + logger.println("Tagging "+e.getKey()+" to "+e.getValue()); - try { - SVNURL src = SVNURL.parseURIDecoded(e.getKey().url); - SVNURL dst = SVNURL.parseURIDecoded(e.getValue()); + try { + SVNURL src = SVNURL.parseURIDecoded(e.getKey().url); + SVNURL dst = SVNURL.parseURIDecoded(e.getValue()); - SVNCopyClient svncc = cm.getCopyClient(); - svncc.doCopy(src, SVNRevision.create(e.getKey().revision), dst, false, true, "Tagged from "+build ); - } catch (SVNException x) { - x.printStackTrace(listener.error("Failed to tag")); + SVNCopyClient svncc = cm.getCopyClient(); + svncc.doCopy(src, SVNRevision.create(e.getKey().revision), dst, false, true, "Tagged from "+build ); + } catch (SVNException x) { + x.printStackTrace(listener.error("Failed to tag")); + return; + } } - } + + // completed successfully + SubversionTagAction.this.tags.putAll(tagSet); + build.save(); + } catch (Throwable e) { + e.printStackTrace(listener.fatalError(e.getMessage())); + } } } }