From e94152df33e8334bf3b89a66cd25de0df771ec9f Mon Sep 17 00:00:00 2001 From: Jesse Glick Date: Thu, 21 Mar 2013 16:30:29 -0400 Subject: [PATCH] =?UTF-8?q?Avoiding=20printing=20anything=20unless=20there?= =?UTF-8?q?=20is=20actually=20a=20failure.=20Also=20take=20advantage=20of?= =?UTF-8?q?=20JUnit=E2=80=99s=20ability=20to=20show=20the=20exact=20spot?= =?UTF-8?q?=20of=20a=20mismatch=20between=20two=20strings.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- core/src/test/java/hudson/scheduler/CronTabTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/core/src/test/java/hudson/scheduler/CronTabTest.java b/core/src/test/java/hudson/scheduler/CronTabTest.java index fdb35997e2..b312ddca18 100644 --- a/core/src/test/java/hudson/scheduler/CronTabTest.java +++ b/core/src/test/java/hudson/scheduler/CronTabTest.java @@ -176,10 +176,9 @@ public class CronTabTest { /** * Humans can't easily see difference in two {@link Calendar}s, do help the diagnosis by using {@link DateFormat}. */ - private void compare(Calendar a, Calendar b) { + private void compare(Calendar expected, Calendar actual) { DateFormat f = DateFormat.getDateTimeInstance(); - System.out.println(f.format(a.getTime())+" vs "+f.format(b.getTime())); - assertEquals(a,b); + assertEquals(f.format(expected.getTime()), f.format(actual.getTime())); } @Test