From f555cb6e7a0d4199a4417841e7b42e7f61786c22 Mon Sep 17 00:00:00 2001 From: Baptiste Mathus Date: Sun, 3 Dec 2017 14:42:09 +0100 Subject: [PATCH] Bump to a bit longer (Note: mainly bumping for the CI to not fail since I was never able to see this test fail on my machine [takes ~17 with this change] anyway other than by running in Docker and aggressively reduce IOPS to 40 using Docker resource constraints.) Since we now *actually* sync to disk, this isn't really a regression IMO. From the very role of AtomicFileWriter, it looks more like a feature or an improvement than an issue. So I suspect that anyway 1) we won't see a lot of bad impact in the wild on most setups (as we generally already recommend SSDs and so on as per how Jenkins works) and 2) we win anyway in term of integrity by making sure (well, raising the chances, let's say) we do write to disk before renaming files. --- test/src/test/java/hudson/util/AtomicFileWriterPerfTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/src/test/java/hudson/util/AtomicFileWriterPerfTest.java b/test/src/test/java/hudson/util/AtomicFileWriterPerfTest.java index 94d5e6c687..31942ed318 100644 --- a/test/src/test/java/hudson/util/AtomicFileWriterPerfTest.java +++ b/test/src/test/java/hudson/util/AtomicFileWriterPerfTest.java @@ -24,7 +24,7 @@ public class AtomicFileWriterPerfTest { * really bad performance regressions. */ @Issue("JENKINS-34855") - @Test(timeout = 30 * 1000L) + @Test(timeout = 50 * 1000L) public void poorManPerformanceTestBed() throws Exception { int count = 1000; while (count-- > 0) {