diff --git a/core/src/main/java/hudson/Functions.java b/core/src/main/java/hudson/Functions.java index b5980a9d2e..1d186bf861 100644 --- a/core/src/main/java/hudson/Functions.java +++ b/core/src/main/java/hudson/Functions.java @@ -27,8 +27,8 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import java.io.File; import java.io.IOException; -import java.io.StringWriter; import java.io.PrintWriter; +import java.io.StringWriter; import java.lang.management.LockInfo; import java.lang.management.ManagementFactory; import java.lang.management.MonitorInfo; @@ -46,6 +46,7 @@ import java.util.SortedMap; import java.util.TreeMap; import java.util.logging.LogRecord; import java.util.logging.SimpleFormatter; +import java.util.regex.Pattern; /** * Utility functions used in views. @@ -630,4 +631,15 @@ public class Functions { t.printStackTrace(new PrintWriter(sw)); return sw.toString(); } + + /** + * Counts the number of rows needed for textarea to fit the content. + * Minimum 5 rows. + */ + public static int determineRows(String s) { + if(s==null) return 5; + return Math.max(5,LINE_END.split(s).length); + } + + private static final Pattern LINE_END = Pattern.compile("\r?\n"); } diff --git a/core/src/main/resources/hudson/model/AbstractModelObject/descriptionForm.jelly b/core/src/main/resources/hudson/model/AbstractModelObject/descriptionForm.jelly index 5ea06bfebd..97b0e92732 100644 --- a/core/src/main/resources/hudson/model/AbstractModelObject/descriptionForm.jelly +++ b/core/src/main/resources/hudson/model/AbstractModelObject/descriptionForm.jelly @@ -1,12 +1,13 @@ - - -
- -
- -
-
+ + +
+ +
+ +
+ +
\ No newline at end of file diff --git a/core/src/main/resources/hudson/model/AbstractModelObject/editDescription.jelly b/core/src/main/resources/hudson/model/AbstractModelObject/editDescription.jelly index 0896aca740..48c66ea300 100644 --- a/core/src/main/resources/hudson/model/AbstractModelObject/editDescription.jelly +++ b/core/src/main/resources/hudson/model/AbstractModelObject/editDescription.jelly @@ -6,7 +6,7 @@
- +
diff --git a/core/src/main/resources/hudson/model/Hudson/configure.jelly b/core/src/main/resources/hudson/model/Hudson/configure.jelly index 8e76ba6440..cc3fa86ad7 100644 --- a/core/src/main/resources/hudson/model/Hudson/configure.jelly +++ b/core/src/main/resources/hudson/model/Hudson/configure.jelly @@ -10,8 +10,7 @@ ${it.rootDir} - + - + diff --git a/core/src/main/resources/hudson/model/ListView/configure.jelly b/core/src/main/resources/hudson/model/ListView/configure.jelly index 4978235133..0d91cad14e 100644 --- a/core/src/main/resources/hudson/model/ListView/configure.jelly +++ b/core/src/main/resources/hudson/model/ListView/configure.jelly @@ -10,8 +10,7 @@ - + diff --git a/core/src/main/resources/hudson/model/User/configure.jelly b/core/src/main/resources/hudson/model/User/configure.jelly index 0058f7a395..c9a7c2cfb9 100644 --- a/core/src/main/resources/hudson/model/User/configure.jelly +++ b/core/src/main/resources/hudson/model/User/configure.jelly @@ -10,8 +10,7 @@ - + diff --git a/core/src/main/resources/hudson/tasks/BatchFile/config.jelly b/core/src/main/resources/hudson/tasks/BatchFile/config.jelly index 0d835c1282..38e7b7b097 100644 --- a/core/src/main/resources/hudson/tasks/BatchFile/config.jelly +++ b/core/src/main/resources/hudson/tasks/BatchFile/config.jelly @@ -1,7 +1,6 @@ - + \ No newline at end of file diff --git a/core/src/main/resources/hudson/tasks/Shell/config.jelly b/core/src/main/resources/hudson/tasks/Shell/config.jelly index d310b957c8..fc3030a919 100644 --- a/core/src/main/resources/hudson/tasks/Shell/config.jelly +++ b/core/src/main/resources/hudson/tasks/Shell/config.jelly @@ -1,7 +1,6 @@ - + \ No newline at end of file diff --git a/core/src/main/resources/hudson/triggers/SCMTrigger/config.jelly b/core/src/main/resources/hudson/triggers/SCMTrigger/config.jelly index 5e4d50e941..107fc2183a 100644 --- a/core/src/main/resources/hudson/triggers/SCMTrigger/config.jelly +++ b/core/src/main/resources/hudson/triggers/SCMTrigger/config.jelly @@ -1,6 +1,5 @@ - + \ No newline at end of file diff --git a/core/src/main/resources/hudson/triggers/TimerTrigger/config.jelly b/core/src/main/resources/hudson/triggers/TimerTrigger/config.jelly index 8ba5979ed6..b730811449 100644 --- a/core/src/main/resources/hudson/triggers/TimerTrigger/config.jelly +++ b/core/src/main/resources/hudson/triggers/TimerTrigger/config.jelly @@ -1,6 +1,5 @@ - + \ No newline at end of file diff --git a/core/src/main/resources/lib/form/expandableTextbox.jelly b/core/src/main/resources/lib/form/expandableTextbox.jelly index 6d76efb59a..53e26f1cc0 100644 --- a/core/src/main/resources/lib/form/expandableTextbox.jelly +++ b/core/src/main/resources/lib/form/expandableTextbox.jelly @@ -6,11 +6,11 @@ TODO: support @checkUrl --> - + - + diff --git a/core/src/main/resources/lib/form/textarea.jelly b/core/src/main/resources/lib/form/textarea.jelly new file mode 100644 index 0000000000..b02c43224f --- /dev/null +++ b/core/src/main/resources/lib/form/textarea.jelly @@ -0,0 +1,15 @@ + + + + +
+ \ No newline at end of file