OpenSource/jenkins
1
0 Fork 0
mirror of https://github.com/jenkinsci/jenkins.git synced 2026-11-13 20:12:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing @Override annotations (#5430)

Browse Source
This commit is contained in:
Basil Crow authored and GitHub committed 2021-04-28 17:28:25 +08:00
1 parent 8577d3f8d5
commit f6378676b1
405 files changed
+1377 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

core/src/main/java/hudson/PluginManager.java
+14
View File
@@ -412,18 +412,21 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
{
Handle loadBundledPlugins = add("Loading bundled plugins", new Executable() {
@Override
public void run(Reactor session) throws Exception {
bundledPlugins = loadBundledPlugins();
}
});
Handle listUpPlugins = requires(loadBundledPlugins).add("Listing up plugins", new Executable() {
@Override
public void run(Reactor session) throws Exception {
archives = initStrategy.listPluginArchives(PluginManager.this);
}
});
requires(listUpPlugins).attains(PLUGINS_LISTED).add("Preparing plugins",new Executable() {
@Override
public void run(Reactor session) throws Exception {
// once we've listed plugins, we can fill in the reactor with plugin-specific initialization tasks
TaskGraphBuilder g = new TaskGraphBuilder();
@@ -432,6 +435,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
for( final File arc : archives ) {
g.followedBy().notFatal().attains(PLUGINS_LISTED).add("Inspecting plugin " + arc, new Executable() {
@Override
public void run(Reactor session1) throws Exception {
try {
PluginWrapper p = strategy.createPluginWrapper(arc);
@@ -466,6 +470,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
/**
* Makes sure there's no cycle in dependencies.
*/
@Override
public void run(Reactor reactor) throws Exception {
try {
CyclicGraphDetector<PluginWrapper> cgd = new CyclicGraphDetector<PluginWrapper>() {
@@ -538,6 +543,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
/**
* Once the plugins are listed, schedule their initialization.
*/
@Override
public void run(Reactor session) throws Exception {
Jenkins.get().lookup.set(PluginInstanceStore.class, new PluginInstanceStore());
TaskGraphBuilder g = new TaskGraphBuilder();
@@ -545,6 +551,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
// schedule execution of loading plugins
for (final PluginWrapper p : activePlugins.toArray(new PluginWrapper[0])) {
g.followedBy().notFatal().attains(PLUGINS_PREPARED).add(String.format("Loading plugin %s v%s (%s)", p.getLongName(), p.getVersion(), p.getShortName()), new Executable() {
@Override
public void run(Reactor session) throws Exception {
try {
p.resolvePluginDependencies();
@@ -567,6 +574,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
// schedule execution of initializing plugins
for (final PluginWrapper p : activePlugins.toArray(new PluginWrapper[0])) {
g.followedBy().notFatal().attains(PLUGINS_STARTED).add("Initializing plugin " + p.getShortName(), new Executable() {
@Override
public void run(Reactor session) throws Exception {
if (!activePlugins.contains(p)) {
return;
@@ -584,6 +592,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
}
g.followedBy().attains(PLUGINS_STARTED).add("Discovering plugin initialization tasks", new Executable() {
@Override
public void run(Reactor reactor) throws Exception {
// rescan to find plugin-contributed @Initializer
reactor.addAll(initializerFinder.discoverTasks(reactor));
@@ -1288,10 +1297,12 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
return Collections.unmodifiableList(result);
}
@Override
public String getDisplayName() {
return Messages.PluginManager_DisplayName();
}
@Override
public String getSearchUrl() {
return "pluginManager";
}
@@ -2276,6 +2287,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
private transient volatile List<PluginWrapper> pluginsWithCycle;
@Override
public boolean isActivated() {
if(pluginsWithCycle == null){
pluginsWithCycle = new ArrayList<>();
@@ -2327,6 +2339,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
}
}
@Override
public boolean isActivated() {
return !pluginsToBeUpdated.isEmpty();
}
@@ -2375,6 +2388,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
return Messages.PluginManager_PluginDeprecationMonitor_DisplayName();
}
@Override
public boolean isActivated() {
return !getDeprecatedPlugins().isEmpty();
}