From f73f679c411fea9d5ce5c62cb37702291d87afc4 Mon Sep 17 00:00:00 2001 From: kohsuke Date: Sat, 23 Jan 2010 00:58:32 +0000 Subject: [PATCH] fixed NPE: java.lang.NullPointerException at hudson.ProxyConfiguration.open(ProxyConfiguration.java:112) at hudson.FilePath.installIfNecessaryFrom(FilePath.java:532) at hudson.plugins.hadoop.PluginImpl.createHadoopVM(PluginImpl.java:109) at hudson.plugins.hadoop.SlaveStartTask.call(SlaveStartTask.java:58) at hudson.plugins.hadoop.SlaveStartTask.call(SlaveStartTask.java:41) at hudson.remoting.UserRequest.perform(UserRequest.java:104) at hudson.remoting.UserRequest.perform(UserRequest.java:48) at hudson.remoting.Request$2.run(Request.java:270) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303) at java.util.concurrent.FutureTask.run(FutureTask.java:138) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26276 71c3de6d-444a-0410-be80-ed276b4c234a --- core/src/main/java/hudson/ProxyConfiguration.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/ProxyConfiguration.java b/core/src/main/java/hudson/ProxyConfiguration.java index ea5671f5db..0752f8046d 100644 --- a/core/src/main/java/hudson/ProxyConfiguration.java +++ b/core/src/main/java/hudson/ProxyConfiguration.java @@ -109,7 +109,8 @@ public final class ProxyConfiguration implements Saveable { * This method should be used wherever {@link URL#openConnection()} to internet URLs is invoked directly. */ public static URLConnection open(URL url) throws IOException { - ProxyConfiguration p = Hudson.getInstance().proxy; + Hudson h = Hudson.getInstance(); // this code might run on slaves + ProxyConfiguration p = h!=null ? h.proxy : null; if(p==null) return url.openConnection();