removed the Computer parameter as requested by lifeless.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@20946 71c3de6d-444a-0410-be80-ed276b4c234a
This commit is contained in:
kohsuke committed 2009-08-20 00:30:01 +00:00
1 parent 8b3b5f76d1
commit f9cf329ec8
3 files changed
+7 -18

No files matched your search

@@ -24,7 +24,6 @@
package hudson.model;
import hudson.remoting.VirtualChannel;
import hudson.tasks.LabelFinder;
import java.util.HashSet;
import java.util.Set;
@@ -70,7 +69,7 @@ public final class DynamicLabels {
Set<Label> r = new HashSet<Label>();
for (LabelFinder labeler : LabelFinder.all())
for (String label : labeler.findLabels(c.getNode(),c))
for (String label : labeler.findLabels(c.getNode()))
r.add(Hudson.getInstance().getLabel(label));
return r;
}
@@ -23,19 +23,12 @@
*/
package hudson.tasks;
import hudson.ExtensionListView;
import hudson.ExtensionPoint;
import hudson.ExtensionList;
import hudson.UDPBroadcastFragment;
import hudson.Extension;
import hudson.model.Label;
import hudson.model.Node;
import hudson.model.Computer;
import hudson.ExtensionList;
import hudson.ExtensionPoint;
import hudson.model.Hudson;
import hudson.remoting.VirtualChannel;
import hudson.model.Node;
import java.util.List;
import java.util.Set;
import java.util.Collection;
/**
@@ -62,10 +55,8 @@ public abstract class LabelFinder implements ExtensionPoint {
*
* @param node
* The node that receives labels. Never null.
* @param c
* Computer that corresponds to the given node. This parameter is passed in for your convenience. Never null.
* @return
* A set of labels to be added dynamically to the node. Can be empty but never null.
*/
public abstract Collection<String> findLabels(Node node, Computer c);
public abstract Collection<String> findLabels(Node node);
}
@@ -25,7 +25,6 @@ package hudson.tasks.labelers;
import hudson.remoting.Callable;
import hudson.tasks.LabelFinder;
import hudson.model.Computer;
import hudson.model.Node;
import java.util.Collections;
@@ -42,9 +41,9 @@ import java.util.Set;
*/
// @Extension --- not live yet
public class OSLabeler extends LabelFinder {
public Set<String> findLabels(Node node, Computer computer) {
public Set<String> findLabels(Node node) {
try {
return computer.getChannel().call(new OSLabelFinder());
return node.getChannel().call(new OSLabelFinder());
} catch (Exception e) {
return Collections.emptySet();
}