Commit Graph
262 Commits
Author SHA1 Message Date
Alceu Rodrigues de Freitas Junior 9a45d8a35c Add missing Brazilian Portuguese translations (#6361) 2022-03-12 10:05:07 -08:00
Basil Crow 46603461e0 Ignore Checkstyle 10.0 and later (#6318) 2022-03-01 20:26:39 +00:00
Alceu Rodrigues de Freitas Junior 4d8be4795b Remove unused Brazilian Portuguese localizations (#6309) 2022-02-26 07:10:24 -08:00
Basil Crow 520e114ea1 Use explicit character set in tests (#6150) 2022-01-07 06:29:39 -08:00
Basil Crow e27b310065 Enable whitespace-related Checkstyle checks (#6149) 2022-01-03 08:55:03 -08:00
Basil Crow 02eecd8a49 Consistent indentation with spaces rather than tabs (#6147) 2022-01-01 11:45:56 -08:00
Basil Crow b25b45bc90 Remove trailing whitespace (#6138) 2021-12-31 07:54:03 -08:00
Basil Crow 8a5e309256 Fix DM_DEFAULT_ENCODING SpotBugs violations (#6050) 2021-12-22 20:33:59 -08:00
Basil Crow 33859a2316 Bump MINA SSHD from 2.7.0 to 2.8.0 (#6017) 2021-12-07 20:14:52 +00:00
Basil Crow d5cea69751 Prevent new SpotBugs violations from being introduced (#6015) 2021-12-06 13:52:38 -08:00
Basil Crow 74c73dd4ce Enable MissingSwitchDefault Checkstyle check (#5966) 2021-11-30 12:50:24 +00:00
dependabot[bot] e01f29ffca Bump jenkins from 1.65 to 1.67 (#5740) 2021-09-20 12:54:35 +00:00
Taehong Kim 8e942a831c Remove redundant 'continue' from conditional branches (#5717) 2021-09-20 09:44:00 +01:00
Basil Crow 632033d6ad Sort imports (#5732) 2021-09-18 09:39:42 +01:00
Basil Crow bd7c823c27 Remove unnecessary parentheses (#5576) 2021-06-25 09:23:37 +01:00
Basil CrowandDaniel Beck b8c20c6428 Fix violations of a handful of Error Prone checks (#5519)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2021-06-14 16:45:34 +01:00
Daniel BeckandDaniel Beck ca646b3742 Add www to jenkins.io URLs (#5517)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2021-05-25 20:56:16 +01:00
Basil Crow 56216ba477 Ensure files end with a newline with Spotless rather than Checkstyle 2021-05-07 19:56:27 -07:00
Jesse Glick 82f3bfd74d [JENKINS-64294] Buffer stdin for jenkins-cli.jar 2021-04-30 14:53:27 -04:00
Basil Crow 95e85495ca Enable AvoidStarImport Checkstyle check (#5420) 2021-04-28 17:28:39 +08:00
Basil Crow f6378676b1 Add missing @Override annotations (#5430) 2021-04-28 17:28:25 +08:00
Elvys Soares 5b8392b8f6 Including expected values and passed parameters to test names generation.
Signed-off-by: Elvys Soares <eas5@cin.ufpe.br>
2021-03-26 18:46:05 -03:00
Elvys Soares 7651079c4e Refactored multiple assertion tests into parameterized ones
Signed-off-by: Elvys Soares <eas5@cin.ufpe.br>
2021-03-25 11:54:47 -03:00
res0nance 9dc1c9aa12 Remove unused import 2021-03-12 19:25:01 +08:00
Oleg Nenashev 20c01e9005 Merge pull request #5206 from res0nance/bump-sshd-core
Bump sshd-core to 2.6.0 and update tests
2021-03-12 11:59:23 +01:00
Basil Crow 881365d30b Enable RedundantModifier Checkstyle check 2021-03-08 07:56:42 -08:00
Basil Crow 44c5342c58 Declare modifiers in JLS order (#5339) 2021-03-08 07:58:59 +00:00
Basil Crow bd1d5e09bd Add missing @Override annotations 2021-03-02 14:04:48 -08:00
res0nance 4d818c294f Bump sshd-core to 2.6.0 and update tests 2021-01-25 18:00:03 +08:00
dependabot[bot]andRaihaan Shouhell 7a5d49594c Bump tyrus-standalone-client-jdk from 1.12 to 2.0.0 (#5128)
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Raihaan Shouhell <raihaanhimself@gmail.com>
2020-12-20 13:37:47 +00:00
StefanSpiekerandOleg Nenashev 463cd113ba Minor refactorings either for performance or readability (#4845)
Co-authored-by: Oleg Nenashev <o.v.nenashev@gmail.com>
2020-07-17 15:14:46 +01:00
Alessandro Menti b847608ed3 i18n: update the Italian translation 2020-06-29 20:57:12 +02:00
Oleg Nenashev e09f1cd028 Merge pull request #4762 from StefanSpieker/cli_tests
moved test class closer to class and added a test
2020-06-05 23:50:01 +02:00
Stefan Spieker 9da5af317f removed accidently added import 2020-05-31 11:48:10 +02:00
Stefan Spieker ce4cc695bf moved test class closer to class and added a test 2020-05-31 11:06:13 +02:00
Søren A D 90f3047483 Support for bearer tokens in jenkins-cli (#4673)
* added -bearer argument to jenkins-cli

* updated message related to bearer/auth. added warning when both are used anyway.
2020-05-24 17:13:23 +02:00
Stefan Spieker ca167e9c43 minor pom cleanup and switched assertions to junit5 because class was already switched to junit5 2020-04-27 10:43:00 +02:00
Jeff Thompson ce4bc37a0d Remove suppression that were inadvertently merged back in. 2020-01-23 15:04:58 -07:00
Jeff Thompson 348a26f77e Narrow the suppression.
And add TODO connected with JENKINS tickets for relevant issues.
2020-01-23 14:59:51 -07:00
Jeff Thompson ced25e51fd Make sure everything has a justification.
And move a couple of items to the exclude file. If we ever get to a lower threshold, these will show up all over the place.
2020-01-23 14:55:59 -07:00
Jeff Thompson c76ee59810 Add findsecbugs plugin to spotbugs.
And suppress existing warnings. We should clean some of them up, but that's for different PRs.
2020-01-23 14:53:53 -07:00
Jesse Glick 5b5040298f [JEP-222] WebSocket support (#4369)
* Playing with WebSocket connections.

* Pluggable handlers.

* errorWithoutStack

* Server-side keepalive pings.

* Redesigned to work as an HttpResponse.

* Unused dep.

* Comment on JnlpSlaveRestarterInstaller.

* Sketch of WebSocket-based endpoint for JNLPLauncher.

* Comment.

* Test enhancement.

* Making it more obvious from JNLPLauncherTest where remoting.jar is being loaded from.

* Reworked protocol to negotiate remote capabilities.

* Unhelpful comment.

* Simplifying handshake to use HTTP headers.

* Moving code into top-level classes and otherwise prettifying.

* Linking to upstream PRs.

* Timestamped snapshot + incremental.

* Picking up incrementalified build of winstone.

* Working around https://github.com/kohsuke/access-modifier/pull/17.

* Finally have an incrementalified build of remoting.

* Use -webSocket option.

* Handling some close and error methods.

* Sending X-Remoting-Minimum-Version.

* If hudson.remoting.jnlp.Main._main fails, show the error.

* Comment.

* GUI analogue of https://github.com/jenkinsci/remoting/pull/357/commits/86cea5b83fd2fc93a9fc10896962eb42c95f80a0.

* Missing since tags.

* Capitalization.

* WebSockets.isSupported

* Rather than hiding JNLPLauncher.DescriptorImpl when the TCP port is disabled, always display it, but show form validation appropriate to WebSocket or TCP mode.

* Form validation fixes.

* Minor test improvements.

* Reworked WebSocketAgents to be compatible with JnlpAgentReceiver.

* Removing WebSocketSession.keepAlive in favor of a global setting applicable to all services.

* Add a -webSocket option to the Jenkins CLI.

* Using a snapshot deployment of Remoting, pending INFRA-2379.

* After #3838 there is no reason to recheck authentication after parsing CLICommand arguments.

* Advertise the -webSocket option.

* Adapt to newer HtmlUnit.

* https://github.com/HtmlUnit/htmlunit/pull/29 seems to have been incompatible.
WebClient.addRequestHeader will no longer override a header in a WebRequest,
such as when the same WebClient/WebRequest was previously used with different headers.

* Tracked down a behavioral change in passing through URL-encoded path characters.
https://github.com/HtmlUnit/htmlunit/commit/2c4956863420e4baef9d3d8c23ec0577ec64d2bf picks up
https://github.com/apache/httpcomponents-client/commit/8c04c6ae5e5ba1432e40684428338ce68431766b which is the actual change.

* Disabled TCP port does not matter in WebSocket mode.

* Shade dependencies needed for jenkins-cli.jar.

* Help text edit.

* https://github.com/jenkinsci/winstone/pull/79 was released as 5.5.

* https://github.com/jenkinsci/jenkins-test-harness/pull/183 released as 2.59.

* https://github.com/jenkinsci/jenkins/pull/4387#discussion_r362696234

* Bumping remoting to a new deployed snapshot.

* Need https://github.com/jenkinsci/winstone/pull/86.

* https://github.com/jenkinsci/winstone/pull/86 released as 5.6.

* Introduced constant for X-Remoting-Minimum-Version.

* s/slave/agent/ in GUI

* Removing in-JVM test, as it was no longer useful after introducing shading anyway.

* Bump.

* No need to check for anonymous CONNECT here.

* s/jenkins.slaves/jenkins.agents/g for new code.

* Restrict the diagnostic endpoint to administrators.

* Fixed Javadoc import after package move.

* https://github.com/jenkinsci/remoting/pull/357 released as 4.0.
2020-01-21 07:00:39 +01:00
René Scheibe 7a3699d3f4 Fix issues in properties files
- trailing spaces ` ` after backslash `\` for multi-line entries
- missing backslash `\` for multi-line entries
- missing escaping of the key/value separator colon `:` when used literally
- missing key/value separator `=`
- duplicate entries
- extra content without a key
2020-01-06 21:34:43 +01:00
Jesse Glick 8c81991ec0 Race condition in PlainCLIProtocolTest. 2019-11-26 09:03:58 -05:00
StefanSpieker 5057edae53 introduced junit5 as testing backend for cli tests (#4220) 2019-11-18 11:18:22 +01:00
Jesse Glick 642a4ff0f3 jenkins-cli.jar no longer needs to bundle remoting. 2019-11-08 17:28:37 -05:00
Oleg Nenashev 41a13dffc6 Merge pull request #4308 from basil/javadoc
Javadoc cleanup
2019-11-01 01:30:33 +03:00
Mustafa Ulu 84d9076e32 Localization files should end with line feed
Translation tool can append new keys to end of existing files. If a properties file does not end with line feed than the first new key will be appended to the last line of that file.

For example a line like "key=value" will become "key=valueappendedKey=appendedValue"
2019-10-26 14:14:04 +03:00
Basil Crow 20786f087b Fix dangling Javadocs 2019-10-19 14:02:59 -07:00
Oleg Nenashev abf4695421 Merge pull request #4263 from daniel-beck/JENKINS-59267
[JENKINS-59267] Increase ping frequency to prevent timeouts, and make it configurable
2019-10-06 11:31:31 +02:00