Commit Graph
248 Commits
Author SHA1 Message Date
kohsuke d737193cca Make FastInput/OutputStream pair capable of detecting when the other end has abandoned their side, which prevents infinite pipe clogging.
This is discovered on one of the Hudson instances that showed the following stack trace:

java.lang.Object.wait(Native Method)
java.lang.Object.wait(Object.java:474)
hudson.remoting.FastPipedOutputStream.write(FastPipedOutputStream.java:136)
hudson.remoting.FastPipedOutputStream.write(FastPipedOutputStream.java:115)
hudson.remoting.ProxyOutputStream$Chunk.execute(ProxyOutputStream.java:164)
hudson.remoting.Channel$ReaderThread.run(Channel.java:863)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28491 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-10 17:32:25 +00:00
kohsuke c6acb5b8d5 [FIXED HUDSON-2137]
Merged revisions 27137,27564,27566-27567,27578,27586,27599,27603,27606-27609,27611,27616,27626-27632,27640,27654-27656,27687,27701,27801,27816,27819,27843-27845,28087,28158-28161 via svnmerge from 
https://www.dev.java.net/svn/hudson/branches/HUDSON-2137

........
  r27137 | kohsuke | 2010-02-08 08:46:16 -0800 (Mon, 08 Feb 2010) | 1 line
  
  experimenting with abstractions
........
  r27564 | kohsuke | 2010-02-16 07:58:26 -0800 (Tue, 16 Feb 2010) | 1 line
  
  bundling makes it easier for caller to handle ConsoleAnnotator
........
  r27566 | kohsuke | 2010-02-16 08:49:48 -0800 (Tue, 16 Feb 2010) | 1 line
  
  this should work with Runs, not AbstractBuilds
........
  r27567 | kohsuke | 2010-02-16 08:54:06 -0800 (Tue, 16 Feb 2010) | 1 line
  
  simplified
........
  r27578 | kohsuke | 2010-02-16 12:26:11 -0800 (Tue, 16 Feb 2010) | 1 line
  
  still a work in progress, but committing once to pull in trunk changes
........
  r27586 | kohsuke | 2010-02-16 14:35:37 -0800 (Tue, 16 Feb 2010) | 1 line
  
  making more progress
........
  r27599 | kohsuke | 2010-02-16 19:22:01 -0800 (Tue, 16 Feb 2010) | 2 lines
  
  hooking up the side that writes annotations.
  still a work in progress.
........
  r27603 | kohsuke | 2010-02-16 23:43:35 -0800 (Tue, 16 Feb 2010) | 3 lines
  
  what appears to me as the first cut of hooking up the reader side of the annotations.
  
  I haven't even run it yet --- this just passed the compilation, and I'm calling it a day.
........
  r27606 | kohsuke | 2010-02-17 09:15:16 -0800 (Wed, 17 Feb 2010) | 1 line
  
  demo instance hook up
........
  r27607 | kohsuke | 2010-02-17 11:27:02 -0800 (Wed, 17 Feb 2010) | 3 lines
  
  one more utility method.
  
  I never understood what the point of letting the skip method skip less.
........
  r27608 | kohsuke | 2010-02-17 11:56:23 -0800 (Wed, 17 Feb 2010) | 3 lines
  
  - moved LargeText subtype to its own class
  - skipping log output was done incorrectly --- it had to skip N bytes where it was skipping N chars.
  - hooked up console annotations for completed builds.
........
  r27609 | kohsuke | 2010-02-17 12:01:46 -0800 (Wed, 17 Feb 2010) | 1 line
  
  copyright header
........
  r27611 | kohsuke | 2010-02-17 13:18:10 -0800 (Wed, 17 Feb 2010) | 1 line
  
  introduced a mechanism to register extension during an unit test.
........
  r27616 | kohsuke | 2010-02-17 13:38:12 -0800 (Wed, 17 Feb 2010) | 1 line
  
  test case for console annotations
........
  r27626 | kohsuke | 2010-02-17 15:23:06 -0800 (Wed, 17 Feb 2010) | 1 line
  
  removing test ConsoleAnnotator as I write tests as tests
........
  r27627 | kohsuke | 2010-02-17 16:06:13 -0800 (Wed, 17 Feb 2010) | 1 line
  
  added a multi-phase cooperative locking mechanism useful during the debugging
........
  r27628 | kohsuke | 2010-02-17 16:06:41 -0800 (Wed, 17 Feb 2010) | 1 line
  
  testing progressive log annotation
........
  r27629 | kohsuke | 2010-02-17 16:20:32 -0800 (Wed, 17 Feb 2010) | 1 line
  
  adding a test for ConsoleAnnotation that's explicitly placed.
........
  r27630 | kohsuke | 2010-02-17 16:23:02 -0800 (Wed, 17 Feb 2010) | 1 line
  
  removing test ConsoleAnnotation as I write tests as tests
........
  r27631 | kohsuke | 2010-02-17 16:28:50 -0800 (Wed, 17 Feb 2010) | 1 line
  
  tweaking the abstraction a bit.
........
  r27632 | kohsuke | 2010-02-17 16:44:21 -0800 (Wed, 17 Feb 2010) | 1 line
  
  parameterized the context type so that this can be used in places other than the build console output, such as polling logs, slave logs, and so on.
........
  r27640 | kohsuke | 2010-02-17 17:27:52 -0800 (Wed, 17 Feb 2010) | 1 line
  
  bug fix
........
  r27654 | kohsuke | 2010-02-17 22:53:04 -0800 (Wed, 17 Feb 2010) | 1 line
  
  doc improvement
........
  r27655 | kohsuke | 2010-02-17 22:53:59 -0800 (Wed, 17 Feb 2010) | 1 line
  
  doc improvement
........
  r27656 | kohsuke | 2010-02-17 23:10:42 -0800 (Wed, 17 Feb 2010) | 1 line
  
  test case for adjacent tags
........
  r27687 | kohsuke | 2010-02-19 14:39:21 -0800 (Fri, 19 Feb 2010) | 1 line
  
  introduced a facotry and descriptor. This allows them to define configuration pages, allow users to disable/enable them, plus define custom behaviors.
........
  r27701 | kohsuke | 2010-02-19 18:23:52 -0800 (Fri, 19 Feb 2010) | 1 line
  
  defining a mechanism for ConsoleAnnotatorFactory and ConsoleAnnotationDescriptor to define script.js and have them imported into the console output page
........
  r27801 | kohsuke | 2010-02-22 11:59:16 -0800 (Mon, 22 Feb 2010) | 1 line
  
  now embedding annotations inside the console output log file.
........
  r27816 | kohsuke | 2010-02-22 15:45:04 -0800 (Mon, 22 Feb 2010) | 1 line
  
  introduced a convenience method for unit tests
........
  r27819 | kohsuke | 2010-02-22 17:37:05 -0800 (Mon, 22 Feb 2010) | 5 lines
  
  As an example of using embedded console annotations, implementing Ant target invocation outlines.
  
  It might be better to make the concept of outline more generally reusable, so that different kinds of outlines can be placed into the same container element for a single hierarchical representation.
  
  Still a work in progress.
........
  r27843 | kohsuke | 2010-02-23 16:12:13 -0800 (Tue, 23 Feb 2010) | 1 line
  
  for now, disable this for production usage, until I work out a better UI.
........
  r27844 | kohsuke | 2010-02-23 19:08:00 -0800 (Tue, 23 Feb 2010) | 1 line
  
  started working on annotating exception.
........
  r27845 | kohsuke | 2010-02-23 19:08:33 -0800 (Tue, 23 Feb 2010) | 1 line
  
  more TODOs for myself
........
  r28087 | kohsuke | 2010-03-01 10:03:55 -0800 (Mon, 01 Mar 2010) | 1 line
  
  formatting changes
........
  r28158 | kohsuke | 2010-03-02 17:00:00 -0800 (Tue, 02 Mar 2010) | 1 line
  
  ConsoleAnnotation and ConsoleAnnotator are too confusing.
........
  r28159 | kohsuke | 2010-03-02 17:02:02 -0800 (Tue, 02 Mar 2010) | 1 line
  
  doc improvement
........
  r28160 | kohsuke | 2010-03-02 17:05:14 -0800 (Tue, 02 Mar 2010) | 1 line
  
  more doc improvements.
........
  r28161 | kohsuke | 2010-03-02 17:11:59 -0800 (Tue, 02 Mar 2010) | 1 line
  
  more doc improvement
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28173 71c3de6d-444a-0410-be80-ed276b4c234a
2010-03-03 15:37:55 +00:00
kohsuke cba6fe5ad0 there was a confusion between the bootstrap classloader (that loads rt.jar and endorsed libs) and the app classloader (that loads classes specified in the -cp.)
The intent of this mechanism is to control the implications of sending rt.jar classes and endorsed dirs --- since every VM gets its own logically complete copy of the bootstrap classes, under the normal circumstances we shouldn't have to transfer them. But if the endorsed dir is used and you want all slaves to pick them up, disabling this check is handy, and hence the addition by Tom.

In contrast, app classes are specified differently per VM, so we need to be able to transfer those files. This bug shows up as test failures in plugins, where Hudson is loaded (along with JUnit and plugins) in the app classloader.

I guess this problem didn't manifest in the releases, because whether Hudson is deployed as a war or run as java -jar hudson.war, app classloader doesn't load Hudson.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@27481 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-14 17:35:02 +00:00
kohsuke 7bfbd4201c noting the meaning of the switch
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26999 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-04 02:02:15 +00:00
kohsuke 2f50f49517 Merge commit 'huybrechts/lib-endorsed'
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26998 71c3de6d-444a-0410-be80-ed276b4c234a
2010-02-04 01:46:14 +00:00
Tom Huybrechts e1ab16ce57 RemoteClassLoader.useSystemClassLoader property controls how the system classloader is treated:
- if true, both resources and classes from the server system classloader will be usable on slaves
- if false (default), neither resources or classes will be loadable from a slave
2010-01-29 13:39:08 +01:00
Tom Huybrechts adf2d268f0 load remote classes from system classloader 2010-01-29 12:31:37 +01:00
kohsuke 1b3c1f92fd [HUDSON-5391] Fixed the infamous Turkish bug.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26650 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-28 21:38:01 +00:00
kohsuke 693b60ba6f [FIXED HUDSON-5313 HUDSON-5314] Applied a patch in 5314 to fix 5313.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26274 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-23 00:38:36 +00:00
kohsuke 75035791d9 exposing these to allow plugins and clients to diagnose less-capable channel graecfully.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26113 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-19 23:42:57 +00:00
kohsuke 1c9e5a4cc3 improved error message
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26107 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-19 23:03:05 +00:00
lacostej 31656e4799 Properly register temporary directories for deletion.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24656 71c3de6d-444a-0410-be80-ed276b4c234a
2009-12-16 17:25:43 +00:00
kohsuke c154d431f0 [HUDSON-5048] Fixed the multi-classloader support in the remoting code. I confirmed that this fixes HUDSON-4993 without modifying the warnings/analysis-core plugin.
I'm letting Hudson run the whole test suite to see if there's any regression caused by this.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24490 71c3de6d-444a-0410-be80-ed276b4c234a
2009-12-09 01:45:57 +00:00
mindless c078a6c855 Improve display of cause of slaves being offline.
- Removed "failed to launch" message from ComputerLauncher/main.jelly
  This message was always shown, even if slave was offline for other reasons.
- Instead, added new OfflineCause.LaunchFailed which is set in SlaveComputer if channel
  is not set after calling launcher.  Now this shows the "failed to launch" message.
- Moved/copied existing translations for these strings to their new locations.
- Expanded message for in-demand strategy to say "will be relaunched when needed"
- Added text explanation and fixed display of exception for ChannelTermination cause
- Use class="warning" for default display of OfflineCause
- Added some @Override annotations


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23876 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-19 23:55:43 +00:00
mindless 4039345b0e [HUDSON-4066] Add version# is slave.jar and report this in log when a node is launched.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23750 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-16 05:21:31 +00:00
kohsuke bd50c5aa58 Merged revisions 23696 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23696 | kohsuke | 2009-11-12 18:56:25 -0800 (Thu, 12 Nov 2009) | 1 line
  
  JDK 6 dependency crept in
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23697 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 02:57:22 +00:00
kohsuke d4ad980691 Merged revisions 23689-23691 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23689 | kohsuke | 2009-11-12 15:35:27 -0800 (Thu, 12 Nov 2009) | 1 line
  
  improved diagnosability
........
  r23690 | kohsuke | 2009-11-12 18:03:42 -0800 (Thu, 12 Nov 2009) | 1 line
  
  adding a probe to diagnose a sporadic test failure
........
  r23691 | kohsuke | 2009-11-12 18:14:21 -0800 (Thu, 12 Nov 2009) | 1 line
  
  I think this is causing a test failure in ExtendedReadPermissionTest, as the existing alice/bob/charlie users prevent the data on the disk from loading.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23692 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 02:18:09 +00:00
kohsuke f8e2a28eb0 Seeing dead lock after the message:
Nov 9, 2009 1:46:11 PM hudson.remoting.Channel$ReaderThread run
SEVERE: I/O error in channel This side of the channel
java.io.IOException: Write end dead
	at java.io.PipedInputStream.read(PipedInputStream.java:294)
	at java.io.ObjectInputStream$PeekInputStream.peek(ObjectInputStream.java:2249)
	at java.io.ObjectInputStream$BlockDataInputStream.peek(ObjectInputStream.java:2542)
	at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2552)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1297)
	at java.io.ObjectInputStream.readObject(ObjectInputStream.java:351)
	at hudson.remoting.Channel$ReaderThread.run(Channel.java:849)
Nov 9, 2009 1:46:11 PM hudson.remoting.Request$2 run
SEVERE: Failed to send back a reply
java.io.IOException: Read end dead
	at java.io.PipedInputStream.checkStateForReceive(PipedInputStream.java:246)
	at java.io.PipedInputStream.receive(PipedInputStream.java:210)
	at java.io.PipedOutputStream.write(PipedOutputStream.java:132)
	at java.io.ObjectOutputStream$BlockDataOutputStream.drain(ObjectOutputStream.java:1838)
	at java.io.ObjectOutputStream$BlockDataOutputStream.setBlockDataMode(ObjectOutputStream.java:1747)
	at java.io.ObjectOutputStream.writeNonProxyDesc(ObjectOutputStream.java:1249)
	at java.io.ObjectOutputStream.writeClassDesc(ObjectOutputStream.java:1203)
	at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1387)
	at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1150)
	at java.io.ObjectOutputStream.writeFatalException(ObjectOutputStream.java:1538)
	at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:329)
	at hudson.remoting.Channel.send(Channel.java:413)
	at hudson.remoting.Request$2.run(Request.java:282)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)



The thread dump indicates that the test thread is stuck at british.join(), because British channel reader thread is still alive. I remember PipedInput|OutputStream being not truly multi-thread aware, so changing it to our own version to see if that fixes the problem without my digging further.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23625 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 23:43:20 +00:00
kohsuke b22bfeaaf1 added logging
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23621 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-09 23:28:08 +00:00
kohsuke 50fca25229 it should be volatile, I think
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23531 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 19:56:58 +00:00
jglick 6ccad2bc32 [FIXED HUDSON-4611] hudson.proc.RemoteProc.kill() was a no-op.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23526 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 18:34:11 +00:00
kohsuke b2c6ece47a Fixed a race condition in interrupting pending remote calls.
Deadlocked threads from Tom Huybrechts
----
"Channel reader thread: build-tr-01" Id=6188858 BLOCKED on hudson.remoting.UserRequest@7641246a owned by "Executor #1 for build-tr-01 : executing ORBIS_HAP_Core-Java5 #213 / waiting for hudson.remoting.Channel@560c2a29:build-tr-01" Id=379
	at hudson.remoting.Request.onCompleted(Request.java:223)
	-  blocked on hudson.remoting.UserRequest@7641246a
	at hudson.remoting.Request.abort(Request.java:231)
	at hudson.remoting.Channel.terminate(Channel.java:596)
	-  locked java.util.Hashtable@49c47d9e
	-  locked hudson.remoting.Channel@560c2a29
	at hudson.remoting.Channel$ReaderThread.run(Channel.java:871)
Executor #1 for build-tr-01 : executing ORBIS_HAP_Core-Java5 #213 / waiting for hudson.remoting.Channel@560c2a29:build-tr-01" Id=379 BLOCKED on hudson.remoting.Channel@560c2a29 owned by "Channel reader thread: build-tr-01" Id=6188858
	at hudson.remoting.Channel.send(Channel.java:409)
	-  blocked on hudson.remoting.Channel@560c2a29
	at hudson.remoting.Request.call(Request.java:127)
	-  locked hudson.remoting.UserRequest@7641246a
	at hudson.remoting.Channel.call(Channel.java:549)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23476 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-04 20:22:02 +00:00
kohsuke fe6bae7457 as soon as the reader thread starts, we might start seeing requests. So the capability needs to be set earlier.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23275 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-28 15:50:11 +00:00
kohsuke 25c3bcbf29 [FIXED HUDSON-4071] Applied the change toward 1.331.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23113 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-23 21:13:03 +00:00
kohsuke 84f03aa2f0 [FIXED HUDSON-4657] in .1330.
RemoteClassLoader does not persist retrieved classes with package structure
    (<a href="https://hudson.dev.java.net/issues/show_bug.cgi?id=4657">issue 4657</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22994 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-21 17:55:36 +00:00
kohsuke dea611ebf6 fixing a test failure on Unix
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22316 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-01 17:44:27 +00:00
kohsuke 62721e26b9 documenting this work around better
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22280 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-29 01:18:45 +00:00
kohsuke 6724baca19 confirming this work around.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22279 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-29 01:05:29 +00:00
kohsuke 2c4d2cd934 experimenting with the fix off.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22278 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-29 00:32:51 +00:00
kohsuke b5bd12de34 attempting to work around the hang problem on Windows.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22277 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-29 00:22:16 +00:00
kohsuke 2e44be3be4 getting close.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22275 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 22:26:34 +00:00
kohsuke eb7fa69a4c Windows results in NoClassDefFoundError on Launcher because of the format?
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22273 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 22:19:42 +00:00
kohsuke 0b97c13031 support removal of values.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22038 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-23 02:11:44 +00:00
kohsuke 3adada0046 [HUDSON-3889] JNLP clients now report the reason when the connection is rejected by the master.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22037 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-23 01:50:31 +00:00
kohsuke a9b49214aa this hook is the first step for a better detection of failed connections to slaves from the master.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22036 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-23 01:36:15 +00:00
kohsuke 8e048b8607 somehow these aren't compiling on my IntelliJ. ???
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21767 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-17 05:43:24 +00:00
kohsuke 57203e3d63 JNLP clients perform periodic ping to detect terminated connections and recover automatically.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21742 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 15:30:54 +00:00
kohsuke 97b0888ed1 disable Nagle's algorithm.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21741 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 15:21:13 +00:00
kohsuke f4d76ea928 avoid using deprecated methods.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21740 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-16 14:59:54 +00:00
kohsuke 4e5ca312b8 comment touch up
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21666 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 00:14:37 +00:00
kohsuke 77ef7e0184 A trouble-shooting on one of the production Hudson servers resulted in a thread infinitely hanging. Making the code defensive to avoid this problem.
"pool-10-thread-6 / waiting for hudson.remoting.Channel@39a5b0:winxpie7.sfbay.sun.com" Id=579896 WAITING on hudson.remoting.UserRequest@3b4670
	at java.lang.Object.wait(Native Method)
	-  waiting on hudson.remoting.UserRequest@3b4670
	at java.lang.Object.wait(Object.java:485)
	at hudson.remoting.Request.call(Request.java:116)
	at hudson.remoting.Channel.call(Channel.java:536)
	at hudson.slaves.SlaveComputer.setChannel(SlaveComputer.java:305)
	at hudson.plugins.sshslaves.SSHLauncher.startSlave(SSHLauncher.java:220)
	at hudson.plugins.sshslaves.SSHLauncher.launch(SSHLauncher.java:180)
	-  locked hudson.plugins.sshslaves.SSHLauncher@985bc4
	at hudson.slaves.SlaveComputer$1.call(SlaveComputer.java:175)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)

	Number of locked synchronizers = 1
	- java.util.concurrent.locks.ReentrantLock$NonfairSync@14f0686


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21665 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 00:14:21 +00:00
kohsuke 66bf21ba97 Merged revisions 21385-21386 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r21385 | kohsuke | 2009-09-02 15:41:39 -0700 (Wed, 02 Sep 2009) | 1 line
  
  Fixed a random test failure, which was caused by PingThread detecting communication problem while it's being orderly shut down.
........
  r21386 | kohsuke | 2009-09-02 15:41:57 -0700 (Wed, 02 Sep 2009) | 1 line
  
  indentation fix.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21387 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-02 23:06:15 +00:00
kohsuke 620e385751 Merged revisions 21368 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r21368 | kohsuke | 2009-09-02 13:14:25 -0700 (Wed, 02 Sep 2009) | 33 lines
  
  wait until the channel terminates normally to avoid random test failures like this:
  
  junit.framework.AssertionFailedError: exit code should have been 0 expected:<0> but was:<255>
  	at junit.framework.Assert.fail(Assert.java:47)
  	at junit.framework.Assert.failNotEquals(Assert.java:285)
  	at junit.framework.Assert.assertEquals(Assert.java:64)
  	at junit.framework.Assert.assertEquals(Assert.java:201)
  	at hudson.remoting.ChannelRunner$Fork.stop(ChannelRunner.java:141)
  	at hudson.remoting.RmiTestBase.tearDown(RmiTestBase.java:53)
  	at junit.framework.TestCase.runBare(TestCase.java:130)
  	at junit.framework.TestResult$1.protect(TestResult.java:106)
  	at junit.framework.TestResult.runProtected(TestResult.java:124)
  	at junit.framework.TestResult.run(TestResult.java:109)
  	at junit.framework.TestCase.run(TestCase.java:118)
  	at junit.framework.TestSuite.runTest(TestSuite.java:208)
  	at junit.framework.TestSuite.run(TestSuite.java:203)
  	at junit.framework.TestSuite.runTest(TestSuite.java:208)
  	at junit.framework.TestSuite.run(TestSuite.java:203)
  	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  	at java.lang.reflect.Method.invoke(Method.java:597)
  	at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
  	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:140)
  	at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:127)
  	at org.apache.maven.surefire.Surefire.run(Surefire.java:177)
  	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
  	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
  	at java.lang.reflect.Method.invoke(Method.java:597)
  	at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:345)
  	at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:1009)
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21371 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-02 20:30:06 +00:00
kohsuke d8667f54dd enabling back tests.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21357 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-02 17:00:51 +00:00
kohsuke b44df39a3a disabling the multi classloader support, since this is breaking things too much and we need more time before introducing this feature.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21356 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-02 17:00:09 +00:00
kohsuke b0c76f7b51 Newline in the header was a bad idea because it can be eaten away by BufferedReader.readLine(), plus it can be affected by transports between CR/LF conversions.
This should fix the test problem.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21327 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-01 21:53:00 +00:00
kohsuke 60bccc26eb code should be where it belongs to.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21133 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-27 21:20:39 +00:00
kohsuke f263d84940 Fixed a race condition that appear as test failures. This is caused by the remote peer sending us a request before we get to obtain the remote capacity.
I moved the capability exchange to the preamble negotiation to avoid this problem.

----
 java.lang.NullPointerException
	at hudson.remoting.UserRequest._serialize(UserRequest.java:136)
	at hudson.remoting.UserRequest.perform(UserRequest.java:118)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:236)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:619)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21132 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-27 21:19:15 +00:00
kohsuke cbb3e313ad Merged revisions 20928-20929,20939,20974-20975,20988,21009,21011,21015 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r20928 | kohsuke | 2009-08-19 14:47:13 -0700 (Wed, 19 Aug 2009) | 1 line
  
  test bug fix.
........
  r20929 | kohsuke | 2009-08-19 14:48:23 -0700 (Wed, 19 Aug 2009) | 1 line
  
  bumped up to a new version that has a trouble-shooting hook for resetting cached views
........
  r20939 | kohsuke | 2009-08-19 15:20:57 -0700 (Wed, 19 Aug 2009) | 1 line
  
  picking up subversion 1.5
........
  r20974 | kohsuke | 2009-08-20 11:50:04 -0700 (Thu, 20 Aug 2009) | 3 lines
  
      Hudson can make mistakes in binding plugins to their right /plugin/NAME/ URLs.
      (<a href="http://www.nabble.com/Custom-Plugin---No-external-resources-available-td25064554.html">report</a>)
........
  r20975 | kohsuke | 2009-08-20 12:05:11 -0700 (Thu, 20 Aug 2009) | 1 line
  
  Build history AJX update was buggy.
........
  r20988 | kohsuke | 2009-08-20 17:01:57 -0700 (Thu, 20 Aug 2009) | 3 lines
  
      Hudson wasn't working on WebLogic on Windows.
      (<a href="http://www.nabble.com/Re%3A-Hudson-on-Weblogic-10.3-td25038378.html#a25043415">report</a>)
........
  r21009 | kohsuke | 2009-08-21 14:21:35 -0700 (Fri, 21 Aug 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-
........
  r21011 | kohsuke | 2009-08-21 14:22:00 -0700 (Fri, 21 Aug 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r21015 | kohsuke | 2009-08-21 16:00:17 -0700 (Fri, 21 Aug 2009) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21095 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-26 15:13:55 +00:00
kohsuke 5768da22a2 Fixed a NoClassDefFoundError problem that happens in remoting+maven+3rd plugin combo.
<a href="http://www.nabble.com/NoClassDefFoundError%3A-hudson-maven-MavenBuildProxy%24BuildCallable-td24719002.html#a24719002">report</a>


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21002 71c3de6d-444a-0410-be80-ed276b4c234a
2009-08-21 18:13:30 +00:00