Commit Graph
17593 Commits
Author SHA1 Message Date
Baptiste Mathus 0c17e82e82 Merge pull request #3185 from mikecirioli/OSS-2590
[JENKINS-48463] Update jenkins core to use  XML v1.1
2018-02-04 11:31:53 +01:00
Sam Van Oort 2a6fc653ee Fix [JENKINS-49206] by ensuring Timer threads get standard classloader (#3272)
* Fix [JENKINS-49206] by ensuring Timer threads get standard classloader

* Refactor to better fit in with existing ThreadFactor utils

* Fix javadocs
2018-02-03 13:22:53 +01:00
Baptiste Mathus 6cefcf17a8 [JENKINS-48407] Re-enable AtomicFileWriterTest#checkPermissionsRespectUmask() (#3275)
* [JENKINS-48407] Re-enable test

The previous test assumed permissions would always be the same,
when they actually depend on umask settings.

This change creates a file *not* using the temporary API, gets its
permissions then compares it to the ones obtained using
AtomicFileWriter.

Note: we now only check the given permissions, not the "non-given".

* Use assertThat(..., equalTo()) instead of a manual loop

* Remove unused imports

* Use TemporaryFolder instead of manual temporary dir creation
2018-02-02 16:17:55 +01:00
Jesse Glick ac05680bb6 Introduced ACL.lambda convenience method (#3260)
* Introduced ACL.lambda convenience method.

* Javadoc
2018-02-02 15:56:55 +01:00
Daniel Beck f1fc0f02ed Merge pull request #3256 from daniel-beck/better-dependency-errors
Separate original and downstream dependency errors
2018-02-01 19:03:54 +01:00
Kseniia Nenasheva 2eda7816e8 [JENKINS-47793] - Jenkins master and agent configuration pages do not verify negative executor numbers (#3141)
* Fixed Regexps for number & positive-number

* Progress saving

* Fix for validation

* bug fixing

* bug fixing

* Address comments

* Address comments

* Address comments from @jglick

* Whitespace cleanup

* Address comment for @jglick
2018-01-30 17:33:53 +01:00
Oleg Nenashev e86e6f9e42 Merge pull request #3270 from oleg-nenashev/task-reactor/1.5
[JENKINS-48725] - Update Lib Task Reactor to 1.5
2018-01-30 17:33:05 +01:00
mike cirioli 5f0f9f2b87 [JENKINS-48463] added try-with-resources to XmlFileTest to ensure proper
file handle cleanup in the event of failure

Fixed small nits regarding typo's and code cleanup
Added comment explaining why Xpp3 is still included as a dep
2018-01-30 09:31:15 -05:00
Kohsuke Kawaguchi 1a7881ce60 Merge branch 'master' of github.com:jenkinsci/jenkins 2018-01-29 04:38:42 -08:00
Kohsuke Kawaguchi 53b9bdff75 [maven-release-plugin] prepare for next development iteration 2018-01-29 03:35:21 -08:00
Kohsuke Kawaguchi 4176b0c05e [maven-release-plugin] prepare release jenkins-2.104 2018-01-29 03:35:21 -08:00
Baptiste Mathus 91237450bc Disable test temporarily to get the release out
Note: this test is wrong, the production code is correct.
So that is why disabling this test until we fix it is OK.
2018-01-29 11:55:44 +01:00
Oleg Nenashev 66bb3dc6fd Merge pull request #3255 from dtrebbien/JENKINS-49060-include-filename-of-unreadable-file
[JENKINS-49060] Include the filename of the unreadable file in the exception message
2018-01-28 16:16:40 +01:00
Oleg Nenashev 839b003261 Merge pull request #1384 from daniel-beck/JENKINS-24452
[JENKINS-24452] Don't export arbitrary unexportable exceptions
2018-01-28 11:34:53 +01:00
Oleg Nenashev cd875f0e5a Merge pull request #3264 from jglick/Tomcat-JENKINS-49147
[JENKINS-49147] Tolerate unusual CodeSource.location format from old versions of Tomcat
2018-01-28 10:09:11 +01:00
Oleg Nenashev dbc75125c5 Merge pull request #3250 from oleg-nenashev/feature/JENKINS-48766-minimum-remoting-version
[JENKINS-48766] - Expose information about Remoting versions via API
2018-01-28 10:08:38 +01:00
Oleg Nenashev 73e2c9fb8f Merge pull request #3258 from daniel-beck/no-unbounded-polling
Remove support for unbounded number of polling threads
2018-01-28 10:08:01 +01:00
Oleg Nenashev b074b1aa19 Merge pull request #3261 from Wadeck/OLD_DATA_BOLD_ESCAPED
[JENKINS-49126] OldDataMonitor: Prevent escaping b-old version
2018-01-28 10:07:09 +01:00
Daniel Trebbien e798f64854 [JENKINS-49112] Revert use of Files.newBufferedReader() in Util.loadFile() (#3259)
* [JENKINS-49112] Revert use of Files.newBufferedReader() in Util.loadFile()

This partially reverts 67076834a2.

* Restore the use of StringBuilder and reading into buf
2018-01-26 18:35:20 +01:00
Oleg Nenashev f9b3b4ddbe Merge pull request #3266 from recena/JENKINS-49129
[JENKINS-49129] Manage Jenkins dropdown menu no longer works
2018-01-26 18:28:44 +01:00
Oleg Nenashev 720db118a8 [JENKINS-48725] - Update Lib Task Reactor to 1.5 2018-01-26 17:26:16 +01:00
mike cirioli d994e65a9a [JENKINS-48463] Erring on the side of caution and incuding xpp3 libs back
in, just in case some plugin might be depending on them
2018-01-26 10:16:34 -05:00
Oleg Nenashev 1a85ea6388 Merge pull request #3262 from MarcoAurelioWM/patch-2
Fix Spanish (es) link translation
2018-01-26 11:04:58 +01:00
Jesse Glick 6a3e60ef71 [JENKINS-46041] If guessBrowser fails, return null and move on. 2018-01-25 17:48:02 -05:00
Manuel Recena 18efa58abf [JENKINS-49129] Manage Jenkins dropdown menu no longer works 2018-01-25 23:41:25 +01:00
Jesse Glick 655be64a17 [JENKINS-49147] Tolerate unusual CodeSource.location format from old versions of Tomcat. 2018-01-25 12:21:08 -05:00
mike cirioli 992100ac42 [JENKINS-48463] - fixed reference to deprecated Xpp3Driver and replaced with
new default driver
2018-01-24 09:47:58 -05:00
mike cirioli 17f74fc713 Merge branch 'master' into OSS-2590 2018-01-24 09:27:57 -05:00
mike cirioli 0431cc75fd [JENKINS-48463] - Ignoring test xml1_0_withSpecialCharsShouldFail due to
KXml2Driver being tolerant of control characters which should be illegal
in an XML v1.0 content.  This test should be revisted if we switch to
another XML driver
2018-01-24 09:25:34 -05:00
mike cirioli a0f419120b [JENKINS-48463] It appears that the KXml2Driver is more tolerant of
technically illegal xml (ie. it doesn't complain if an Xml v1.0 file
contains special characters).  Added a unit test that proves this, as well
as fixing silentlyMigrateConfigsTest so that it starts with technically
valid Xml 1.0 content
2018-01-24 09:25:34 -05:00
mike cirioli b9c2148d6e [JENKINS-48463] Added a unit test that validates jenkins xml v1.0 configs
are silently migrated to xml v1.1 as they are persisted
2018-01-24 09:25:33 -05:00
mike cirioli 24a1852fc2 [JENKINS-48463] Added additional unit tests for verifying xml v1.1 compatibility
- verify can still read xml 1.0
  - verify can read xml 1.1
  - verify can read xml 1.1 with 'special' characters
  - verify that jenkins can start with a config.xml having
    <?xml version='1.1'> and special characters
2018-01-24 09:25:33 -05:00
mike cirioli 570b52dbcc [JENKINS-48463] refactored XStream2 to default to KXml2Driver by default.
Changed all explicit references of the hierarchical driver to use a static
convinience method XStream2.getDefaultDriver() to ensure all XML operations
are using the same driver.
2018-01-24 09:25:32 -05:00
mike cirioli 37365eeca7 [JENKINS-48463] update hard coded references of XPP3Driver to KXml2Driver in order to support XMLv1.1 2018-01-24 09:25:32 -05:00
mike cirioli 9a4a913e38 [JENKINS-48463] - update jenkins core to use xml v1.1
- switched to KxmlDriver (needed for xml 1.1 support)
  - updated to create xml v1.1 headers
  - updated test to use KXml2Driver explicitly
  - updated unit tests to support xml v1.1
2018-01-24 09:24:56 -05:00
Oleg Nenashev 0d1f80ba9f Merge pull request #3252 from oleg-nenashev/feature/JENKINS-49017-sublist
[JENKINS-49017] - Whitelist java.util.Sublist and java.util.RandomAccessSublist
2018-01-24 14:37:01 +01:00
MarcoAurelioWM 8e189efbdf Fix Spanish (es) link translation
Typo/gramar fix.
2018-01-24 13:09:57 +01:00
Wadeck Follonier 240a127315 OldDataMonitor: Prevent escaping b-old version 2018-01-24 10:56:38 +01:00
Daniel Beck 104f4888bb [FIXED JENKINS-24452] Don't export arbitrary unexportable exceptions 2018-01-24 10:46:33 +01:00
Daniel Beck f0b1bce2f4 Further clean up the polling threads option, better validation 2018-01-23 17:35:35 +01:00
Daniel Beck 7e8d817f78 Remove support for unbounded number of polling threads
The default is 10. Previously unbounded configs will be set to 10.
2018-01-23 14:45:10 +01:00
Wadeck Follonier 03d722dfaf - use the correct css class for the CSRF Admin monitor warnings 2018-01-23 14:39:06 +01:00
Daniel Beck d2b81b8ad1 Separate original and downstream dependency errors
Nobody understands 'fix this plugin first', so separate those from
the actual issues that need fixing.
2018-01-23 13:47:05 +01:00
Daniel Trebbien 0f1c35291d [JENKINS-49060] Include the filename of the unreadable file in the exception message 2018-01-22 18:50:01 -08:00
Oleg Nenashev b550c33301 Merge pull request #3251 from oleg-nenashev/feature/JENKINS-49070-big-decimal
[JENKINS-49070] - Whitelist BigDecimal and BigInteger
2018-01-22 22:34:59 +01:00
Kanstantsin Shautsou 688057c5ce java.util.Collections$SynchronizedSet !!! 2018-01-22 19:32:58 +03:00
Oleg Nenashev 6a85f93fb7 [JENKINS-49017] - Whitelist java.util.Sublist and java.util.RandomAccessSublist 2018-01-22 15:55:05 +01:00
Oleg Nenashev 1393f69359 [JENKINS-49070] - Whitelist BigDecimal and BigInteger 2018-01-22 14:16:29 +01:00
Oleg Nenashev 95f1f5ad19 [JENKINS-48766] - Print warnings in agent connection logs when the Remoting version is not supported 2018-01-22 11:24:32 +01:00
Oleg Nenashev 1b2f0e7e64 [JENKINS-48766] - Expose Remoting Minimum version in TcpSlaveAgentListener 2018-01-22 11:23:39 +01:00