file handle cleanup in the event of failure
Fixed small nits regarding typo's and code cleanup
Added comment explaining why Xpp3 is still included as a dep
technically illegal xml (ie. it doesn't complain if an Xml v1.0 file
contains special characters). Added a unit test that proves this, as well
as fixing silentlyMigrateConfigsTest so that it starts with technically
valid Xml 1.0 content
- verify can still read xml 1.0
- verify can read xml 1.1
- verify can read xml 1.1 with 'special' characters
- verify that jenkins can start with a config.xml having
<?xml version='1.1'> and special characters
Changed all explicit references of the hierarchical driver to use a static
convinience method XStream2.getDefaultDriver() to ensure all XML operations
are using the same driver.
- switched to KxmlDriver (needed for xml 1.1 support)
- updated to create xml v1.1 headers
- updated test to use KXml2Driver explicitly
- updated unit tests to support xml v1.1
* [JENKINS-43786] Initial source code modifications
* [JENKINS-43786] Adding a customized Bootstrap version and some messages were adapted
* [JENKINS-43786] Some Monitors included in the core have been adapted
* [JENKINS-43786] Reverting an unexisting typo
* [JENKINS-43786] Applying final styles
* [JENKINS-43786] Addressing more use cases
* [JENKINS-43786] Revisiting how the buttons are shown
* [JENKINS-43786] Adjustments in the administrative monitor pop-up
* [JENKINS-43786] Added more use cases related with administrative messages
* [JENKINS-43786] Adapted the Administrative Monitors provided by Jenkins core
* [JENKINS-43786] Addressed the @daniel-beck's review
* [JENKINS-43786] Wrong indent
* [JENKINS-43786] Better semantic HTML
* [JENKINS-43786] Better semantic HTML
* [JENKINS-43786] Applying the same criteria for listing items
* [JENKINS-43786] Adapted tests
* [JENKINS-43786] Removing redirect links in the administrative monitor descriptions
* [JENKINS-43786] Adapted Administrative Monitor
* [JENKINS-43786] Reverted Redirect URLs
* [JENKINS-43786] Applying the same code style
* [JENKINS-43786] Applying the same code style
* [JENKINS-43786] Apply a common HTML markup to the Administrative Monitors in core
* [JENKINS-43786] One more Administrative Monitor updated
* [JENKINS-43786] Polishing some details
* [JENKINS-43786] Deprecating CSS Styles
* [JENKINS-43786] We are ready for deprecating anything
* [JENKINS-43786] We are ready for deprecating anything
* [JENKINS-43786] Details
* [FIXES JENKINS-47406] Milestone JOB_LOADED is now attained after cleaning up obsolete items
This allows @Initializer(after=InitMilestone.JOB_LOADED) implementations
to create items safely without risking them to be removed.
* [JENKINS-47406] Add test with an initializer creating a job
* Revert "[FIXES JENKINS-47406] Milestone JOB_LOADED is now attained after cleaning up obsolete items"
This reverts commit 79ce796b00.
* [JENKINS-47406] Reinstate the test with Jesse's solution
* Reverted this commit by mistake
Revert "Revert "[FIXES JENKINS-47406] Milestone JOB_LOADED is now attained after cleaning up obsolete items""
This reverts commit 36c499c58c.
* Add link to hpi sources
* Fix Mix-up after the previous merge
* Revert "[JENKINS-48447] Fixed HTTP 404 error when clicking on newView sidebar link from an other view. (#3178)"
This reverts commit 6df06fc19a.
* Revert "[JENKINS-46911] createProjectFromXML not recognizing unsafe character… (#3057)"
This reverts commit ac2a1aaf89.
* [JENKINS-46911] createProjectFromXML not recognizing unsafe character '/'
* Better place for testCreateProjectCheckGoodName()
* Fix failed test
* Make changes suggested on PR review.
* Remove Failure exception, instead throw IOException. Add javadoc
* [JENKINS-46911] - Add TODO according to the comment from @jtnord.
Pulls in fixes for: JENKINS-48133, JENKINS-48055, JENKINS-37566, JENKINS-48309, JENKINS-47965, JENKINS-48130, JENKINS-37670, JENKINS-37566, JENKINS-46724
This change also adds some missing null/closing channel checks in the core.
In some cases the change prevents spawning threads if the channel is in the invalid state.
* Ensure all Jelly view have escape-by-default.
- all those views escape the content theirself, so no vulnerability corrected here (for TextParameterDefinition, it's done by textarea.jelly)
* - just a line break at end
* - just a line break at end (part 2)
* - change from st:out to j:out because their content is expected to be html tags
* - st => j for all finally