Commit Graph
56 Commits
Author SHA1 Message Date
James Nord 1f946961b9 s/javax.annotation.CheckForNull/edu.umd.cs.findbugs.annotations.CheckForNull/g 2020-03-26 16:12:35 +00:00
Jeff Thompson ced25e51fd Make sure everything has a justification.
And move a couple of items to the exclude file. If we ever get to a lower threshold, these will show up all over the place.
2020-01-23 14:55:59 -07:00
Jeff Thompson c76ee59810 Add findsecbugs plugin to spotbugs.
And suppress existing warnings. We should clean some of them up, but that's for different PRs.
2020-01-23 14:53:53 -07:00
Devin Nusbaum b18b2e686d [JENKINS-57725] - Wrap Proc.executor in ClassLoaderSanityThreadFactory (#4035) 2019-06-13 22:27:38 +02:00
Josh Soref 18847a9fc6 Omit useless argument 2019-02-21 00:27:12 -05:00
Josh Soref 0ad7d00099 Switch to using TimeUnit.UNIT.toUnit(...) 2019-02-26 12:13:41 -05:00
Oleg Nenashev 095310afdd Annotate and document methods of hudson.Launcher (#2920)
* Annotate and document methods of hudson.Launcher

* Fix newly introduced FindBugs issues in hudson.Launcher

* Remove brackets from FilePath#createLauncher() to avoid the merge conflict
2017-06-24 19:17:11 +02:00
Jesse Glick 7c16d8dc46 Fix Javadoc generation on JDK 8. 2017-04-11 09:26:45 -04:00
Daniel Beck 2a03dda885 Reference redirectors and jenkins.io as much as possible (#2756)
* Reference redirectors and jenkins.io as much as possible

* Something went wrong, so this is a troubleshooting URL

* More specific redirect URLs
2017-02-25 19:56:01 +01:00
Jesse Glick 76aa0727f0 Functions.printStackTrace utility method. 2016-12-12 17:56:24 -05:00
Jesse Glick 24aa20635d Replaced other usages of printStackTrace. 2016-12-12 16:44:10 -05:00
Oleg Nenashev 29893354a5 [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods (#2653)
* [JENKINS-23271] - Process statuses of Remote process join() operations directly inside methods

* [JENKINS-23271] - Also prevent the issue when the kill() command is the last call in the usage sequence
2016-12-03 16:55:35 +01:00
Vojtěch Juránek 61f0455cd7 [FIXED JENKINS-36277] Check that process working dir exists (#2424) 2016-06-29 12:16:12 +02:00
Baptiste Mathus 8b3e4f43a2 Multi-catch refactoring when applicable 2016-04-12 10:17:42 +02:00
David Hoover 1709ed3a2e Add @Deprecated annotations to things documented as @deprecated. 2015-04-19 14:50:12 -07:00
Jesse Glick b305fe082c Added NamingThreadFactory to ensure that all code creating thread pool executors was marking the threads.
Otherwise we get a bunch of pool-17-thread-5 with no clue who created so many threads or why.
Also simplifies existing code which previously had to write one-off ThreadFactory implementations just to set a name.
2013-11-15 18:30:29 -05:00
Jesse Glick 15ac490af1 Now that we use Java 6, can finally deprecate IOException2. 2013-11-15 08:19:59 -05:00
Kohsuke Kawaguchi dc94b7d063 [FIXED JENKINS-8686]
As I mentioned in the comment, I doubt if this makes any behaviour change, but this seems like a sensible defensive measure that wouldn't hurt.
2013-04-02 09:58:50 -07:00
Christoph Kutzinski acfe9984bd Mentioned what RemoteProc was replaced with 2012-09-09 17:16:06 +02:00
Kohsuke Kawaguchi df32805382 improving the error handling 2011-03-11 14:17:38 -08:00
Kohsuke Kawaguchi 96dd84b5d0 [FIXED JENKINS-7809] expose child process stdout as InputStream.
I added a mode where one can launch a child process without the built-in pumping support, making it trivial to read until EOF in the distributed environments.

 This concludes the fix.
2011-02-16 08:28:00 -08:00
Kohsuke Kawaguchi 3a3690b281 [FIXED JENKINS-7809] fixed a race condition in obtaining the tail of the output from remote process. 2011-02-14 17:13:24 -08:00
Kohsuke Kawaguchi 8b41031750 [FIXED JENKINS-8420] recording 3c5c2c5cc3 2011-02-14 11:10:45 -08:00
baptiste 3c5c2c5cc3 [FIXED HUDSON-8420] With IBM JDK for example, it seems like there's no
differentiation between Process InputStream&ErrorStream :-(. This
means that closing errorStream will actually close every streams.
2011-02-14 10:47:31 -08:00
Kohsuke Kawaguchi 3a1447ea9a Updating the URL. 2011-01-30 23:44:52 -08:00
Kohsuke Kawaguchi d1543575e2 [FIXED HUDSON-8244] turns out Process.getErrorStream() needs to be explicitly closed even when stderr is redirected to stdout. 2010-12-10 23:50:17 -08:00
sogabe 6e844cc1f4 Removed unsed import.
Replaced old wiki URL.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@35752 71c3de6d-444a-0410-be80-ed276b4c234a
2010-10-11 15:44:54 +00:00
jglick 2bd01adb61 [FIXED HUDSON-6559] Proc.joinWithTimeout convenience method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@32076 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-15 22:19:57 +00:00
kohsuke 3d44678e8c Added a new extension point to plug in custom utility to kill processes.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@31898 71c3de6d-444a-0410-be80-ed276b4c234a
2010-06-10 01:44:15 +00:00
kohsuke f0c02d7339 doc improvement
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@24851 71c3de6d-444a-0410-be80-ed276b4c234a
2009-12-22 17:59:22 +00:00
kohsuke d4ad980691 Merged revisions 23689-23691 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r23689 | kohsuke | 2009-11-12 15:35:27 -0800 (Thu, 12 Nov 2009) | 1 line
  
  improved diagnosability
........
  r23690 | kohsuke | 2009-11-12 18:03:42 -0800 (Thu, 12 Nov 2009) | 1 line
  
  adding a probe to diagnose a sporadic test failure
........
  r23691 | kohsuke | 2009-11-12 18:14:21 -0800 (Thu, 12 Nov 2009) | 1 line
  
  I think this is causing a test failure in ExtendedReadPermissionTest, as the existing alice/bob/charlie users prevent the data on the disk from loading.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23692 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-13 02:18:09 +00:00
jglick 6ccad2bc32 [FIXED HUDSON-4611] hudson.proc.RemoteProc.kill() was a no-op.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@23526 71c3de6d-444a-0410-be80-ed276b4c234a
2009-11-06 18:34:11 +00:00
kohsuke 08c9928037 allow subtypes to be defined by plugins.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21686 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-15 18:12:52 +00:00
mindless 9fed9823f5 Add @Override annotations, remove unused imports,
add some copyright headers, some tab->ws


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21654 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-14 18:08:34 +00:00
kohsuke a86fe5e9c7 reformatted import statements
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19435 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 21:32:11 +00:00
kohsuke af1d6538f4 generalized ProcessTreeKiller to expose more system information, so that the plugins and core can do more interesting things.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@19434 71c3de6d-444a-0410-be80-ed276b4c234a
2009-07-06 21:31:29 +00:00
kohsuke a6684093da fixed NPE
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18984 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-16 23:32:57 +00:00
kohsuke bcd8e37595 finally introduced the builder pattern for Launcher, to stop combinatorial explosion of the launch method
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18944 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-16 06:38:22 +00:00
kohsuke cf439c5be9 StringBuffer->StringBuilder
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18938 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-16 04:42:57 +00:00
kohsuke f5d4856b5c cancel out the effect of buffering done by JDK
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@18904 71c3de6d-444a-0410-be80-ed276b4c234a
2009-06-14 18:46:38 +00:00
kohsuke 481fd5ab2e [FIXED HUDSON-2394] Improved error handling when Maven fails to start correctly in the m2 project type.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15501 71c3de6d-444a-0410-be80-ed276b4c234a
2009-02-20 20:28:57 +00:00
kohsuke 1a1d0d74d5 license header clean up
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@15081 71c3de6d-444a-0410-be80-ed276b4c234a
2009-02-06 20:05:24 +00:00
kohsuke baa6c9d6ba enabling the magic cookie
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@7978 71c3de6d-444a-0410-be80-ed276b4c234a
2008-03-23 05:29:20 +00:00
kohsuke a1fbc4bffc hooking up ProcessTreeKiller
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@7976 71c3de6d-444a-0410-be80-ed276b4c234a
2008-03-23 05:02:01 +00:00
kohsuke bda15d2acb integrated winp so that Hudson can kill processes recursively on Windows.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@7016 71c3de6d-444a-0410-be80-ed276b4c234a
2008-02-08 06:17:02 +00:00
kohsuke 036eaefeef leak handling was not working.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@5906 71c3de6d-444a-0410-be80-ed276b4c234a
2007-11-15 02:12:25 +00:00
kohsuke 402da21bae fixed #1006 --- NPE in launching a process without alterning env variables.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@5875 71c3de6d-444a-0410-be80-ed276b4c234a
2007-11-13 17:09:18 +00:00
kohsuke e97a31d267 bug fix.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@5740 71c3de6d-444a-0410-be80-ed276b4c234a
2007-11-06 14:33:49 +00:00
kohsuke dbba18a0e2 redirect error stream to reduce the # of threads.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@5739 71c3de6d-444a-0410-be80-ed276b4c234a
2007-11-06 14:20:22 +00:00
kohsuke 852b2736c8 detect a situation described in http://hudson.gotdns.com/wiki/display/HUDSON/Spawning+processes+from+build and report this as a warning.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@4631 71c3de6d-444a-0410-be80-ed276b4c234a
2007-09-04 05:02:28 +00:00