Commit Graph
4017 Commits
Author SHA1 Message Date
kohsuke 126f04cd50 improved error diagnosis to point out which site we are trying to access.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22519 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-08 14:45:26 +00:00
jglick 263d587cc3 [FIXED HUDSON-4609] Overview of polling activity was never showing anything, due to confusion between two kinds of Runnable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22459 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-06 16:00:21 +00:00
jglick f74eaaffbf Correcting import in Javadoc.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22454 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-06 15:30:09 +00:00
kohsuke 6b1e9c2510 Fixed a bug in the form submission logic of the SMTP authentation configuration.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22396 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-05 01:46:13 +00:00
kohsuke 0acbe7478c Hudson shouldn't store SMTP auth password in a clear text.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22382 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-04 14:55:20 +00:00
kohsuke 8dd9f1bf42 Secret class should be serialization forward compatible with Strnig.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22381 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-04 14:52:21 +00:00
kohsuke 704899683c [FIXED HUDSON-4592] Generally speaking, security manager restricts too many things away that you'll unlikely to get Hudson function properly. Hudson has a graceful error check for this in its ServletContextInitializer, but it looks like the filters are initialized before that, and causing the hard failure that you saw.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22379 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-04 01:41:38 +00:00
kohsuke 397d45193d Added a form validation check to detect typical errors like http://www.nabble.com/cannot-setup-email-account-td25727896.html
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22378 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-04 01:22:07 +00:00
pgweiss 6f0c7ec9a8 Use -Dhudson.upstreamCulprits=true to implement passing culprit information to downstream jobs
in core.  I prefer this to a plugin as I want to use the existing email infrastructure.

I assume that when taksan does his plugin it will work as long as this property is _not_ set.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22362 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-02 20:33:07 +00:00
kohsuke b3166a03c7 [HUDSON-4590] only send a request up to every once in 10 seconds in order to avoid hitting java.net too hard when it's about to recover from an outage.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22348 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-02 18:38:15 +00:00
kohsuke 967531a1e3 [FIXED HUDSON-4590] Defer injection of the script until the page load event fires, so that inability to load scripts from java.net wouldn't block other things that's wating for the firing of the onload event.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22347 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-02 18:09:47 +00:00
kohsuke 596e2b9de1 without a message, it's as if the validate button didn't do anything
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22330 71c3de6d-444a-0410-be80-ed276b4c234a
2009-10-01 21:27:30 +00:00
dty 572039518a Added visibility attribute to fields that are exported through the remote API.
The default behavior doesn't change, but fields that don't contain output are
now more visible (they will stay visible through depth=-10, where they before
they went away at depth=-1). Field with test out, i.e., stderr, stdout,
errorDetails, errorStackTrace can now be excluded seperately from other fields.



git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22276 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-29 00:06:28 +00:00
kohsuke 6fb51882fc doc improvement.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22266 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 20:45:37 +00:00
kohsuke dc11d862ec Added an extension point for inserting actions across all projects without configuration.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22262 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 20:36:04 +00:00
kohsuke d69c7f678e Merged revisions 22140,22200,22202,22205,22237,22240,22242,22245 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/rc

........
  r22140 | kohsuke | 2009-09-24 16:41:50 -0700 (Thu, 24 Sep 2009) | 1 line
  
  updating to a new version
........
  r22200 | kohsuke | 2009-09-25 16:33:50 -0700 (Fri, 25 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_325
........
  r22202 | kohsuke | 2009-09-25 16:34:05 -0700 (Fri, 25 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r22205 | kohsuke | 2009-09-25 17:09:38 -0700 (Fri, 25 Sep 2009) | 1 line
  
  updated changelog as a part of the release
........
  r22237 | kohsuke | 2009-09-28 09:51:38 -0700 (Mon, 28 Sep 2009) | 1 line
  
  [HUDSON-4353] My fix had a crucial bug that prevents plugin updates from failing.
........
  r22240 | kohsuke | 2009-09-28 10:37:51 -0700 (Mon, 28 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare release hudson-1_326
........
  r22242 | kohsuke | 2009-09-28 10:39:05 -0700 (Mon, 28 Sep 2009) | 1 line
  
  [maven-release-plugin] prepare for next development iteration
........
  r22245 | kohsuke | 2009-09-28 11:24:40 -0700 (Mon, 28 Sep 2009) | 1 line
  
  updated changelog as a part of the release
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22250 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 19:58:53 +00:00
jglick 39cf92377e dos2unix for text files in repo (minus plugins/). SVN client on Windows should convert where needed.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22234 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-28 15:47:43 +00:00
kohsuke bb984e4dd6 [FIXED HUDSON-3721] Job-enabling API should reject GET requests.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22207 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-26 00:13:35 +00:00
mindless a119c26b9c javadoc update
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22187 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-25 19:15:40 +00:00
kohsuke a8ed1912f1 javadoc bug fix
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22186 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-25 18:57:41 +00:00
kohsuke 9d435fc99a Added a CLI command <tt>install-tool</tt> to invoke a tool auto-installation from Hudson CLI.
(<a href="http://www.nabble.com/Passing-env-variables-automatically-td25584186.html">report</a>)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22144 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-25 02:19:41 +00:00
kohsuke 7ac155c8ca Tests the plugin installation.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22101 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-24 19:49:10 +00:00
kohsuke 2e68f75312 [HUDSON-4531] extension point without a descriptor is now reported with more information for a better troubleshooting.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22098 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-24 18:59:07 +00:00
kohsuke 9b981befbe Merged revisions 22092 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r22092 | kohsuke | 2009-09-24 10:13:43 -0700 (Thu, 24 Sep 2009) | 1 line
  
  Because Util.fixNull() is overloaded, Groovy won't be able to find the right version. Also added a regression test.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22093 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-24 18:02:30 +00:00
kohsuke 3e967dd85d added a mechanism to check the existence of a command.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22059 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-23 19:07:05 +00:00
kohsuke 8526b2e6c4 [HUDSON-3889] In 1.325, I added a ping support so that the master detects dead connections more rapidly. This feature is off by default, until we feel comfortable enough that this feature works correctly.
You can enable this by setting the system property "-Dhudson.slaves.ConnectionActivityMonitor.enabled=true" on your container.
Once enabled, inactive slaves are pinged after 3 minutes, and after 6 failed pings 10 secs apart, the connection is deemed failed
and the slave gets cut off. So in total it takes 4 minutes to detect a failure.

I appreciate the feedback on this.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22039 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-23 02:22:13 +00:00
kohsuke 3adada0046 [HUDSON-3889] JNLP clients now report the reason when the connection is rejected by the master.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22037 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-23 01:50:31 +00:00
mindless c039b28791 Update uses of deprecated APIs (most notably, changing
AbstractProject.doWs from void to returning DirectoryBrowserSupport)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22034 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-23 01:20:05 +00:00
mindless 49a797b5fe remove unused imports, fix javadoc typo
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22032 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-23 01:06:29 +00:00
kohsuke db98a31d14 [FIXED HUDSON-3942] Fixed in 1.325. We probably need some kind of mechanical checks to make sure all the fields are variable expanded. Otherwise this is too error prone.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22031 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-22 23:52:52 +00:00
kohsuke a08d584254 [FIXED HUDSON-3983] The root cause of the problem is that the "test e-mail" feature wasn't using the SMTP auth values as currently entered in the form, but it was picking up values from what Hudson is currently configured with. This is fixed in 1.325.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22029 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-22 23:45:32 +00:00
mindless f9a0284025 Add permission check in FilePath.validateFileMask,
and add note in javadoc for check already done in validateRelativePath.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22026 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-22 23:18:27 +00:00
kohsuke 99cd629a66 modernized the layout.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@22001 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-22 17:45:56 +00:00
kohsuke be7cdd1e92 This is the correct fix for HUDSON-4353.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21996 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-22 15:38:33 +00:00
kohsuke 25ca3de5fc Update center will create backup files to make it easier for manual roll back of botched upgrades.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21980 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 23:52:09 +00:00
kohsuke 66f157955a [FIXED HUDSON-4353] we should now be able to update bundled plugins.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21979 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 23:46:47 +00:00
kohsuke b8f2b7949d TAB->WS
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21978 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 23:31:32 +00:00
kohsuke 516866e06d adding the notion that a plugin can be pinned to avoid overwritten by a bundled plugin.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21977 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 23:29:38 +00:00
kohsuke 16a1ae58d1 [FIXED HDUSON-4514]
This is a problem in the core. The repositoryBrowser type shouldn't be persisted. Fixed toward 1.325.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21961 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 20:42:16 +00:00
mindless 92f54b4477 avoid repeated maxDescrLength-ending.length() calculations in getTruncatedDescription
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21951 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-21 17:37:46 +00:00
mindless b957f01246 add @Override annotations, tab->ws
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21902 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-19 20:19:07 +00:00
kohsuke 58e6059539 removed warning.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21890 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-19 02:02:59 +00:00
kohsuke 9882aba6a9 fixed NPE when Maven build is aborted.
MavenBuild (a Run for a module) does push(null), and its corresponding onEndBuilding() won't be invoked due to the abort. I guess the real root cause is to make sure the corresponding onEndBuilding() is always invoked, as not doing so can have other unintended side effect.

The stack trace of the problem was:

ERROR: Processing failed due to a bug in the code. Please report this to users@hudson.dev.java.net
java.lang.NullPointerException
	at hudson.model.Run$Runner.access$000(Run.java:1007)
	at hudson.model.Run.reportCheckpoint(Run.java:984)
	at hudson.model.CheckPoint.report(CheckPoint.java:113)
	at hudson.tasks.MailSender.execute(MailSender.java:107)
	at hudson.maven.reporters.MavenMailer.end(MavenMailer.java:54)
	at hudson.maven.MavenModuleSetBuild$Builder.end(MavenModuleSetBuild.java:677)
	at hudson.maven.MavenModuleSetBuild$RunnerImpl.doRun(MavenModuleSetBuild.java:480)
	at hudson.model.AbstractBuild$AbstractRunner.run(AbstractBuild.java:354)
	at hudson.model.Run.run(Run.java:1123)
	at hudson.maven.MavenModuleSetBuild.run(MavenModuleSetBuild.java:302)
	at hudson.model.ResourceController.execute(ResourceController.java:88)
	at hudson.model.Executor.run(Executor.java:123)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21883 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-19 00:30:25 +00:00
kohsuke 0755dd6fe4 TAB -> WS
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21875 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 23:12:00 +00:00
kohsuke 0bb6580426 added another CLI command.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21874 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 22:47:11 +00:00
kohsuke 0969b2213d Hudson itself needs to be resolvable.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21873 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 22:46:58 +00:00
kohsuke f27973c6b3 adding more CLI commands.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21870 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 21:01:34 +00:00
kohsuke efbfd13483 useful convenience method
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21869 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 20:34:22 +00:00
mindless 21e3b3ec60 Add "since .." on deprecated things
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21863 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 18:54:42 +00:00
kohsuke d3b5cde166 improved the error handling
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@21858 71c3de6d-444a-0410-be80-ed276b4c234a
2009-09-18 18:09:11 +00:00