Commit Graph
2223 Commits
Author SHA1 Message Date
Jesse Glick 14d676bb15 [FIXED JENKINS-25788] RunMap.remove was always returning false, even when the Run was in fact removed.
(cherry picked from commit ce94579c50)

Conflicts:
	changelog.html
2015-01-06 20:55:46 +01:00
Jesse Glick 21a619f2e0 JUnit 4.
(cherry picked from commit 96ecabedb0)
2015-01-06 20:55:24 +01:00
Jesse Glick 23152a6da4 For RunMapTest to be Groovy was pointless and aggravating.
(cherry picked from commit 30f00b111a)
2015-01-06 20:55:24 +01:00
Christof Schoell 7169a39165 [JENKINS-25144]
return authentication object instead of null if authentication is not
required - otherwise valid login fails with basic authentication

(cherry picked from commit 0176b6d902)
2014-12-21 19:26:50 +01:00
Kohsuke Kawaguchi 03600e925c [maven-release-plugin] prepare release jenkins-1.580.2 2014-12-15 11:15:16 -08:00
Jesse Glick 0efd811adb [FIXED JENKINS-22769] ItemListener callbacks should run as SYSTEM since they sometimes do ACL-checked calls.
(cherry picked from commit c04cdcd9f7)

Conflicts:
	changelog.html
2014-11-08 11:18:49 +01:00
Nicolas De Loof 03a13fcf97 test case for JENKINS-24825
(cherry picked from commit 8975b0e0b5)
2014-11-07 14:47:14 +01:00
Kohsuke Kawaguchi 3229bdaac8 [maven-release-plugin] prepare for next development iteration 2014-10-29 21:06:06 -07:00
Kohsuke Kawaguchi 388fa0b44a [maven-release-plugin] prepare release jenkins-1.580.1 2014-10-29 21:06:06 -07:00
Kohsuke Kawaguchi e70601482a Merge branch 'SECURITY-144' into SECURITY-144-stable-1.580 2014-10-18 22:43:12 -07:00
Kohsuke Kawaguchi b4c2a1392b Now that the default is off, test has to activate this explicitly 2014-10-18 22:42:08 -07:00
Kohsuke Kawaguchi 4ab018a078 Merge branch 'SECURITY-144' into SECURITY-144-stable-1.580 2014-10-18 20:30:28 -07:00
Kohsuke Kawaguchi b4ffb2d01b More follow-up renames 2014-10-18 19:47:19 -07:00
Jesse Glick 4ddafceec3 Merge branch 'SECURITY-144' into SECURITY-144-stable-1.580
Conflicts:
	core/src/main/java/hudson/EnvVars.java
	core/src/main/java/hudson/FilePath.java
	core/src/main/java/hudson/cli/ClientAuthenticationCache.java
	core/src/main/java/hudson/markup/MyspacePolicy.java
	core/src/main/java/hudson/model/Computer.java
	core/src/main/java/hudson/node_monitors/DiskSpaceMonitorDescriptor.java
	core/src/main/java/hudson/node_monitors/ResponseTimeMonitor.java
	core/src/main/java/hudson/node_monitors/TemporarySpaceMonitor.java
	core/src/main/java/hudson/security/AbstractPasswordBasedSecurityRealm.java
	core/src/main/java/hudson/slaves/SlaveComputer.java
	core/src/main/java/hudson/tasks/Fingerprinter.java
	core/src/main/java/hudson/tasks/Shell.java
	core/src/main/java/hudson/tasks/junit/JUnitParser.java
	core/src/main/java/hudson/tasks/test/DefaultTestResultParserImpl.java
	core/src/main/java/hudson/util/ProcessTree.java
	core/src/main/java/hudson/util/RemotingDiagnostics.java
	core/src/main/java/jenkins/model/Jenkins.java
	core/src/test/java/hudson/LauncherTest.java
	pom.xml
2014-10-16 13:13:31 -04:00
Jesse Glick 1203b09190 Merge branch 'security' into stable-1.580
Conflicts:
	.idea/compiler.xml
	.idea/encodings.xml
	core/pom.xml
	core/src/main/java/hudson/Functions.java
	core/src/main/java/hudson/markup/MyspacePolicy.java
	core/src/main/java/hudson/model/AbstractItem.java
	core/src/main/java/hudson/security/ACL.java
	core/src/main/java/hudson/util/RobustReflectionConverter.java
	core/src/main/resources/lib/layout/layout.jelly
	pom.xml
	test/src/main/java/org/jvnet/hudson/test/HudsonTestCase.java
	test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
	test/src/test/groovy/hudson/cli/BuildCommandTest.groovy
	test/src/test/groovy/hudson/matrix/MatrixProjectTest.groovy
	test/src/test/groovy/hudson/model/AbstractProjectTest.groovy
	test/src/test/groovy/hudson/model/UpdateCenter2Test.groovy
	test/src/test/java/hudson/model/UpdateSiteTest.java
	test/src/test/java/hudson/tasks/FingerprinterTest.java
	test/src/test/java/hudson/tasks/junit/CaseResultTest.java
	test/src/test/java/hudson/tasks/junit/JUnitResultArchiverTest.java
	war/pom.xml
2014-10-16 12:21:36 -04:00
Jesse Glick b3bb0b8ae4 FilePath.untar, as called by jenkins-clone-workspace-scm-plugin, was also broken.
.tar and .zip seem OK.
2014-10-15 18:24:30 -04:00
Jesse Glick f39c2f1ba2 Renamed to more appropriate package. 2014-10-15 18:05:16 -04:00
Jesse Glick d7abde81d3 Reproduced FilePath.unzip problem from chromedriver-plugin in test. 2014-10-15 16:36:41 -04:00
Oliver Gondža 66dce647d1 [JENKINS-11543] Unit test
(cherry picked from commit 75f5d2180f)
2014-10-13 22:24:15 +02:00
David Ruhmann efae48a451 [FIXED JENKINS-7478]
Create Line Ending Conversion utility to convert scripts to proper OS
line ending type.  Tests included.

(cherry picked from commit 67ac47af07)
2014-10-12 16:39:07 +02:00
Oliver Gondža b105627b73 Towards 1.580.1 2014-10-12 16:35:39 +02:00
Jesse Glick 4f736a9334 Merge branch 'security' into SECURITY-144 2014-09-25 13:30:42 -04:00
Jesse Glick 3ba17df3b3 Moving one test case to maven-plugin.
(cherry picked from commit 261f40533e)
2014-09-25 13:30:33 -04:00
Jesse Glick 7af7fbb0fc Merge branch 'security' into SECURITY-144 2014-09-25 10:08:34 -04:00
Jesse Glick 5612b235ef Moving hudson.maven tests to maven-plugin.
(cherry picked from commit facfc178df)
2014-09-25 10:08:18 -04:00
Kohsuke Kawaguchi 1e40aa5805 Expand the test to cover diagnostic stack trace 2014-09-24 11:46:22 -07:00
Kohsuke Kawaguchi 201b035cfc Updated to reflect the signature change around role checking in remoting 2014-09-24 09:43:31 -07:00
Kohsuke Kawaguchi ffb5b65093 Switched from annotation based scheme to a function based scheme. 2014-09-23 19:12:43 -07:00
Jesse Glick 14d33d4ba4 Demonstrating that local FilePath operations within a slave callable are unaffected by FilePathFilter.
This is because we are not installing a filter on the reverse channel.
2014-09-23 16:05:10 -04:00
Jesse Glick cf36145eed Merge branch 'security' into SECURITY-144 2014-09-23 10:17:23 -04:00
Jesse Glick 1d29041372 [JENKINS-21984] Disabling cert check on updateDirectlyWithJson since the certificate is now expired, and it is no good to have a test which is known to start failing at a particular time in the future!
(cherry picked from commit 334ce1be69)
2014-09-23 09:59:01 -04:00
Jesse Glick 1e8076d569 The jenkins_main_trunk job has been retired, so for now just skip these tests when running on any Jenkins server.
(cherry picked from commit b7d4c6a414)

Conflicts:
	test/src/test/groovy/hudson/cli/BuildCommandTest.groovy
2014-09-23 09:56:19 -04:00
Jesse Glick 735ba83148 Installing a default FilePathFilter that rejects everything. 2014-09-22 12:54:05 -04:00
Jesse Glick ad200c3888 Merge branch 'security' into SECURITY-144 2014-09-19 16:46:14 -04:00
Jesse Glick 6e1defe58a Skip a test if starting Jenkins was interrupted.
For reasons TBD, sometimes CI tests fail with (1.565.x):
java.lang.InterruptedException: null
	at java.lang.Object.wait(Native Method)
	at java.lang.Object.wait(Object.java:503)
	at org.jvnet.hudson.reactor.Reactor.execute(Reactor.java:267)
	at jenkins.InitReactorRunner.run(InitReactorRunner.java:44)
	at jenkins.model.Jenkins.executeReactor(Jenkins.java:915)
	at jenkins.model.Jenkins.<init>(Jenkins.java:814)
	at hudson.model.Hudson.<init>(Hudson.java:82)
	at org.jvnet.hudson.test.JenkinsRule.newHudson(JenkinsRule.java:539)
	at org.jvnet.hudson.test.JenkinsRule.before(JenkinsRule.java:331)
	at org.jvnet.hudson.test.JenkinsRule$2.evaluate(JenkinsRule.java:479)
(cherry picked from commit 7bbf36b7f0)
2014-09-19 16:36:03 -04:00
Jesse Glick 201065ffef Trying to make SocketTimeoutException’s (as originally noted in 3ec7e56) not turn into test errors. (Works only in JenkinsRule, not HudsonTestCase.) Still have no clue as to cause.
(cherry picked from commit 6fd76ea2e8)

Conflicts:
	test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
2014-09-19 16:35:52 -04:00
Jesse Glick d44f85894d Trying to diagnose recent CI failures of HtmlUnit calls.
For example https://jenkins.ci.cloudbees.com/job/core/job/jenkins-core-validated-merge/38/testReport/lib.layout/LayoutTest/rejectedLinks/ failed with:
java.io.IOException: GET http://localhost:52099/jenkins/login failed
	at java.net.SocketInputStream.socketRead0(Native Method)
	at java.net.SocketInputStream.read(SocketInputStream.java:152)
	at java.net.SocketInputStream.read(SocketInputStream.java:122)
	at java.io.BufferedInputStream.fill(BufferedInputStream.java:235)
	at java.io.BufferedInputStream.read(BufferedInputStream.java:254)
	at org.apache.commons.httpclient.HttpParser.readRawLine(HttpParser.java:78)
	at org.apache.commons.httpclient.HttpParser.readLine(HttpParser.java:106)
	at org.apache.commons.httpclient.HttpConnection.readLine(HttpConnection.java:1116)
	at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager$HttpConnectionAdapter.readLine(MultiThreadedHttpConnectionManager.java:1413)
	at org.apache.commons.httpclient.HttpMethodBase.readStatusLine(HttpMethodBase.java:1973)
	at org.apache.commons.httpclient.HttpMethodBase.readResponse(HttpMethodBase.java:1735)
	at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1098)
	at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398)
	at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171)
	at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397)
	at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:346)
	at com.gargoylesoftware.htmlunit.HttpWebConnection.getResponse(HttpWebConnection.java:101)
	at com.gargoylesoftware.htmlunit.WebClient.loadWebResponseFromWebConnection(WebClient.java:1456)
	at com.gargoylesoftware.htmlunit.WebClient.loadWebResponse(WebClient.java:1387)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:328)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:389)
	at com.gargoylesoftware.htmlunit.WebClient.getPage(WebClient.java:374)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.goTo(JenkinsRule.java:1944)
	at org.jvnet.hudson.test.JenkinsRule$WebClient.goTo(JenkinsRule.java:1926)
	at lib.layout.LayoutTest.rejectedLinks(LayoutTest.java:44)
which makes little sense since the named IOException is actually thrown from HttpWebConnection.java:130.
Perhaps Surefire is not reporting the original cause correctly, conflating the wrapper’s message with the original stack trace.
As a temporary measure, printing the original stack trace to stderr if there is any.
(cherry picked from commit 3ec7e562fe)

Conflicts:
	test/src/main/java/org/jvnet/hudson/test/JenkinsRule.java
2014-09-19 16:28:56 -04:00
Jesse Glick 389a565de4 [JENKINS-10615] AbstractProjectTest.testWorkspaceLock frequently fails on jenkins.ci due to InterruptedException in HudsonTestCase.setUp.
Possibly because it is sorted after [JENKINS-15156] testGetBuildAfterGC and the test suite times out.

(cherry picked from commit 85e9e12677)
2014-09-19 16:27:32 -04:00
Jesse Glick 7211c0d42a Merge branch 'security' into SECURITY-144
Conflicts:
	maven-plugin/src/main/java/hudson/maven/AbstractMavenBuilder.java
	maven-plugin/src/main/java/hudson/maven/AbstractMavenProcessFactory.java
	maven-plugin/src/main/java/hudson/maven/Maven31ProcessFactory.java
	maven-plugin/src/main/java/hudson/maven/Maven3Builder.java
	maven-plugin/src/main/java/hudson/maven/Maven3ProcessFactory.java
	maven-plugin/src/main/java/hudson/maven/MavenBuildProxy.java
	maven-plugin/src/main/java/hudson/maven/MavenBuilder.java
	maven-plugin/src/main/java/hudson/maven/MavenProcessFactory.java
	maven-plugin/src/main/java/hudson/maven/MavenVersionCallable.java
	maven-plugin/src/main/java/hudson/maven/ProcessCache.java
	maven-plugin/src/main/java/hudson/maven/RedeployPublisher.java
	maven-plugin/src/main/java/hudson/maven/SplittableBuildListener.java
2014-09-19 14:06:56 -04:00
Kohsuke Kawaguchi 048d759792 maven plugin is moved off to a separate repository.
See https://github.com/jenkinsci/maven-plugin

(cherry picked from commit f98070d3e6)

Conflicts:
	maven-plugin/pom.xml
	maven-plugin/src/main/java/hudson/maven/AbstractMavenProcessFactory.java
	maven-plugin/src/main/java/hudson/maven/MavenModuleSetBuild.java
	maven-plugin/src/main/java/hudson/maven/MavenProcessFactory.java
	maven-plugin/src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly
	plugins/pom.xml
	pom.xml
2014-09-19 14:03:30 -04:00
Kohsuke Kawaguchi 101b4e7fd5 [SECURITY-144] Classify all the core callables one way or the other 2014-09-18 15:07:31 -07:00
Kohsuke Kawaguchi 892af3c4b7 [maven-release-plugin] prepare release jenkins-1.580 2014-09-14 16:30:02 -07:00
Daniel Beck 9bc2f1d057 Merge pull request #1377 from daniel-beck/JENKINS-19764
[FIXED JENKINS-19764] Ensure parent dir of new builds dir exists.
2014-09-06 00:31:47 +02:00
Kohsuke Kawaguchi 54d44502bd [FIXED SECURITY-127]
CONFIGURE permission shouldn't allow the type of the job to be changed.
That's more of CREATE+DELETE.

In any case, the code doesn't correctly handling submitting config.xml
for a different type.
2014-09-02 16:12:47 -07:00
Kohsuke Kawaguchi db757116f1 [FIXED SECURITY-128]
It may be that the 'newName' exists and just not visible to the user trying to do a rename
2014-09-02 14:05:42 -07:00
Kohsuke Kawaguchi 1a4aef1172 the trunk is toward 1.580-SNAPSHOT 2014-09-01 08:21:17 -07:00
Kohsuke Kawaguchi b1803a9539 [FIXED SECURITY-110]
Don't let UsernameNotFoundException vs BadCredentialsException
difference to be seen by the caller, for that tells whether the user
exists or not.

But to assist trouble-shooting, do report that error to the server. UUID
helps the user finds the information in the log file
2014-08-29 18:02:02 -07:00
Jesse Glick 52c28ae38d NPE diagnosis from ProjectTest.testCheckout.
java.lang.NullPointerException: null
	at hudson.model.AbstractBuild.setWorkspace(AbstractBuild.java:296)
	at hudson.model.ProjectTest.testCheckout(ProjectTest.java:423)
2014-08-29 20:01:13 -04:00
Jesse Glick bdc91654f6 [JENKINS-24317] Amending 80f78d5732.
If we are running on a case-insensitive FS, the test makes no sense because migration would never even be attempted to begin with.
2014-08-28 15:45:47 -04:00
tfennelly 80f78d5732 Fixing dir listing in test to not be case sensitive (related to JENKINS-24317) 2014-08-27 22:08:16 +01:00