Commit Graph
294 Commits
Author SHA1 Message Date
MinWoo 0a32a38cdc Fix incorrect return description in unquote Javadoc (#27289)
Correct Javadoc for QuotedStringTokenizer.unquote
2026-08-23 07:33:20 -06:00
7974eb7cea Fix incorrect Unicode escape decoding in QuotedStringTokenizer.unquote (#26467)
* fix(cli): decode Unicode escapes correctly

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2026-08-21 18:00:27 -06:00
Eunbin Son 727a7da7e4 Correct PrivateKeyProvider and CLI.loadKey Javadoc to list all supported key types (#27213) 2026-08-09 20:06:13 -06:00
Eunbin Son 18a99cd2f7 Correct Javadoc for QuotedStringTokenizer.quote(String) to reflect unconditional quoting (#27165) 2026-08-05 14:51:28 -06:00
Eunbin SonandClaude Opus 4.8 f428d0626a fix: Search for ECDSA and Ed25519 keys in default SSH key locations (#26954)
Search for ECDSA and Ed25519 keys in default SSH key locations

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-22 19:35:12 -06:00
Shubham shuklaandMark Waite b20dd0c23e Fix tests that load classpath resources via URL#getFile() (#25952)
Some tests convert classpath resources to File via URL#getFile(), which returns URL-encoded paths (e.g. %20 for spaces). This can break tests (or cause them to be silently skipped) when the workspace path contains spaces.

Use URL#toURI() for URL-to-File conversion in tests and assert resource existence so tests execute reliably across platforms.

Signed-off-by: shbhmexe <shubhushukla586@gmail.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2026-05-21 16:26:29 -06:00
strangelookingnerdandMark Waite 4a2f5f24b9 Migrate code base to Java 21 (#26075)
* Replace if-cascades with switch

* Reference to empty collection field replaced with method call (Java 5)

* Anonymous type replaced with lambda (Java 8)

* Replaced lambda with method reference (Java 8)

* Statement lambda replaced with expression lambda (Java 8)

* Loop replaced with 'Collection.removeIf()' (Java 8)

* Null check replaced with method call (Java 9)

* Statement replaced with enhanced 'switch' (Java 14)

* Use text blocks (Java 15)

* Use pattern variable (Java 16)

* Replace if-cascades with switch

* Use 'Comparator' combinator

* Null check replaced with method call (Java 9)

* Use pattern variable (Java 16)

* Use record pattern (Java 21)

* Use SequencedCollection method (Java 21)

* Replaced lambda with method reference (Java 8)

* Cleanup unused imports

* Cleanup migrations (move comments, formatting, spotbugs...)

* Remove duplicate comment

Resolve GitHub Copilot review comment

* Remove blank line that may confuse Copilot

* Inject comments into source line

Attempt to satisfy GitHub Copilot

Complains about unreachable code

* Simplify with return value of switch statement

* Use pattern matching instanceof in one more case

* Don't lose the NetBeans comment that was there before

* Remove TODO for Java 21 pattern use, implemented

* Align comments with Unicode character they describe

---------

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2026-01-23 23:31:47 -07:00
Daniel Beck efa1816322 [SECURITY-3630] 2025-12-02 13:46:19 +00:00
b0eafed55e Update dependency org.jenkins-ci:jenkins to v1.141 (#11139)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Co-authored-by: Jakob Ackermann <das7pad@outlook.com>
2025-10-04 22:12:27 +02:00
Damien 7beca3db02 Fix French translations (#11134) 2025-10-01 10:26:57 +01:00
renovate[bot] 9ba6314c66 Update dependency org.jenkins-ci:jenkins to v1.139 (#11007)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-08-21 15:47:47 -07:00
strangelookingnerdandMark Waite c33bf73f72 Migrate tests to JUnit5 (cli) (#10559)
Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2025-05-31 08:28:08 +01:00
renovate[bot] 560e57ffae Update dependency org.jenkins-ci:jenkins to v1.130 (#10376)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2025-03-05 14:43:28 -08:00
Basil Crow f6c5f6f6a5 Re-enable Checkstyle 2025-01-26 07:54:28 -08:00
Devin Nusbaum eb07f9e734 Reduce default size of diagnostic buffer for FlightRecorderInputStream from 1MiB to 1KiB (#9887) 2024-10-21 19:35:23 +01:00
Jesse Glick 15e045f03d Friendlier handling of DeploymentHandshakeException from CLI in -webSocket mode (#9591) 2024-08-30 14:26:19 +01:00
A. RegnanderandMark Waite b0baebaf88 Updated Swedish translation (#9069)
* Adding first batch of translated .properties files in Swedish

* Added new Swedish .properties files

* Updated existing Swedish .properties files

* Updated existing Swedish .properties files

* Added new Swedish .properties files

* Added more strings and changed some translated terms

* Made changes and added strings in existing files

* Added new Swedish .properties files

* Made changes and added strings in existing files

* Made changes and added strings in existing files

* Added new Swedish .properties files

* Made minor changes in existing files

* Rephrased some lines in existing files

* Added new Swedish .properties and .html files

* Added missing strings and rephrased existing ones in existing files

* Added missing strings and rephrased existing ones in existing files

* Added new Swedish .properties and .html files

* Added missing strings and rephrased existing ones in existing files

* Removed newlines before punctuation marks i html files to avoid any accidental spaces

* Rephrased some strings and made some terms consistant in existing files

* Updated various existing files

* Fixed filename typo

* Added missing punctuation, replaced copy-pasted licenses to avoid miscrediting translators of other languages

* Added missing string

* Reverted one string to keep consistency

* Removed misspelled duplicate file

* Formatted affected HTML files using Prettier

* Ran some linting scripts to format HTML files

* Added a new HTML file

---------

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
2024-04-08 23:46:09 +02:00
Bob Du 8197702484 Further reduce usages of StringUtils (#9044)
* Remove usages of StringUtils#containsIgnoreCase

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#removeStart StringUtils#removeEnd

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#defaultString

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#defaultIfBlank

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#isAlphanumeric

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils.EMPTY

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#split

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#startsWithIgnoreCase

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#countMatches

Signed-off-by: Bob Du <i@bobdu.cc>

* Remove usages of StringUtils#endsWithAny

Signed-off-by: Bob Du <i@bobdu.cc>

* fix spotbugs warning

Signed-off-by: Bob Du <i@bobdu.cc>

* Use Objects.toString

Signed-off-by: Bob Du <i@bobdu.cc>

* revert unrelated change

Signed-off-by: Bob Du <i@bobdu.cc>

---------

Signed-off-by: Bob Du <i@bobdu.cc>
2024-03-27 06:38:23 -06:00
Alexander Brandes e914bb6d76 Fill in since todos (#9077)
Signed-off-by: Alexander Brandes <mc.cache@web.de>
2024-03-26 19:44:24 +01:00
Basil Crow 3c042d12b8 Reduce usage of StringUtils (#8999) 2024-03-01 23:18:05 +01:00
Basil Crow 48f0f923d5 [JENKINS-72532] CLI -noCertificateCheck does not work with -webSocket (#8852) 2024-02-01 08:58:05 +01:00
Somasekhar dca009b286 Ssh Command modified in PrivateKeyProvider.java File in cil module (#8756) 2023-12-06 13:22:19 -07:00
Alexey IakhnenkoandAlexander Brandes 8de027d8ce Add Russian localization for CLI (#8132)
* A file with the Russian localization for cli was added.

* space removed

---------

Co-authored-by: Alexander Brandes <mc.cache@web.de>
2023-06-29 11:11:03 +02:00
Basil Crow 41edd5faf4 Remove usages of IOUtils#toByteArray (#8098) 2023-06-08 16:18:12 +02:00
Benoit Lacelle c48728d0f4 Use String#isEmpty where possible (#7690) 2023-04-08 08:04:47 -07:00
Jesse Glick 3ca2880324 Default CLI mode to -webSocket (#7605)
* Default CLI mode to `-webSocket`

* Recommend `-http` only if needed

* Simplifying `CLIActionTest`

* Avoid an extra space in proposed command if not using `-http`
2023-02-14 09:56:21 +01:00
dependabot[bot] a18de54ee6 Bump parent POM from 1.91 to 1.92 (#7422)
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-11-20 07:52:05 -08:00
Alex Blackwell 99e14251e7 Update comments for clarity (#6807) 2022-07-08 09:49:26 -07:00
Basil Crow 76e5c98dd3 Use try-with-resources where possible (#6765) 2022-07-04 17:36:33 -07:00
Basil Crow 23ab4fa0a6 Reduce usage of FileUtils (#6756) 2022-07-04 06:51:26 -07:00
Basil Crow f2eeab6469 [JENKINS-41729] Convert core .properties files to UTF-8 (#6719) 2022-07-02 15:47:35 -07:00
Basil Crow 6d179998e1 Use Java 11 methods where possible (#6700) 2022-06-30 09:31:36 -07:00
Alceu Rodrigues de Freitas Junior 9a45d8a35c Add missing Brazilian Portuguese translations (#6361) 2022-03-12 10:05:07 -08:00
Basil Crow 46603461e0 Ignore Checkstyle 10.0 and later (#6318) 2022-03-01 20:26:39 +00:00
Alceu Rodrigues de Freitas Junior 4d8be4795b Remove unused Brazilian Portuguese localizations (#6309) 2022-02-26 07:10:24 -08:00
Basil Crow 520e114ea1 Use explicit character set in tests (#6150) 2022-01-07 06:29:39 -08:00
Basil Crow e27b310065 Enable whitespace-related Checkstyle checks (#6149) 2022-01-03 08:55:03 -08:00
Basil Crow 02eecd8a49 Consistent indentation with spaces rather than tabs (#6147) 2022-01-01 11:45:56 -08:00
Basil Crow b25b45bc90 Remove trailing whitespace (#6138) 2021-12-31 07:54:03 -08:00
Basil Crow 8a5e309256 Fix DM_DEFAULT_ENCODING SpotBugs violations (#6050) 2021-12-22 20:33:59 -08:00
Basil Crow 33859a2316 Bump MINA SSHD from 2.7.0 to 2.8.0 (#6017) 2021-12-07 20:14:52 +00:00
Basil Crow d5cea69751 Prevent new SpotBugs violations from being introduced (#6015) 2021-12-06 13:52:38 -08:00
Basil Crow 74c73dd4ce Enable MissingSwitchDefault Checkstyle check (#5966) 2021-11-30 12:50:24 +00:00
dependabot[bot] e01f29ffca Bump jenkins from 1.65 to 1.67 (#5740) 2021-09-20 12:54:35 +00:00
Taehong Kim 8e942a831c Remove redundant 'continue' from conditional branches (#5717) 2021-09-20 09:44:00 +01:00
Basil Crow 632033d6ad Sort imports (#5732) 2021-09-18 09:39:42 +01:00
Basil Crow bd7c823c27 Remove unnecessary parentheses (#5576) 2021-06-25 09:23:37 +01:00
Basil CrowandDaniel Beck b8c20c6428 Fix violations of a handful of Error Prone checks (#5519)
Co-authored-by: Daniel Beck <1831569+daniel-beck@users.noreply.github.com>
2021-06-14 16:45:34 +01:00
Daniel BeckandDaniel Beck ca646b3742 Add www to jenkins.io URLs (#5517)
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
2021-05-25 20:56:16 +01:00
Basil Crow 56216ba477 Ensure files end with a newline with Spotless rather than Checkstyle 2021-05-07 19:56:27 -07:00