* When calling Nodes#setNodes, NodeListener methods should be called as required
For example, when loading a new casc configuration, it calls Nodes#setNodes, and the NodeListener methods were not called, causing listener implementations not to be notified according to the new state.
* Fix reviews
* [JENKINS-73845] Fix OperatingSystemEndOfLifeAdminMonitor endOfLifeDate displayed on first warning day
* [JENKINS-73845] Add test
* [JENKINS-73845] Improve test
* [JENKINS-73835] Do not allow builds to be deleted while they are still running
* [JENKINS-73835] Avoid redundant calls to Job.logRotate when builds complete and always call Job.logRotate after build finalization
* [JENKINS-73835] Add issue reference to RunTest.buildsMayNotBeDeletedWhileRunning
* [JENKINS-73835] Adjust DeleteBuildsCommandTest.deleteBuildsShouldSuccessEvenTheBuildIsRunning to match new behavior
* [JENKINS-73835] Run/delete.jelly should check Run.isLogUpdated, not Run.isBuilding
* [JENKINS-63343] Validate element types in RobustCollectionConverter in some cases
* [JENKINS-63343] Also validate keys and values in map entries
* [JENKINS-63343] Improve OldDataMonitor error messages and update tests
* [JENKINS-63343] Also handle implicit collection with unspecified element types
* [JENKINS-63343] Spotless
* [JENKINS-63343] Avoid rawtypes
* [JENKINS-63343] Add tests for rawtypes
* [JENKINS-63343] Adjust Javadoc for clarity
* [JENKINS-63343] Avoid ClassCastException and check handling of null in tests
* [JENKINS-63343] Fix Javadoc link by adding import
* [JENKINS-63343] List.of cannot be used with null values
* Wait for Pipelines to complete before allowing their jobs to be deleted
* Create mock Job/Run classes that use AsynchronousExecution to be able to add a regression test in core
* [JENKINS-73824] Do not repeatedly interrupt executables in ItemDeletion.cancelBuildsInProgress
* [JENKINS-73824] Delete ItemDeletionTest based on https://github.com/jenkinsci/jenkins/pull/9790#discussion_r1777727008
* Extract interfaces for objects to be used through the executors widget
This is required for CloudBees CI HA support: we provide alternate implementations of these interfaces to represent computers and related objects that exist in different physical replicas of the same logical instance. This allows to be build an aggregated view of computers and executors, some local, some remote.
* Fix Deprecated annotation
* Missing @Override annotations
* Missing @since TODO
* No longer true according to AbstractSubTask javadoc
* Restore old signature for compatibility
* Fix reviews
* Javadoc
* Typo
* Fix inconsistency between hasOfflineCause and getOfflineCauseReason
* Remove default implementation of ITask#getUrl
* Provide default impl in SubTask for compatibility
* Mark as CheckForNull
* Spotbugs
* ComputerSet#getComputers returns a collection that is sorted by name
* Missing Override
* Move permission declaration to the right place, closer to usage
* Introduce SaveableListener#onDeleted
Usually `Saveable` objects are written, but it can happen on occasion that they get deleted, and it wasn't generating an event for every case.
This provides a more fine-grained event that can be handled by implemented listeners.
In my case, I have a use case in CloudBees CI where I need to clear a cache entry when a Saveable gets deleted from disk.
* Spotless
* Explicitly test that the user that has performed the change can be obtained from the Saveable listener.
* [JENKINS-60866] Use JSON#parse to process codemirror-config argument
* Add backward compatibility for most common setting
* Integrate fixed antisamy-markup-formatter to pass test
* Fix JS and revert unnecessary antisamy-markup-formatter update
How do we have a billion different linters and not one did tell me
I'm redefining a variable?
* Remove comment
---------
Co-authored-by: Daniel Beck <daniel-beck@users.noreply.github.com>
Co-authored-by: Basil Crow <me@basilcrow.com>
* Introduce HistoricalBuild interface
This allows to display Run-like objects in build history without having concrete Run present in the Jenkins instance.
* Remove BuildHistoryWidget#entries.jelly
* JDK17 level
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
---------
Co-authored-by: Jesse Glick <jglick@cloudbees.com>
Jesse Glick