Commit Graph
4317 Commits
Author SHA1 Message Date
kohsuke 1b3c1f92fd [HUDSON-5391] Fixed the infamous Turkish bug.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26650 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-28 21:38:01 +00:00
kohsuke af12705d7a clarifying
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26643 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-28 20:30:17 +00:00
kohsuke 68edd4f804 [FIXED HUDSON-5391] in 1.344. we should be case insensitive but case preserving.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26640 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-28 19:36:52 +00:00
mindless eade4cca65 [FIXED HUDSON-2313] Show which plugins have already been upgraded in Plugin Manager.
Also some css cleanup in this area.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26639 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-28 18:09:38 +00:00
mindless 64856dc78e whitespace, javadoc typo fix
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26636 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-28 17:52:32 +00:00
kohsuke 9e14a89184 [HUDSON-833] formalized the QueueSorter.
This is a binary incomatpible change from the previous QueueSortingHandler, but given that QueueSortingHandler used one of the private classes in the method signature, I don't see how anyone could have implemented this extension point, so in practice this change shouldn't break any plugin (certainly not any plugins hosted in hudson-ci.org, according to my grep.)

I'll implement a plugin that shows how this extension point can be used, and that will mark this issue as fixed.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26610 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-27 23:54:29 +00:00
kohsuke fa2e85e77a don't treat the lack of display name as a fatal error, as most initialization tasks don't have any user-visibility anyway.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26609 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-27 23:22:19 +00:00
kohsuke bc66945943 allow InterruptedException to be forwarded
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26482 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-27 02:31:39 +00:00
kohsuke d330573bc4 added default implementations of TestResultParser.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26481 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-27 02:21:52 +00:00
kohsuke 31a54f38f6 avoid double invocation of updateTransientActions by moving it to doConfigSubmit.
Discussion at http://n4.nabble.com/Bug-getProjectAction-is-always-called-twice-tp1294814p1294814.html

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26479 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-27 00:01:02 +00:00
kohsuke 0f650fc807 Auto-detect if Hudson is run in Solaris <a href="http://www.sun.com/bigadmin/content/selfheal/smf-quickstart.jsp">SMF</a>
and provide restart capability.
    (<a href="http://n4.nabble.com/Self-restart-not-available-when-running-as-Solaris-SMF-tp1289605p1289605.html">report</a>)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26478 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-26 23:50:08 +00:00
kohsuke 9b9e9831f5 fixed JDK6 dependency
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26476 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-26 23:35:41 +00:00
kohsuke 5025ab3918 eliminated redundant check --- let the caller do it.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26475 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-26 23:27:26 +00:00
jglick 24e03ccfbb @since appeared to be wrong.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26447 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-26 17:36:29 +00:00
kohsuke 196276f204 [HUDSON-5383] improving the XStream converters so that a linkage error in a plugin doesn't cause catastrophic start up failure.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26445 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-26 16:54:15 +00:00
kohsuke 1aaf1be3e2 [FIXED HUDSON-5382] in 1.343. NPE in the update center job if the container authentication is used, because ServletRequest is no longer valid from another thread after the request handling is completed.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26442 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-26 16:22:22 +00:00
kohsuke 92ca98c4d6 Merged revisions 24854,24862,24946,25411,25418-25419,25478,25699,25701,25770,25832,25834,26401-26404 via svnmerge from
https://www.dev.java.net/svn/hudson/branches/test-result-refactor

........
  r24854 | bshine | 2009-12-22 12:52:32 -0800 (Tue, 22 Dec 2009) | 82 lines
  
  Generalize the junit-specific TestResult class into AbstractTestResult,
  and allow plugins to contribute test result parsers that generate
  AbstractTestResult subclasses.
  
  In order to support the increasing variety of test result file formats, we
  have added two extension points:
  
   * AbstractTestResult: a class that represents a general concept of a test
     result, without any language or implementation specifics.
  
   * AbstractTestResultParser: an API for parsing test result files and
     producing an instance of a concrete subclass of AbstractTestResult
  
   
   AbstractModelObject
      \
       TestObject 
          \
           AbstractTestResult is-a ExtensionPoint
                 \
                  |-- CaseResult 
                  |
                  |-- SimpleCaseResult
                  |
                  |-- TabulatedResult
                        \
                         |-- ClassResult
                         |
                         |-- MetaTabulatedResult
                               \
                                 |-- TestResult 
                                 |
                                 |-- PackageResult
  
  
   AbstractTestResultParser is-a ExtensionPoint
      \
       JUnitParser
  
  We have refactored the JUnit result publishing system so that it is "just"
  a subclass of AbstractTestResult. We have promoted functionality into
  AbstractTestResult from TestResult; we have also promoted jelly resources
  from TestResult up to AbstractTestResult. Together, these changes make it
  possible -- without much code -- to add a test result parser and a test
  result publisher that can participate in the test result ecosystem. See,
  for instance, TrivialTestResult, with its two supporting classes,
  TrivialTestResultAction and TrivialTestResultRecorder.
  
  We have moved the format-agnostic classes in the test result system into
  the hudson.tasks.test package, from hudson.tasks.junit:
     TestObject
     MetaTabulatedResult
     TabulatedResult
  
  We have attempted at every step to preserve backwards compatibility both
  with the existing APIs and with test results stored by earlier versions of
  Hudson. Numerous tests verify that the old APIs and historical data are
  still readable; all of the tests in hudson.tasks.junit operate on stored
  builds and test results created by Hudson around version 1.320. These
  tests have been created and expanded to exercise the HTML ui and the XML
  api of the test result publishing system, as well as the underlying java
  logic.
  
     hudson.tasks.junit.CaseResultTest
     hudson.tasks.junit.JUnitParserTest
     hudson.tasks.junit.JUnitResultArchiverTest 
     hudson.tasks.junit.TestResultLinksTest 
     hudson.tasks.junit.TestResultPublishingTest   
     
  This checkin also includes several smaller changes that were enacted in the course of this work: 
     Added convenience/utility methods
        - HudsonTestCase.java
     
     Added a read-only textbox.
        - core/src/main/resources/lib/form/readOnlyTextbox.jelly
  
     Added a standalone builder that touches all files in the workspace.
        - TouchBuilder.java
  
     Added a test: testUnwrappedLongString
        - src/test/java/hudson/model/ApiTest.java
........
  r24862 | bshine | 2009-12-22 17:30:04 -0800 (Tue, 22 Dec 2009) | 1 line
  
  Recreate the hudson.tasks.junit.TestObject class, and adapt the TestResultAction.Data class to be friendly to the refactoring. This makes the claim plugin and the junit-attachments plugin compile and pass tests against this branch.
........
  r24946 | bshine | 2009-12-24 21:59:14 -0800 (Thu, 24 Dec 2009) | 1 line
  
  Getting rid of some TODOs that don't apply anymore. The TODOs that remain are meaningful.
........
  r25411 | kohsuke | 2010-01-05 18:14:15 -0800 (Tue, 05 Jan 2010) | 3 lines
  
  Cosmetic change. It's not necessary to define our own constant for empty list when there's already one in JDK.
  
  I also think creating and wasting singleton list as needed is probably better use of memory than having a singleton list tied in memory for every CaseResult. It improves cognitive overhead for people reading the code, and modern GCs are very good at handling short-lived objects, and I don't see this method called in a busy loop.
........
  r25418 | kohsuke | 2010-01-05 18:37:17 -0800 (Tue, 05 Jan 2010) | 1 line
  
  pushed the get/setDescription implemention up to the AbstractTestResultAction. I believe the default implementation is sufficient for most purposes, and typical subtypes don't want to bother with the details that descriptions are actually persisted by the owning Action instead of in TestObjects.
........
  r25419 | kohsuke | 2010-01-05 18:59:29 -0800 (Tue, 05 Jan 2010) | 1 line
  
  we should allow the parse method to be called outside of the build, so this should be TaskListener.
........
  r25478 | kohsuke | 2010-01-07 11:44:34 -0800 (Thu, 07 Jan 2010) | 14 lines
  
  The ExtensionPoint interface primarily serves as a marker to call attention of the plugin developers as to where to hook into Hudson. Since the act of implementing AbstractTestResultParser naturally make them to implement AbstractTestResult, I'm removing the ExtensionPoint marker from this abstract class.
  
  The all() method is removed after the following discussion:
  
  >> - I propose we remove AbstractTestResult.all(). I don't think being  
  >> able
  >> to enumerate AbstractTestResult subtypes buy us anything, since those
  >> can only be instantiated by parsers that intimately know how to
  >> instantiate them properly. Or did I miss the purpose of this?
  > 
  > I put in the all method because it was suggested by the wiki:
  > "You also need to define the static "all" method..."
  > http://wiki.hudson-ci.org/display/HUDSON/Defining+a+new+extension+point
  > so I don't have a problem with removing it.
........
  r25699 | bshine | 2010-01-11 16:34:12 -0800 (Mon, 11 Jan 2010) | 1 line
  
  Removed a test that exercised AbstractTestResult.all(), because that API has been removed.
........
  r25701 | bshine | 2010-01-11 17:05:40 -0800 (Mon, 11 Jan 2010) | 1 line
  
  Don't test getDescription() on a TrivialTestResult because the TrivialTestResult doesn't actually implement a description.
........
  r25770 | bshine | 2010-01-13 11:52:27 -0800 (Wed, 13 Jan 2010) | 1 line
  
  Added a failing test to demonstrate bug HUDSON-5246, inter-build diffs for junit test results are wrong.
........
  r25832 | bshine | 2010-01-14 13:50:15 -0800 (Thu, 14 Jan 2010) | 1 line
  
  The id field was accidentally declared here; it was also declared in hudson.tasks.test.TestObject. This id field here is always hidden by the id field in the more-concrete TestObject. Therefore, I'm removing this field.
........
  r25834 | bshine | 2010-01-14 13:55:10 -0800 (Thu, 14 Jan 2010) | 5 lines
  
  Fixes bugs with getPreviousResult:
  HUDSON-5269 TestResult.getPreviousResult returns null when it shouldn't
  HUDSON-5246 test-result-refactor branch: inter-build diffs for junit test results are wrong 
........
  r26401 | kohsuke | 2010-01-25 17:24:51 -0800 (Mon, 25 Jan 2010) | 7 lines
  
  renamed:
   AbstractTestResultParser -> TestResultParser
   AbstractTestResult -> TestResult
  
  This discussion is in http://n4.nabble.com/Review-requested-Test-Result-Refactoring-td978100.html#a978100
  
  The conclusion of this renaming proposal isn't clear, but I'm assuming it's OK.
........
  r26402 | kohsuke | 2010-01-25 17:27:57 -0800 (Mon, 25 Jan 2010) | 1 line
  
  elsewhere in Hudson it's the "display name" that indicates a human readable name that programs don't try to interpret.
........
  r26403 | kohsuke | 2010-01-25 17:31:38 -0800 (Mon, 25 Jan 2010) | 1 line
  
  typo
........
  r26404 | kohsuke | 2010-01-25 17:35:41 -0800 (Mon, 25 Jan 2010) | 1 line
  
  doc improvement.
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26406 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-26 01:49:47 +00:00
kohsuke 705ff30e21 slightly improved the error diagnostics
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26392 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-25 22:12:26 +00:00
kohsuke e87afa6012 improving the logging
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26389 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-25 21:02:31 +00:00
mindless ebccd71e73 [FIXED HUDSON-5049] check oneOffExecutors in getIdleStartMilliseconds().
No idle executors in this list, so this just ensures we return a future time if
there is a busy one-off task but all other executors are idle.
Added javadoc to clarify what countExecutors() returns.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26365 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-25 18:11:32 +00:00
kohsuke 12a341617a [FIXED HUDSON-5373] in 1.343.
Allow the administrator to control the host names via a system property "host.name" per slave, in case auto-detection fails.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26364 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-25 17:03:52 +00:00
jglick 56e79ce28e [HUDSON-4876] Better diagnostics for verifyRestartable in case of fallback lifecycle impl.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26363 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-25 16:55:06 +00:00
jglick 0935d962fc [HUDSON-4876] Improving RestartNotSupportedException diagnostics.
Getting the following in 1.336 on Solaris, which does not tell you what is actually wrong (what subclass does not override restart?):
hudson.lifecycle.RestartNotSupportedException: Restart is not supported in this running mode.
	at hudson.lifecycle.Lifecycle.verifyRestartable(Lifecycle.java:161)
	at hudson.model.Hudson.safeRestart(Hudson.java:2928)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26362 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-25 16:41:11 +00:00
mindless b196662454 [FIXED HUDSON-2210] Move form to adjust logging levels to its own page
and include table of configured levels.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26344 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-24 18:08:14 +00:00
kohsuke f73f679c41 fixed NPE:
java.lang.NullPointerException
	at hudson.ProxyConfiguration.open(ProxyConfiguration.java:112)
	at hudson.FilePath.installIfNecessaryFrom(FilePath.java:532)
	at hudson.plugins.hadoop.PluginImpl.createHadoopVM(PluginImpl.java:109)
	at hudson.plugins.hadoop.SlaveStartTask.call(SlaveStartTask.java:58)
	at hudson.plugins.hadoop.SlaveStartTask.call(SlaveStartTask.java:41)
	at hudson.remoting.UserRequest.perform(UserRequest.java:104)
	at hudson.remoting.UserRequest.perform(UserRequest.java:48)
	at hudson.remoting.Request$2.run(Request.java:270)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
	at java.util.concurrent.FutureTask.run(FutureTask.java:138)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26276 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-23 00:58:32 +00:00
kohsuke aefd3fc8b3 [FIXED HUDSON-5351] job description set via the remote API wasn't persisted.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26255 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-22 16:39:34 +00:00
mindless 40c763194c [HUDSON-5049] patch from nairb774 to check for flyweight tasks in Computer.isIdle()
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26230 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-22 00:31:34 +00:00
kohsuke 61a1858dae exposing FileVisitor and DirScanner so that the calling app can fine tune the archiving process.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26226 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-21 23:25:14 +00:00
kohsuke b0df11332a 1.MULTIUPDATE was integrated as of 1.333, so replacing those
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26207 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-21 21:44:42 +00:00
kohsuke 858ab21bd8 UpdateCenter.neverUpdate is deprecated as of 1.333
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26206 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-21 21:39:45 +00:00
kohsuke fa13013ca8 Merged revisions 26194 via svnmerge from
https://svn.dev.java.net/svn/hudson/branches/rc

........
  r26194 | kohsuke | 2010-01-21 11:38:14 -0800 (Thu, 21 Jan 2010) | 2 lines
  
      Fixed a regression in the remote API in 1.341. 
........


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26195 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-21 19:38:56 +00:00
manuel_carrasco cdf17e99ce Spanish translations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26182 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-21 12:14:29 +00:00
kohsuke 6834f62366 added one more extension hook for subtypes
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26135 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-20 21:19:45 +00:00
kohsuke 0516329547 /tmp space monitoring didn't work if /tmp is filled up completely.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26106 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-19 22:52:03 +00:00
kohsuke 2004958ec0 added custom exception type
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26103 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-19 21:03:07 +00:00
kohsuke dc6db9328b allow arbitrary exception. The whole point of this class is to deal gracefully with a problem, so we might just as well let the subtypes knowingly throw them.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26100 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-19 18:50:04 +00:00
manuel_carrasco ba373c6cec more Spanish translations
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26080 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-19 12:34:16 +00:00
mindless 00bc8ce5c5 [FIXED HUDSON-2543] don't update lastStable/lastSuccessful symlinks until final
build result is known (after post-build actions).


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26069 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-18 17:10:36 +00:00
ashlux 505e422e85 [FIXED HUDSON-5247] The hudson.model.Run.ArtifactList.treeCutoff property should not limit the number of artifacts shown by the API.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@26036 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-17 17:35:48 +00:00
kohsuke cb88b13b66 [FIXED HUDSON-5164]
Infer the default e-mail address more smartly with user IDs like "DOMAIN\user" (often seen in Windows)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25964 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-16 15:57:48 +00:00
kohsuke b39cc4d55e [FIXED HUDSON-5155] in 1.342. The root cause of the problem is that the backing byte[] of ByteBuffer can be bigger than the actual current content that's on it --- in the case of the reporter he got byte[3] as the backing buffer when only two bytes of it is in use.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25962 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-16 15:23:55 +00:00
kohsuke e816e08552 missing @DataBoundConstructor
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25961 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-16 15:13:00 +00:00
mindless b4ee14c5b8 [HUDSON-5236] remove Dependency.getBuildActions API, as its computation may
overlap with shouldTriggerBuild.  Instead, add List<Action> parameter in
shouldTriggerBuild which impl can add Actions to before returning boolean.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25878 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-15 20:22:17 +00:00
kohsuke 6882917f7b <f:textbox> can take arbitrary attributes now to be added to the resulting <input> element.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25876 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-15 19:25:36 +00:00
jglick fbda18e384 [FIXED HUDSON-5296] Remote launcher failed to print any of the commands it was running to the listener the way the local launcher does.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25870 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-15 18:41:51 +00:00
kohsuke e464b05625 formatting changes
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25864 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-15 15:37:52 +00:00
kohsuke f94a33dd15 introduced the descriptor subtype for ListViewColumn.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25863 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-15 15:36:06 +00:00
kohsuke 9209d4df5e use a proper Saveable to make the list view column change live
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25862 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-15 15:24:44 +00:00
kohsuke e241e08b3e Simplified the code to be a better example of what a plugin should do. Creating a singleton descriptor instance is not recommended.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25861 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-15 15:18:52 +00:00
kohsuke 7e4d343b4c [FIXED HUDSON-5061] in 1.342. Avoids NPE even without having a help from a plugin. Also added a note about this contract violation of the newInstance method.
git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@25857 71c3de6d-444a-0410-be80-ed276b4c234a
2010-01-15 15:02:13 +00:00