Commit Graph
32590 Commits
Author SHA1 Message Date
Wadeck Follonier 188470340f Improve JavaDoc formatting 2018-05-06 12:16:17 +02:00
Wadeck Follonier c79f3f719c [JENKINS-51158] Improve Root URL validation
- remove the bug for ipv6
- remove the support of query that was not expected
- add support for trailing dots
- add lots of unit tests
2018-05-06 12:10:16 +02:00
surenpi a760a37551 Add Chinese translation for setupWizardConfigureInstance page 2018-05-06 17:59:41 +08:00
Kohsuke Kawaguchi 7250d8b875 [maven-release-plugin] prepare for next development iteration 2018-05-06 02:34:22 -07:00
Kohsuke Kawaguchi 23c44bdbfa [maven-release-plugin] prepare release jenkins-2.120 jenkins-2.120 2018-05-06 02:34:21 -07:00
Hangsu Ma 081e400a5b [FIXED JENKINS-14713] make Cancel independent from Build permission (#882)
A script in the confluence page below will make sure configuration is
compatible after this change:
https://wiki.jenkins-ci.org/x/fAAhB
2018-05-05 21:27:15 +02:00
aviadatsnyk 8ede53387e [JENKINS-32778] - Prevent extracting archived plugins outside of target path (#3402) 2018-05-05 14:32:34 +02:00
Oleg Nenashev 4278461c90 Merge pull request #3408 from batmat/JENKINS-50969
[JENKINS-50969] core site build is broken, needed for core taglibs reference
2018-05-05 14:27:52 +02:00
Wadeck Follonier e7eec1cbe6 [JENKINS-51064] Lenient URL validator for Root URL (#3415)
* [JENKINS-51064] Lenient URL validator for Root URL
- especially with the TLDs
- more test cases

* add blank line

* Adjust comment

* Correction typo
2018-05-04 16:03:22 -04:00
Matt Sicker e229f37dd9 JENKINS-13128: Preserve copied file permissions and mtime (#3400)
* JENKINS-13128: Preserve copied file permissions and mtime

This fixes a bug where files copied locally do not preserve file permissions or last modification time.

* Use IO utility methods for exception handling

* Fix invalid path exception propagation

* Revert hudson.Util
2018-05-04 15:36:33 -04:00
Jeff Thompson a9eafdb973 [JENKINS-50412] Fingerprints logs should be less verbose (#3373)
* JENKINS-50412 - Fingerprints logs should be less verbose

Eliminate the logging line that says
possibly trimming /var/jenkins_home/fingerprints/[...]
This line fills up the fingerprints log file with repetitive, useless information.
The operation it calls provides its own logging that can be turned on if detailed
logging is actually needed instead of running this one repeatedly.

Also, while in the area, convert a couple of FileFilter inner classes to lambdas
and inline them. This reduces unnecessary boilerplate and improves clarity.

In order to make this change testable, I elected to remove the final restriction on the
class and annotate the class as restricted. This allows me to create unit tests for
this change and also verify existing capability at the appropriate level.

* Watch out for varying line endings.

Use a reliable check.

* Correct a few minor issues caught in review.

* Change to correct access modifier.
2018-05-04 14:51:12 -04:00
Wadeck Follonier a03254b99f Admin monitor message: separation between content and display (#3416)
* Better separation between content and display
- also put the version for the RootUrlNotSetMonitor and the HttpResponses new method

* Add blank line
2018-05-04 20:28:59 +02:00
Oleg Nenashev 541c31f75c Merge branch 'master' into JENKINS-50969 2018-05-04 20:22:15 +02:00
Wadeck Follonier 2b498df38d uppercase the token 2018-05-04 17:34:07 +02:00
Wadeck Follonier 480555dc2f Adjust UI after discussion with Devin
- trigger the confirm message if someone change an existing token name (for the rename) and does not click on Save / Apply
- improve the ignore/force dirty mechanism
- display the warning message about the temporary aspect of the token plain text only *after* the generation
- change "Save" to "Generate" for the new token
2018-05-04 17:33:22 +02:00
Wadeck Follonier 4ff76be14f Change the warning message 2018-05-04 16:46:43 +02:00
Devin Nusbaum a3d5985190 Remove unnecessary dash
(Wadeck and I want to see how the on-GitHub PR editing features work in case they are useful for proposing grammar changes)
2018-05-04 10:21:07 -04:00
Oleg Nenashev a4a1355f51 Merge pull request #3420 from jglick/gradle-plugin-under-test-JENKINS-51062
[JENKINS-51062] Extend ClassFilterImpl.isLocationWhitelisted Maven-oriented exclusions to plugin under test during Gradle builds
2018-05-04 11:18:16 +02:00
Wadeck Follonier 3395141650 Address Devin's comment
- adjust the way the stats are used for the monitoring page
- correct the re-creation of legacy token on restart
2018-05-04 11:04:49 +02:00
Jesse Glick d1eaafb28b Merge pull request #3405 from jglick/InstallState-madness-redux
Simplify Jenkins.installState serial form to avoid relying on readResolve
2018-05-03 14:42:36 -04:00
Jesse Glick b14ba46a14 [JENKINS-51062] Extend ClassFilterImpl.isLocationWhitelisted Maven-oriented exclusions to plugin under test during Gradle builds. 2018-05-03 13:57:28 -04:00
Jesse Glick 101f972d41 Merge branch 'master' into InstallState-madness-redux 2018-05-03 10:43:24 -04:00
Jesse Glick 3fb17fb0bb [JENKINS-50692] [INFRA-1571] #3394: JEP-305 Incrementals in core 2018-05-03 10:13:39 -04:00
Jesse Glick 3465da4764 Merge pull request #3419 from dwnusbaum/JENKINS-9104-test-fix
Fix test failure by cleaning up static state after tests
2018-05-02 18:47:23 -04:00
Devin Nusbaum 828a7e0225 Fix test failure by cleaning up static state after tests 2018-05-02 16:28:30 -04:00
Baptiste Mathus ddbc4bbce7 Merge pull request #3412 from batmat/add-version-and-batch-mode
Set ATH mvn run: set batch mode, and show versions
2018-05-01 17:22:35 +02:00
Wadeck Follonier 0c3b5a1b7d Merge remote-tracking branch 'origin/JENKINS-32442-32776_HASHED_TOKEN' into JENKINS-32442-32776_HASHED_TOKEN 2018-05-01 09:50:42 +02:00
Wadeck Follonier 7d1f232504 Better usage of Optional 2018-05-01 09:50:24 +02:00
Kohsuke Kawaguchi b094f9c2eb Merge branch 'master' of github.com:jenkinsci/jenkins 2018-04-30 12:03:52 -07:00
Kohsuke Kawaguchi a669e240af [maven-release-plugin] prepare for next development iteration 2018-04-30 11:56:44 -07:00
Kohsuke Kawaguchi 0a7543c443 [maven-release-plugin] prepare release jenkins-2.119 jenkins-2.119 2018-04-30 11:56:44 -07:00
Wadeck Follonier 3280de517a Merge branch 'master' into JENKINS-32442-32776_HASHED_TOKEN 2018-04-30 10:33:59 +02:00
Baptiste Mathus f94ecf2c9f Set ATH mvn run: set batch mode, and show versions 2018-04-30 09:53:49 +02:00
Andy Neebel 701485e86b [JENKINS-9104] Move process killing veto checks to master (#3357)
* [JENKINS-9104] Add a test method to show that vetos aren't processed on slaves

* Move the veto check to always run on the master

* Add a flag to skip master call if empty list
2018-04-29 12:50:30 +02:00
Wadeck Follonier 79ec930a8e [JENKINS-49839] correct annotation check (#3321)
- also correct a bad annotation in Run
2018-04-29 00:58:35 +02:00
Oleg Nenashev c7bc10341f Merge pull request #3409 from daniel-beck/at-since-201804
Cleanup since Javadoc tags
2018-04-27 21:16:46 +02:00
Daniel Beck fcf9b676c2 Adapt to base64 encoded SHA-512 checksums 2018-04-27 19:04:26 +02:00
Wadeck Follonier 38313e4fc2 Separate the statistics from the token store
- different file for better versioning / synchronization
- ability using a configuration to avoid completely the statistics
- add unit / integration tests
- adjust the configuration page
2018-04-27 19:01:35 +02:00
Baptiste Mathus b3c5c402e6 [JENKINS-50969] core site build is broken, needed for core taglibs reference
The special old module for doxia seems not needed.
I suspect that it is because since 2012 when it was released, the Markdown
support got done in standard.

IIUC this was pulling in some very old doxia versions, which was
incompatible with maven-fluido-skin which I needed to bump from current
1.3.0 to 1.7 for https://github.com/jenkins-infra/core-taglibs-report-generator
to work again.
2018-04-27 14:14:51 +02:00
Baptiste Mathus 621ef567b2 Merge pull request #3410 from batmat/bump-to-parent-1.41-add-junit-to-depMgmt
Pick-up parent pom 1.41 adding junit to dependencyManagement
2018-04-27 13:59:50 +02:00
Baptiste Mathus 7a986fb642 Remove junit totally from depMgmt 2018-04-27 11:03:42 +02:00
Oleg Nenashev b15c21d5b0 Merge pull request #3407 from Jochen-A-Fuerbacher/fixEndcoding
Fixed encoding in German translation (log recorder levels)
2018-04-27 10:47:47 +02:00
Baptiste Mathus 1866fe1fdd Pick-up parent pom 1.41 adding junit to dependencyManagement 2018-04-27 10:18:39 +02:00
Daniel Beck 6e037bfa39 Cleanup since Javadoc tags 2018-04-26 17:21:30 +02:00
Wadeck Follonier 17b94a044a [JENKINS-31661] Check the root url (Admin monitor + Wizard) (#3082)
* [JENKINS-31661] Add an administrative monitor to check the root url configuration
- add the monitor + test

* - corrections requested by Oleg in code review

* - add a field to fill during SetupWizard for the rootUrl (default value using javascript but editable)
- WIP : missing the translation

* - revert whitespace change

* - little refactoring of js methods

* - translation added

* - modification requested during PR by Jesse

* - renaming proposed by Keith

* - rework to have a new page in the SetupWizard for the root URL

* Correct relevant non-conflicting merge changes

* - in case of skip => also skip the instance configuration
- terminate => finish (+ uppercase)
- replace double single quotes
- add help message in the wizard to inform admins
- correct the installState serialization problem
- update working (admin monitor + wizard)

* address Daniel's comment
- skip all steps will show two messages instead of one (like before when clicking on skip twice)
- skip => not now
- remove margin and adjust padding for the wizard forms
- add the "if possible"

* address Arnaud's comment on the sauter vs passer

* address Liam's comment

* correct previous commit typo

* correct previous commit typo (2)

* add blank end line

* address James' comment

* address Daniel's comment

* address Devin's comment
- implement error management in the wizard
- provide different message in the monitor in case of null / invalid url
- add an helper to validate URL (even with _ in domain)
- add @Restricted

* - also update the monitor test to be consistent with its new behavior

* address Devin's comments

* correct header files

* include relevant classes for the url validation from commons-validator:1.6

* Move Apache classes in a more standard package
2018-04-26 16:58:29 +02:00
Daniel Beck 6dc32977fc Add support for SHA-256/512 in update site metadata 2018-04-26 16:31:49 +02:00
Jochen Fürbacher 3a124bfdb6 Fixed regression of ed8d905 2018-04-26 12:28:55 +02:00
Daniel Beck dfdc4bc305 Merge branch 'security-stable-2.107' into security-master 2018-04-26 12:08:17 +02:00
Daniel Beck a5777e5058 Merge branch 'stable-2.107' 2018-04-26 12:08:06 +02:00
Daniel Beck fbea395ed7 Merge branch 'stable-2.107' into security-stable-2.107 2018-04-26 12:07:15 +02:00