Commit Graph
32590 Commits
Author SHA1 Message Date
James Nord 553ca57a63 Adding test coverage for BuildAuthorisationToken
I could not see any test coverage for BuildAuthorisationToken so added
some.
2018-03-23 14:21:17 +00:00
Wadeck Follonier d95766fb09 - change package (better hierarchy)
- correct small text when instance is null
- add monitor
2018-03-23 15:18:35 +01:00
Jesse Glick 115612bbf5 [JENKINS-39495] Defend against a null serialized ParametersAction.parameters.
(cherry picked from commit ff34532460)
2018-03-23 14:54:56 +01:00
Berno Langer 1400918dda [JENKINS-48821] - Don't forget estimated duration of asynchronous jobs (#3329)
* Don't forget estimated duration of asynchronous jobs.

When jobs are executed, the estimated duration is calculated, memorized
and reseted when the job is finished.

But when the job is executed asynchronously (e.g. as for pipeline
scripts), the execution is just triggered. Therefore the estimated
duration should remain - and not be reseted after triggering.

JENKINS-48821: Time remaining for all pipeline jobs is N/A
JENKINS-49616: Estimated time remaining NA

* Reset cached estimated duration also when asynchronous job ends.

(cherry picked from commit 3fc392108a)
2018-03-23 14:54:09 +01:00
Akbashev Alexander 9b69208f7e Do not copy all build numbers in case of descending search (#3228)
[JENKINS-50056] - Do not copy all build numbers in case of descending search

(cherry picked from commit 6232491965)
2018-03-23 14:52:08 +01:00
Piush 9fb75bb4c6 [JENKINS-29470] - Prevent NPE in AbstractProject.checkout when agent disconnects during the build (#3094)
[JENKINS-29470] - Prevent NPE in AbstractProject.checkout when agent disconnects during the build

(cherry picked from commit b0c5a86add)
2018-03-23 14:46:31 +01:00
Daniel Beck ff59e4bf14 [JENKINS-49642] Fix proxy view recursion
(cherry picked from commit 9054e2211e)
2018-03-23 14:45:18 +01:00
Oleg Nenashev 805a7ab57d [JENKINS-49596] - Update Winstone to 4.1.2 (#3307)
* [JENKINS-49596] - Update Winstone to 4.1.1

* [JENKINS-49596] - Pick 4.1.2 with extended session eviction defaults

(cherry picked from commit 852ecdc5f2)
2018-03-23 14:44:29 +01:00
Carl-Frederik Hallberg e43f90b256 [JENKINS-49788] Added ConcurrentLinkedQueue to whitelisted classes. (#3315)
(cherry picked from commit e5f61e29e2)
2018-03-23 14:33:20 +01:00
Oliver Gondža 8c975f11c5 [FIX JENKINS-30909] Make sure queue is persisted reliably (#3244)
* [FIX JENKINS-30909] Make sure queue is persisted reliably

* Fix tests on Windows

* Ensure Saver is thread-safe

(cherry picked from commit 72a7529a11)
2018-03-23 14:32:33 +01:00
Oleg Nenashev 96c52d901b Merge pull request #3303 from recena/JENKINS-49634
[JENKINS-49634] Wrong escaping of quotes in the Setup Wizard

(cherry picked from commit dcb1bcd540)
2018-03-23 14:31:10 +01:00
Oleg Nenashev d09fc3a552 Merge pull request #3286 from vStone/feature/JENKINS-49496-dutch-translation-security-fix
[JENKINS-49498]: Fix poorly translated sign-up string (dutch)

(cherry picked from commit 59bfe03ebe)
2018-03-23 14:28:16 +01:00
Oleg Nenashev d5a84875f5 Merge pull request #3363 from Wadeck/JENKINS-50324_CLI_LOGOUT
[JENKINS-50324] User without READ cannot logout
2018-03-23 13:05:42 +01:00
Oleg Nenashev 63a5803162 Merge pull request #3362 from jglick/SystemProperties-JENKINS-46386
[JENKINS-46386] Make SystemProperties safe to call from agent JVMs
2018-03-23 13:04:28 +01:00
Oleg Nenashev 9e667a2f4f Merge pull request #3359 from jglick/ProxyException-JENKINS-50237
[JENKINS-50237/JENKINS-49618] Pick up Remoting 3.19 with automatic ProxyException; and avoid BuildException to begin with
2018-03-23 13:02:41 +01:00
Jesse Glick e068f242ad Try to prevent NullPointerException’s during Jenkins shutdown. 2018-03-22 14:55:11 -04:00
Baptiste Mathus 32bac4b336 save() if fields were touched 2018-03-22 17:23:42 +01:00
Baptiste Mathus 36fe2399e3 Log always as INFO minimum, WARNING if values were changed 2018-03-22 17:19:15 +01:00
Baptiste Mathus 770c70a90d Better javadoc 2018-03-22 16:37:33 +01:00
Baptiste Mathus 34bff661f2 Lambda-ify 2018-03-22 16:37:23 +01:00
Baptiste Mathus 819aeeb9b9 Remove the whole UI for buildsDir and workspaceDir 2018-03-22 16:36:58 +01:00
Baptiste Mathus fa9326c652 workspaceDir & buildDir not modifiable anymore from the UI! 2018-03-22 16:35:44 +01:00
Baptiste Mathus 99734308fe Make package visible to avoid public usage 2018-03-22 16:34:45 +01:00
Oleg Nenashev 52abfad941 [JENKINS-50237, JENKINS-49618] - Update Jenkins Remoting to 3.19 2018-03-22 14:28:37 +01:00
Baptiste Mathus cce49e7b3c [JENKINS-50164] Remove UI option to modify WS and builds locations
Add necessary code to fix tests, and make the UI readonly.
2018-03-22 12:23:17 +01:00
Baptiste Mathus 7961badd9a [JENKINS-50164] Remove UI option to modify WS and builds locations
Test (almost) only: checking the previous behaviour is preserved, and
the system property is accounted for when set.
2018-03-22 12:20:48 +01:00
Wadeck Follonier 41a0d6388d add migration test using localData
- also add test on the generate api call
2018-03-22 11:24:31 +01:00
Wadeck Follonier b5ed977bbc [JENKINS-50324] User without READ cannot logout
- or even ask who they are
2018-03-22 09:13:11 +01:00
Jesse Glick d3f5346b0f Merge branch 'SystemProperties-JENKINS-46386' into VirtualFile-JENKINS-49635 2018-03-21 16:28:23 -04:00
Jesse Glick 7948315142 [JENKINS-46386] Make SystemProperties safe to call from agent JVMs. 2018-03-21 16:24:26 -04:00
R. Tyler Croy 3b5c715ae0 Merge pull request #3350 from daniel-beck/JENKINS-49269-2
[JENKINS-49269] Add ATH SmokeTest runs to the core build
2018-03-21 06:26:17 -07:00
Wadeck Follonier a7a3cc3f88 change from javascript   to the correct jelly tag thx to Daniel 2018-03-21 14:12:39 +01:00
Wadeck Follonier 7b4c7c29e6 avoid submitting the plain token value if the user submit the form when there is a new token freshly saved
- also remove the "json-ignore" which is no more required with this new approach
2018-03-21 13:43:18 +01:00
Steve Arch 44e15410fa [JENKINS-50296] Added test case 2018-03-21 11:29:08 +00:00
Wadeck Follonier 6b5c5d3ef3 Address using Daniel's comments (first part)
- improve UI/UX using repeat instead of advanced
- placeholder "Default Token" is transformed into a real default "unique" name after generation and can be renamed
- remove trigger of Old Data Monitor (custom monitor not yet started)
- log (finer) the stack trace in case of deprecated call to getApiToken()
- reduce warning to fine for deprecated usage
- change the "deprecated" token value to "This user currently does not have a legacy token"
- in case we revoke the legacy token from the store, the plain legacy token is now shown as "Legacy token was revoked"
- improve confirm.js to allow developer to specify part of form that are not expecting confirm behavior
2018-03-21 11:48:24 +01:00
Jesse Glick df6d291d06 Picking up fix caught by DefaultFilePathFilterTest. 2018-03-20 17:22:59 -04:00
Steve Arch f3053efdec [JENKINS-50296] Run ThreadPoolForRemoting as SYSTEM 2018-03-20 17:21:11 +00:00
Oleg Nenashev 0c872c7495 [JENKINS-50237] - Whitelist org.apache.tools.ant.Location for serialization
(cherry picked from commit 300fbc3715)
2018-03-20 10:19:30 -04:00
Jesse Glick 8112f37b43 Passing for me locally? 2018-03-20 10:09:20 -04:00
Raul Arabaolaza 198850a120 [JENKINS-49269] Cautious deleteDir 2018-03-20 14:56:25 +01:00
Jesse Glick 7b9a3e4448 [JENKINS-50237] Pick up Remoting with automatic ProxyException; and avoid BuildException to begin with. 2018-03-19 16:57:15 -04:00
Kohsuke Kawaguchi ca61ed7e35 [maven-release-plugin] prepare for next development iteration 2018-03-19 10:55:50 -07:00
Kohsuke Kawaguchi 8ece20cf12 [maven-release-plugin] prepare release jenkins-2.112 jenkins-2.112 2018-03-19 10:55:50 -07:00
Oleg Nenashev 20d44c5aa7 Merge pull request #3294 from dwnusbaum/JENKINS-34712
[JENKINS-34712] Always show the master node when it is offline

(cherry picked from commit b67a30f8da)
2018-03-19 13:53:20 +01:00
Oleg Nenashev db034758e0 [JENKINS-49565] - Update Jenkins CLI to Mina SSHD Core 1.7.0
(cherry picked from commit 36f7fc0d92)
2018-03-19 13:48:33 +01:00
Daniel Beck 6de571632c Merge pull request #3014 from daniel-beck/JENKINS-26143
[JENKINS-26143] Make choice parameter work with choices list in pipeline
2018-03-18 19:50:27 +01:00
Oleg Nenashev bb89137596 Merge pull request #3338 from oleg-nenashev/findbugs/JENKINS-50064
Cleanup FindBugs in CLI + some refactoring
2018-03-18 06:59:38 +01:00
Daniel Beck 34b1e83f41 Merge pull request #3345 from daniel-beck/autocomplete-parent-loggers
Add parent loggers to autocompletion
2018-03-17 22:56:10 +01:00
Oleg Nenashev efcfec3a59 Merge pull request #3309 from daniel-beck/rekey-action
Fix form action target for rekey monitor
2018-03-17 22:04:08 +01:00
Oleg Nenashev c73a7857d6 Merge pull request #3337 from oleg-nenashev/bug/JENKINS-38812
[JENKINS-38812] - Support insensitive autocompletion for item selection
2018-03-17 20:52:03 +01:00