Commit Graph
32590 Commits
Author SHA1 Message Date
Piush b0c5a86add [JENKINS-29470] - Prevent NPE in AbstractProject.checkout when agent disconnects during the build (#3094)
[JENKINS-29470] - Prevent NPE in AbstractProject.checkout when agent disconnects during the build
2018-03-04 12:11:23 +01:00
Zdeněk Soukup d9e1f383ea [JENKINS-43581] - Create new custom tool button should be on top (#2926)
* [JENKINS-43581] Create new custom tool button should be on top

* * [JENKINS-43581] Create new custom tool button should be on top

* * [JENKINS-43581] Create new custom tool button should be on top

* * [JENKINS-43581] Create new custom tool button should be on top
2018-03-04 02:35:34 +01:00
Devin Nusbaum c816f9655b [JENKINS-22936] Move rename logic to AbstractItem (#3289)
* Move rename infrastructure to a dedicated page at the AbstractItem level

* Preserve existing translations where applicable

* Keep doDoRename method at Job level and remove unneeded compatibility page

* Fix tests

* Fix Javadoc

* Update existing rename tests to use new page

* Update test names for clarity

* Add since tag for newly introduced APIs

* Apply project naming strategy to all renamed items, not just jobs

* Use shorthand accessor

* Clean up Job#doDoRename and deprecate it

* Use new-style web method for doDoRename2

* Remove CheckForNull tag from void method and update Javadoc

* Change names to doConfirmRename and confirm-rename.jelly

* Rename index.jelly to action.jelly and use j:if tag correctly

* Update permission check and remove unused import

* Use new url and update method name in test

* Fix Javadoc

* Fix URL in JobTest

* Update Javadoc for AbstractItem#isNameEditable
2018-03-04 01:00:45 +01:00
surenpi 7d8dcaad78 Add Chinese translation 2018-03-03 23:02:13 +08:00
Daniel Trebbien 8f51260323 hudson.Util improvements (#3226)
* Organize imports

* Use StandardCharsets

* Delete a redundant cast

* Replace use of _ as an identifier

_ is a keyword in Java 9.

* Use Logger message formatting

* Use fileToPath()

* Switch to using Files.createTempDirectory()

* Document that Util.touch() will truncate an existing file

* Replace an unnecessary use of Throwable.initCause()

* Implement deprecated copyStream() using IOUtils

* Copy to NULL_OUTPUT_STREAM

Also, closing source is moved to a finally block, to guarantee that it
will be closed per the documentation; it was technically possible for
the input stream to not be closed if construction of the MessageDigest,
DigestInputStream, or byte[] buffer failed for some reason (e.g. out of
memory).

* Delete an unnecessary try-with-resources

* Throw an IllegalArgumentException if data has odd length

Previously, a StringIndexOutOfBoundsException would be thrown, which is
less clear.

* Specify expanded POSIX file permissions
2018-03-03 13:04:29 +01:00
Oleg Nenashev 46510e2d2d Merge pull request #3277 from uhafner/prototype-1.7.3
[FIXED JENKINS-49319] Upgrade to PrototypeJS 1.7.3
2018-03-03 12:49:12 +01:00
Oleg Nenashev 29f146c7c2 Merge pull request #3312 from jglick/inner-madness-JENKINS-49573
[JENKINS-49795] Fix bad serialization of ParametersAction.parameterDefinitionNames and make sure this kind of mistake produces a warning in the future
2018-03-03 12:47:01 +01:00
Oleg Nenashev 852ecdc5f2 [JENKINS-49596] - Update Winstone to 4.1.2 (#3307)
* [JENKINS-49596] - Update Winstone to 4.1.1

* [JENKINS-49596] - Pick 4.1.2 with extended session eviction defaults
2018-03-02 10:22:29 +01:00
surenpi 565a4799ef Submit button localization 2018-03-01 12:47:41 +08:00
Jesse Glick 9b9f81d4a5 Merge branch 'master' into VirtualFile-JENKINS-49635 2018-02-28 16:36:43 -05:00
Kseniia Nenasheva 2ad96a3d5b [JENKINS-49387][JENKINS-49520] - Validation errors (#3292)
* Fixes for validation

* Fix for an empty agent.nExecutors

(cherry picked from commit 5c8cc45900)
2018-02-28 19:17:25 +01:00
Jesse Glick dd3ddf3ceb [JENKINS-49543] Old versions of Tomcat also failed to serialize classes from Jenkins modules.
(cherry picked from commit 376c6a0add)
2018-02-28 17:27:51 +01:00
Oleg Nenashev 2ce5036cb0 [JENKINS-49543] - Add direct unit test for module class whitelisting
(cherry picked from commit 800668ba43)
2018-02-28 17:27:51 +01:00
Wadeck Follonier d31a3b1594 - correct last failing test, required legacy behavior to work 2018-02-28 12:13:37 +01:00
Carl-Frederik Hallberg e5f61e29e2 [JENKINS-49788] Added ConcurrentLinkedQueue to whitelisted classes. (#3315) 2018-02-28 11:44:36 +01:00
suren 5fafb0bd1b Add Chinese translation (#3287)
* Add Chinese translation for Job Naming Strategy

* Add Chinese translation

* Localized for apply component
2018-02-28 10:24:14 +01:00
Oleg Nenashev cd6eef9be0 Merge pull request #3288 from jcoste-orange/fixFRTranslation
fix missing parameter in french translation of test:bar taglib
2018-02-28 10:20:46 +01:00
Oleg Nenashev 262a7a1345 Merge pull request #3313 from jglick/Tomcat-redux-JENKINS-49543
[JENKINS-49543] Old versions of Tomcat also failed to serialize classes from Jenkins modules
2018-02-28 10:16:35 +01:00
Jesse Glick 94ea347aac TextFileTest.tail failed on Windows when using a source checkout with Unix newlines.
(cherry picked from commit 3a81319)
2018-02-28 09:21:12 +01:00
Wadeck Follonier 503c2459a4 correction of some tests that were using the withApiToken without legacy behavior 2018-02-28 09:03:51 +01:00
Wadeck Follonier 930f70ef07 correct exclusive boundary mistake 2018-02-28 08:47:28 +01:00
Daniel Beck 35a38f0ce6 [JENKINS-32599] Ignore misplaced users/config.xml file 2018-02-28 00:54:04 +01:00
Jesse Glick c52154428c Merge branch 'security-stable-2.89' into security-master 2018-02-27 12:47:55 -05:00
Jesse Glick bfc994bbd4 Merge branch 'stable-2.89' 2018-02-27 12:46:34 -05:00
Daniel Beck 9054e2211e [JENKINS-49642] Fix proxy view recursion 2018-02-27 18:39:43 +01:00
Wadeck Follonier ac2a97f77a adjust some whitespaces and removal of since 2018-02-27 17:50:16 +01:00
Wadeck Follonier 1087200686 remove the prefix as it is not more useful (was for BCrypt but no more with SHA-256) 2018-02-27 17:45:36 +01:00
Wadeck Follonier d26b9f1c06 - remove modification in SetupWizard 2018-02-27 17:16:49 +01:00
Oleg Nenashev c33f146204 Merge pull request #3310 from jglick/TextFileTest.tail
TextFileTest.tail failed on Windows when using a source checkout with Unix newlines
2018-02-26 18:01:12 +01:00
Jesse Glick 376c6a0add [JENKINS-49543] Old versions of Tomcat also failed to serialize classes from Jenkins modules. 2018-02-26 11:17:42 -05:00
Jesse Glick fcae9bb598 [JENKINS-49573] Fix bad serialization of ParametersAction.parameterDefinitionNames and make sure this kind of mistake produces a warning in the future. 2018-02-26 10:48:02 -05:00
Jesse Glick 520bcb96cb Choose more mnemonic artifactId’s for modules not consumed externally. 2018-02-26 10:15:47 -05:00
Jesse Glick 3a81319ca3 TextFileTest.tail failed on Windows when using a source checkout with Unix newlines. 2018-02-26 10:04:11 -05:00
Wadeck Follonier 1fd1e68639 Merge remote-tracking branch 'origin/JENKINS-32442-32776_HASHED_TOKEN' into JENKINS-32442-32776_HASHED_TOKEN 2018-02-26 11:56:23 +01:00
Wadeck Follonier 612f04af8e provide the token id when we generate a new token, could be used to automate the generation / revocation of token 2018-02-26 11:56:01 +01:00
Wadeck Follonier e2d0678f1c Merge branch 'master' into JENKINS-32442-32776_HASHED_TOKEN 2018-02-26 10:33:54 +01:00
Wadeck Follonier c6150ca17f - remove useless code 2018-02-26 10:31:58 +01:00
Oliver Gondža 4cdfe7f3a6 Add tests for REST API authenticated by token in parameter (#2768)
* Add tests for REST API authenticated by token

* Avoid adding the crumb that is not needed anymore

(cherry picked from commit b652b07)
2018-02-26 10:31:45 +01:00
Wadeck Follonier d0d1000d2d - correction of two bugs, when the user does not have any token, the legacy generation is not displayed and when we load config with user with legacy token
- de-final-ize the properties to be used in Groovy Script
2018-02-26 09:33:13 +01:00
Kohsuke Kawaguchi 501b117262 [maven-release-plugin] prepare for next development iteration 2018-02-25 15:02:25 -08:00
Kohsuke Kawaguchi 3476f228f8 [maven-release-plugin] prepare release jenkins-2.109 jenkins-2.109 2018-02-25 15:02:24 -08:00
Daniel Beck 2656ad2a8f Fix form action target for rekey monitor 2018-02-26 00:00:05 +01:00
Oliver Gondža b652b07f13 Add tests for REST API authenticated by token in parameter (#2768)
* Add tests for REST API authenticated by token

* Avoid adding the crumb that is not needed anymore
2018-02-24 15:13:14 +01:00
Bob Maertz 831fdb132c [JENKINS-48467] - Updated UserIdCause.print() to use ModelHyperlinkNote (#3238)
[JENKINS-48467] - Updated UserIdCause.print() to use ModelHyperlinkNote
2018-02-24 15:12:53 +01:00
John Lamb e0070aa698 Improve sortable.js to work with BFA table (#3125)
* Improve sortable.js to work with BFA table

The Failure Cause Management table generated by the Build Failure
Analyzer
plugin (<https://wiki.jenkins.io/display/JENKINS/Build+Failure+Analyzer>)
doesn't render dates in a manner that sortable.js can recognize. This
commit improves the matching and sorting for date-like strings to
accommodate a broader variety of date/time strings, and uses the js Date
class to ensure accurate greater/equal/less than results.

* Remove commented patterns in sortable.js
2018-02-24 15:11:35 +01:00
Oleg Nenashev de967b2443 Merge pull request #3281 from jglick/Util.escape
Fixing nullability annotations on Util.escape
2018-02-24 15:10:02 +01:00
Oleg Nenashev dcb1bcd540 Merge pull request #3303 from recena/JENKINS-49634
[JENKINS-49634] Wrong escaping of quotes in the Setup Wizard
2018-02-24 11:40:53 +01:00
Oliver Gondža 72a7529a11 [FIX JENKINS-30909] Make sure queue is persisted reliably (#3244)
* [FIX JENKINS-30909] Make sure queue is persisted reliably

* Fix tests on Windows

* Ensure Saver is thread-safe
2018-02-23 20:30:37 +01:00
Oleg Nenashev 72d80b49f2 Merge pull request #3304 from jenkinsci/ndeloof-JENKINS-42816
[JENKINS-49661] use "agent" for Symbol
2018-02-23 19:40:21 +01:00
Wadeck Follonier c5faac8186 Change the approach for the configuration, when upgrading, we force the default secured version if you did not have ApiTokenPropertyConfiguration configured before.
- inverse the boolean after Jesse's comment
2018-02-23 17:01:52 +01:00