* Revert "[JENKINS-48447] Fixed HTTP 404 error when clicking on newView sidebar link from an other view. (#3178)"
This reverts commit 6df06fc19a.
* Revert "[JENKINS-46911] createProjectFromXML not recognizing unsafe character… (#3057)"
This reverts commit ac2a1aaf89.
* [JENKINS-48447] Fixed HTTP 404 error when clicking on newView sidebar link from an other view.
* [JENKINS-48447] Fixed unit tests for NewViewLink
* [JENKINS-48447] Load url name each time object gets initialized and adapted tests.
* [JENKINS-48447] Rewrite tests for url name; fixed indenting.
* [JENKINS-48447] Fixed more identing.
* [JENKINS-48447] Added @Restricted to NewViewLink; undo URL_NAME renaming.
* [JENKINS-46911] createProjectFromXML not recognizing unsafe character '/'
* Better place for testCreateProjectCheckGoodName()
* Fix failed test
* Make changes suggested on PR review.
* Remove Failure exception, instead throw IOException. Add javadoc
* [JENKINS-46911] - Add TODO according to the comment from @jtnord.
If hudson.lifecycle.ExitLifecycle is selected, jenkins will exit when
restart is requested. Exit code is taken out of
jenkins.model.Jenkins.exitCodeOnRestart, default is 5.
This is usable when there is an external watchdog such as SystemD.
SystemD service example:
ExecStart=@/usr/bin/java jenkins $JAVA_OPTIONS -DJENKINS_HOME=${JENKINS_HOME} -Dhudson.lifecycle=hudson.lifecycle.ExitLifecycle -Djenkins.model.Jenkins.exitCodeOnRestart=55 -jar $JENKINS_WAR --debug=${JENKINS_DEBUG_LEVEL} --httpPort=${JENKINS_PORT} --httpListenAddress=${JENKINS_LISTEN_ADDRESS} $JENKINS_ARGS
Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
The goal here is to:
* be able to selectively choose performance over integrity in some very
specific cases
* be able to globally disable AtomicFileWriter integrity, and basically
revert to previous behaviour by setting a system property.
This flag is meant as an emergency one in case something goes very
wron on some production system.
* Add getSystemProperty(key) to fix hudson.consoleTailKB system property
* Add Javadoc, @Restricted and delegate to SystemProperties
These changes were requested by @daniel-beck.
* PR was not merged in time for 2.96
* Changes as requested by @oleg-nenashev
(cherry picked from commit 006c51256e)
Every request that comes from Jelly is checked against Permissions.
As result it leads to a call of `getId` method that produces the new string.
Usually it's not a problem, but in case of stop-the-world pause user requests are accumulated.
So, once pause is finished, we forcibly allocated tons of strings for
every request. That leads to new stop-the-world pause. (And this cycle
can repeat multiple times)
(cherry picked from commit b2c40cb9e0)
Pulls in fixes for: JENKINS-48133, JENKINS-48055, JENKINS-37566, JENKINS-48309, JENKINS-47965, JENKINS-48130, JENKINS-37670, JENKINS-37566, JENKINS-46724
This change also adds some missing null/closing channel checks in the core.
In some cases the change prevents spawning threads if the channel is in the invalid state.
* Use "Files.createTempDirectory" to create temp directory instead
See SonarQube critical vulnerability squid:S2976 (tag: owasp-a9)
https://next.sonarqube.com/sonarqube/coding_rules#rule_key=squid%3AS2976
* [JENKINS-48227]
Creating a utility "static Path toPath(File file) throws IOException" method,
which wraps InvalidPathException to IOException so that it will be checked.
- also fixed public static final reference
- fixed broken test cases
- added new test cases for toPath() and createTempDir()
* Revert back to public static int
* adjustments due to merges
* Add posix check to determine if Posix FileAttributes should be included
in call to Files.createTempDirectory()
* Remove reference to private element
* Updated to use explicit imports
Baptiste Mathus