Commit Graph
32590 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 1b76722e13 [maven-release-plugin] prepare release jenkins-2.59 jenkins-2.59 2017-05-07 21:23:31 -07:00
Andrew Bayer 00e8f77b56 [FIXED JENKINS-38005] Properly log failure due to empty archive in Pipeline (#2823)
* [FIXED JENKINS-38005] Properly log failure due to empty archive in Pipeline

Since the job result is probably still null at the time that archiving
occurs, we weren't actually logging anything in Pipeline jobs in that
case. That was not ideal. So instead, let's log things, and also let's
update the error message to include a tip to use the allowEmptyArchive
option.

* Reverting to original message
2017-05-05 18:36:05 +03:00
Kamil Szymanski a6cd5b515d Upgrade to Groovy 2.4.11 2017-05-05 10:12:42 +02:00
Allan Burdajewicz 17eedcfde8 [JENKINS-42707] AccessDeniedException exception in ReverseBuildTrigger (#2846)
* [JENKINS-42707] AccessDeniedException vulnerability in ReverseBuildTrigger.

* [JENKINS-42707] Added tests to expose the issue

* [JENKINS-42707] Log message according to permission (DISCOVER/READ)

* [JENKINS-42707] Use MockAuthorizationStrategy

* [JENKINS-42707] Remove internationalization for logger
2017-05-05 10:44:43 +03:00
Michael Clarke f36917c210 [JENKINS-42959, JENKINS-44046, JENKINS-43979] - Bump Trilead to build217-jenkins-10 (#2872)
[JENKINS-42959] Correctly compare key algorithms during key verification
[FIXED JENKINS-44046][FIXED JENKINS-43979] Use a larger default key size to fix issues when using SHA256 MACs during Diffe-Helman key exchange against older versions of OpenSSH

Fixes issues encountered following the recent move to the latest Trilead version. These fix 2 underlying issues:

    diffe-helman-sha256 Key Exchange needs at least 2048 bits of data to generate a key against OpenSSH 6.4 and below.
    Known hosts comparison incorrectly compares the hostname against the key value meaning key verification always fails when using known hosts files
2017-05-05 01:12:43 +03:00
Jesse Glick 07c918b321 Merge pull request #2871 from jglick/MyViewTest.testDoCreateItem
Suppressing test flakiness
2017-05-04 11:28:00 -04:00
Scott Hebert 07683617d3 [JENKINS-42728] Updating view with CLI using input of a different view type should fail (#2804)
* [JENKINS-42728] Updating view with CLI using different view type should fail

- Additionally, updating a view using an XML that will be converted by XStream via an alias
  will succeed.

[FIXES JENKINS-42728]

* Remove TestView

* update test
2017-05-04 18:21:56 +03:00
Daniel Beck d45576d8fb Merge pull request #2863 from jglick/TcpSlaveAgentListener-logging
Indicate the actual protocol being served by TcpSlaveAgentListener
2017-05-04 15:10:07 +02:00
Daniel Beck 43b06d5a26 Merge pull request #2861 from amuniz/JENKINS-43929
[JENKINS-43929] Specific cache control header on ajax.jelly
2017-05-04 15:09:33 +02:00
Daniel Beck c362bfc8c7 Merge pull request #2868 from jglick/SetupWizard-NPE-JENKINS-44010
[JENKINS-44010] NPE in setup wizard
2017-05-04 15:08:27 +02:00
Jesse Glick 4eb9d8ab6d Suppressing test flakiness. 2017-05-03 13:46:30 -04:00
Oleg Nenashev 3172cf333b Update WinSW to 2.1.0 and Windows Agent Installer to 1.9
See the changelog: https://github.com/jenkinsci/windows-slave-installer-module/blob/master/CHANGELOG.md
2017-05-03 18:13:40 +03:00
Jesse Glick ae1fdc95a1 [FIXED JENKINS-44010] It is possible for Jenkins.crumbIssuer to be unset while the setup wizard is running. 2017-05-03 10:36:51 -04:00
Andrew Bayer 71a46145a6 Javadoc cleanup 2017-05-02 15:51:56 -04:00
Andrew Bayer aa5ff5410f Forgot to remove SCMTriggerItem everywhere in View 2017-05-02 15:35:58 -04:00
Andrew Bayer 99baf7a610 Forgot a bit of javadoc 2017-05-02 15:34:46 -04:00
Andrew Bayer 66460f95b0 Get rid of isBuilding() check on previous build's culprits. 2017-05-02 15:23:57 -04:00
Andrew Bayer 31bc41739b Review comments. 2017-05-02 14:41:01 -04:00
Jesse Glick 44cc306828 @stephenc requested that the original message be retained at FINE. 2017-05-02 13:47:22 -04:00
Andrew Bayer 28dce4c305 Get rid of asRun(). 2017-05-02 13:21:20 -04:00
Jesse Glick b5ee2a0750 Merge pull request #2860 from jglick/OldDataMonitorTest.unlocatableRun-JENKINS-26718
Improved OldDataMonitorTest.unlocatableRun
2017-05-02 12:50:24 -04:00
Andrew Bayer 977f922136 Refactor for supporting on-demand calculation of culprits 2017-05-02 11:14:03 -04:00
Andrew Bayer 39136804e5 Rework to solo RunWithSCM interface 2017-05-02 10:28:10 -04:00
Andrew Bayer e6f606465d Code review responses 2017-05-02 10:06:51 -04:00
Oleg Nenashev e91a82d27c [JENKINS-42861] - Properly deprecate the HudsonExceptionNote implementation (#2811)
* [JENKINS-42861] - Properly deprecate the HudsonExceptionNote implementation

It is a replacement of the original fix in https://github.com/jenkinsci/jenkins/pull/2808.

The implementation provides deprecates the annotation of the new stacktraces, but it retains the binary and the persisted data compatibility, which were missing in the original PR.
In the longer-term the hyperlinks should be replaced by the best possible equivalent (JIRA search, grepcode or whatever).

* [JENKINS-42861] - Cleanup the deprecated functionality

(cherry picked from commit 77a9f026f8)
2017-05-02 15:45:48 +02:00
Oleg Nenashev ce7d2aec50 Merge pull request #2828 from sathiya-mit/master
[JENKINS-42852] - Jenkins Configuration Save Option
(cherry picked from commit 77804c1451)
2017-05-02 15:37:59 +02:00
Andrew Bayer 6128459dd3 [FIXED JENKINS-42043] Catch and log RuntimeException in setNode
Also make sure we don't mark the Computer as used so that we kill any
executors that may be related to it somehow.

(cherry picked from commit 23b0085f45)
2017-05-02 15:33:03 +02:00
kzantow c553801a2b JENKINS-41778 - setup wizard issues when failures
(cherry picked from commit a3bf6a9801)
2017-05-02 15:21:42 +02:00
Oleg Nenashev 0e2cadf5ea [JENKINS-42717] - Prevent NPE when a non-existent Default View is specified in the global config (#2815)
* [JENKINS-42717] - Document view management methods in Jenkins and ViewGroupMixIn

* [KENKINS-42717] - GlobalDefauldViewConfiguration should not fail with NPE when the view is missing

* [JENKINS-42717] - Draft the direct unit test

* [JENKINS-42717] - Fix the tes implementation

* [JENKINS-42717] - Make FormException localizable

* [JENKINS-42717] - Fix te build glitch

(cherry picked from commit 4074818b97)
2017-05-02 15:17:11 +02:00
Jesse Glick 161095e01b [JENKINS-21695] - The CompressionFilter.uncaughtExceptionHandler must not attempt to write to a committed response. (#2834)
(cherry picked from commit 0c7e7bbc55)
2017-05-02 15:10:36 +02:00
Félix Belzunce Arcos 1c56f01283 [JENKINS-43936] Only migrate legacy users once per restart
(cherry picked from commit f091c9de34)
2017-05-02 15:07:56 +02:00
Oliver Gondža 6f44ff7dee [FIXED JENKINS-43279] Make sure Cloud.PROVISION is properly initialized
(cherry picked from commit d35dfcb24f)
2017-05-02 15:05:32 +02:00
Andrew Bayer e4b84a2f82 Revert "Initial work on DependencyGraph"
This reverts commit 7fe3a4a3b9.
2017-05-01 13:16:49 -04:00
Jesse Glick 105bbc885b Indicate the actual protocol being served. 2017-05-01 13:10:37 -04:00
Andrew Bayer 4f3172c515 Normalize versioning because that was unneeded 2017-05-01 11:45:11 -04:00
Jesse Glick 0993b7099b Do not load detached plugins during tests (#2829)
* Do not load detached plugins during tests.
Also warn about plugins which force us to create classes.jar.

* Porting POM fix from #2795: we must allow snapshots from repo.jenkins-ci.org so as to be able to test upstream component PRs.

* Fixed failures in tests which assumed detached plugins were being loaded.

* jenkins-test-harness 2.20

* Unreproducible test failure on CI, probably due to timing.
2017-05-01 16:44:55 +03:00
Kohsuke Kawaguchi c33e7dc420 [maven-release-plugin] prepare for next development iteration 2017-04-30 21:38:32 -07:00
Kohsuke Kawaguchi 97b59acc0b [maven-release-plugin] prepare release jenkins-2.58 jenkins-2.58 2017-04-30 21:38:32 -07:00
Oleg Nenashev a32163f354 Merge pull request #2851 from recena/version-number
[JENKINS-43733] Pick up the latest release of version-number library
2017-04-29 17:44:53 +02:00
Oleg Nenashev 8a48e0ccb9 Merge pull request #2862 from fbelzunc/JENKINS-43936
[FIXED JENKINS-43936] Only migrate legacy users once per restart
2017-04-29 17:44:28 +02:00
Oleg Nenashev 6ff50863e4 Merge pull request #2848 from mc1arke/bump-trilead-version
Bump Trilead version to receive a number of security enhancements
2017-04-29 13:36:34 +02:00
Oleg Nenashev 461940f49a Merge pull request #2845 from tequillaz/fix/rss_job_name
Change rss feed build name
2017-04-29 10:52:44 +02:00
Andrew Bayer 569c990455 Merge branch 'master' into jenkins-24141
Conflicts:
	cli/pom.xml
	core/pom.xml
	pom.xml
	test/pom.xml
	war/pom.xml
2017-04-28 16:33:25 -04:00
Andrew Bayer 7fe3a4a3b9 Initial work on DependencyGraph 2017-04-28 16:30:09 -04:00
Félix Belzunce Arcos f091c9de34 [JENKINS-43936] Only migrate legacy users once per restart 2017-04-28 13:56:36 +02:00
amuniz d05fcdecf2 [JENKINS-43929] Specific cache control header on ajax.jelly 2017-04-28 10:52:39 +02:00
Oleg Nenashev 1899f36bfc [JENKINS-43825] - Refactor ProcessTree.Windows logic to propagate errors correctly (#2859)
* [JENKINS-43825] - Refactor WindowsProcess to a separate class and optimize logging

* [JENKINS-43825] - Refactor the code to properly propagate WindowsProcessException in ProcessTree to the top level

* [JENKINS-43825] - Polish logging

* [JENKINS-43828] - s/WindowsProcess/WindowsOSProcess

* [JENKINS-43825] - Next time I will try to compile the code before submitting
2017-04-28 10:43:23 +02:00
Jesse Glick 887a210a43 Trying to improve test code which fails on Windows CI. 2017-04-27 16:30:17 -04:00
Jesse Glick e713cb42f4 Rather than ignoring .repository, better to use a location in the workspace temp directory. 2017-04-27 11:35:27 -04:00
Jesse Glick 70dbe9ccdf Merge branch 'master' into OldDataMonitorTest.unlocatableRun-JENKINS-26718 2017-04-27 11:31:14 -04:00