Commit Graph
32590 Commits
Author SHA1 Message Date
Andrew Bayer 23b0085f45 [FIXED JENKINS-42043] Catch and log RuntimeException in setNode
Also make sure we don't mark the Computer as used so that we kill any
executors that may be related to it somehow.
2017-04-07 12:39:29 -07:00
Jesse Glick 27d508d8d6 sshd 1.11 2017-04-07 12:21:32 -04:00
Jesse Glick 45092f06a8 checkChannel() provides a better error message in case you are not using Remoting mode. 2017-04-07 12:04:58 -04:00
Jesse Glick 98f227c20a Showing general help message rather than suggesting obsolete authentication options. 2017-04-07 11:47:59 -04:00
Jesse Glick 0f87e10a69 @oleg-nenashev requested this be decoupled from https://github.com/jenkinsci/sshd-module/pull/10. 2017-04-07 11:29:21 -04:00
Jesse Glick f3da0e498f Minor review comments from @oleg-nenashev. 2017-04-07 10:22:06 -04:00
Jesse Glick 2e7fe04d7c Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-07 09:56:31 -04:00
Marcin Zajączkowski 51e46505b9 [JENKINS-43322] Nested views searchable by name 2017-04-07 14:19:15 +02:00
Oliver Gondža 1ca9c880fd [FIXED JENKINS-40848] Introduce status indicator for skipped download job (#2705)
* [FIXED JENKINS-40848] Introduce status indicator for skipped download job

* [JENKINS-40848] Stick to existing code-flow as that is proved to work
2017-04-07 10:50:15 +02:00
Oliver Gondža d35dfcb24f [FIXED JENKINS-37616] Make sure Cloud.PROVISION is properly initialized 2017-04-07 10:46:33 +02:00
Marcin Zajączkowski b831acd985 [JENKINS-42645] Case insensitive search by default for new and anonymous users (#2801)
* [JENKINS-42645] Case insensitive search by default

* [JENKINS-42960] Search in FixedSet more locale friendly

String.equalsIgnoreCase is safer than toLowerCase when non English
locales are used.

* [JENKINS-42645] Review remarks
2017-04-07 10:40:12 +02:00
Jesse Glick 6ffc57ae79 Verifying that PlainCLIProtocol ignores unrecognized opcodes, so long as it has received well-formed frames. 2017-04-06 15:58:23 -04:00
Jesse Glick 9150d5b563 Suppress an idle timeout from Jetty which would otherwise interfere with interactive commands. 2017-04-06 15:30:53 -04:00
Jesse Glick 6c63890e41 Demonstrating that interleaved stdio does work in -http mode. 2017-04-06 15:18:07 -04:00
Jesse Glick c41c97b3a2 @stephenc requested documentation of the deprecated FullDuplexHttpStream constructor, and as it turns out it did not work. 2017-04-06 11:40:19 -04:00
Jesse Glick 49f0360761 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-06 10:17:54 -04:00
Jesse Glick 25ef87d2e2 Merge pull request #2833 from jglick/npm
Update node, npm, download-maven-plugin, & frontend-maven-plugin
2017-04-06 08:51:29 -04:00
Jesse Glick 724ebbcc50 Improved error message displayed when using -http against a pre-JENKINS-41745 server. 2017-04-05 18:42:33 -04:00
Jesse Glick da581599fd -http mode broke when the user omitted the mandatory final / in the Jenkins URL. 2017-04-05 18:28:37 -04:00
Jesse Glick 3939820c5f Using logger as suggested by @rsandell. 2017-04-05 09:53:14 -04:00
Jesse Glick 7bca0a1eef Refined implementation of -logger. 2017-04-05 09:48:56 -04:00
Jesse Glick 9fc59bf251 Finally figured out how to suppress the ReadPendingException from Jetty.
Something¹ seems to interrupt the HTTP duplex service thread,
and Jetty apparently deals poorly with interruptions.
So introduce an extra sleep to soak up the interrupt.

¹Who? http://stackoverflow.com/questions/2126997/who-is-calling-the-java-thread-interrupt-method-if-im-not#comment40865453_2127397
2017-04-04 19:15:03 -04:00
Jesse Glick 5caee58697 Noting that ssh-cli-auth is obsolete. 2017-04-04 19:05:37 -04:00
Jesse Glick a87e10a5b9 Update node, npm, download-maven-plugin, and frontend-maven-plugin. 2017-04-04 17:15:30 -04:00
Jesse Glick dbe24a85a3 Using CLICommandInvoker in cases where we did not actually need to be testing Remoting-based CLI. 2017-04-04 15:38:34 -04:00
Jesse Glick 94d5f96d12 Figured out why Security232Test.commonsCollections1 was being skipped 10% of the time. 2017-04-04 15:16:05 -04:00
Jesse Glick 3b92399db8 Tested Jetty 9.4.3.v20170317 but ReadPendingException’s did not disappear. 2017-04-04 14:50:46 -04:00
Jesse Glick f7006b4674 Jetty 9.4.3.v20170317 refuses to set an empty HTTP header, leading to cryptic client errors since Hudson-Duplex is missing. 2017-04-04 14:46:20 -04:00
Jesse Glick 7f633dee58 CLITest.interrupt could fail if you had a stale localhost entry in ~/.ssh/known_hosts. 2017-04-04 14:16:58 -04:00
Jesse Glick caf3e8e843 Removing comment corresponding to something I can no longer reproduce. 2017-04-04 14:02:30 -04:00
Jesse Glick fb311c687f Suppress a meaningless ClosedChannelException thrown by Jetty when killing a client. 2017-04-04 14:01:57 -04:00
Jesse Glick 03aa2a1f17 Simpler to catch ReadPendingException in just one place. 2017-04-04 13:48:21 -04:00
Jesse Glick 4069e67392 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-04 13:26:16 -04:00
Jesse Glick 4c1910a10b Silence an annoying message. 2017-04-04 13:24:20 -04:00
Baptiste Mathus 09cfe3bda6 Merge pull request #2802 from batmat/JENKINS-42709
[JENKINS-27624][JENKINS-42709] Bump Jenkins baseline to Java 8 minimum
2017-04-04 19:01:48 +02:00
Jesse Glick c74999f00c Found a race condition which could explain random CI hangs of CLIActionTest.authenticate. 2017-04-04 11:26:57 -04:00
Jesse Glick 56cee9518a Found another case where the Windows CI build was complaining about known_hosts metadata. 2017-04-04 11:11:40 -04:00
Jesse Glick 71d7562db6 Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-04 11:03:59 -04:00
Sathiya Narayanan a7bcf1fd0f Fixed - Jenkins Global Configuration Save Option 2017-04-04 19:42:53 +05:30
Oleg Nenashev df6528e233 Merge pull request #2832 from varyvol/JENKINS-43320
[JENKINS-43320] Improve JNLP configuration Spanish translations
2017-04-04 15:34:26 +02:00
Evaristo Gutiérrez de75be131b [JENKINS-43320] Improve Spanish translations for JNLP configuration. 2017-04-04 09:07:38 +02:00
Jesse Glick 9812db70d3 Improved handling of stream closure.
Making interrupt of `build -s` work in `-http` mode.
Does not solve `ReadPendingException`s.
2017-04-03 18:52:59 -04:00
Jesse Glick f6314b7bfb Testing interrupt behavior. 2017-04-03 18:37:59 -04:00
Jesse Glick 551808ca6a Using kill -QUIT to try to diagnose client hangs observed on ci.jenkins.io but not locally reproducible. 2017-04-03 17:57:19 -04:00
Jesse Glick f1689367c3 Test failure on Windows, perhaps specific to filesystem type of TemporaryFolder.
java.nio.file.FileSystemException: …\.ssh\known_hosts: Incorrect function.
        at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
        at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:90)
        at sun.nio.fs.WindowsAclFileAttributeView.getFileSecurity(WindowsAclFileAttributeView.java:88)
        at sun.nio.fs.WindowsAclFileAttributeView.getOwner(WindowsAclFileAttributeView.java:121)
        at sun.nio.fs.FileOwnerAttributeViewImpl.getOwner(FileOwnerAttributeViewImpl.java:91)
        at java.nio.file.Files.getOwner(Files.java:2079)
        at org.apache.sshd.common.util.io.IoUtils.getFileOwner(IoUtils.java:272)
        at org.apache.sshd.common.util.io.ModifiableFileWatcher.validateStrictConfigFilePermissions(ModifiableFileWatcher.java:240)
        at org.apache.sshd.client.keyverifier.DefaultKnownHostsServerKeyVerifier.reloadKnownHosts(DefaultKnownHostsServerKeyVerifier.java:79)
        at org.apache.sshd.client.keyverifier.KnownHostsServerKeyVerifier.verifyServerKey(KnownHostsServerKeyVerifier.java:161)
        at …
Interactive testing of known_hosts on XP works as expected.
2017-04-03 17:06:53 -04:00
Oleg Nenashev 33f458d358 Merge pull request #2519 from oleg-nenashev/findbugs/JENKINS-36720-medium-level-fb
[JENKINS-36720] - Cleanup of SOME medium FindBugs issues
2017-04-03 22:45:34 +02:00
Jesse Glick 466d74d15e Merge branch 'master' into SSH-CLI-JENKINS-41745 2017-04-03 12:54:04 -04:00
Baptiste Mathus 067ba0ebe8 Remove MaxPermSize usage
Obsolete with Java 8. Permanent generation was removed.
2017-04-03 15:43:42 +02:00
Kohsuke Kawaguchi 0fac1f84f3 [maven-release-plugin] prepare for next development iteration 2017-04-02 18:15:20 -07:00
Kohsuke Kawaguchi 6e2a00eb8b [maven-release-plugin] prepare release jenkins-2.53 jenkins-2.53 2017-04-02 18:15:20 -07:00