Commit Graph
32590 Commits
Author SHA1 Message Date
Kohsuke Kawaguchi 7a92a23e7a [maven-release-plugin] prepare for next development iteration 2016-09-18 15:13:24 -07:00
Kohsuke Kawaguchi 7c69ac8c81 [maven-release-plugin] prepare release jenkins-2.23 jenkins-2.23 2016-09-18 15:13:24 -07:00
R. Tyler Croy 8cb0a37176 Merge pull request #2550 from rtyler/jenkinsfile-concurrency
Let Maven decide the appropriate amount of concurrency
2016-09-18 14:21:48 -07:00
christ66 8d64ff51a9 Do not create the directory if it already exists. 2016-09-18 09:42:37 -07:00
christ66 f8c9c04ce4 Fix javadocs. 2016-09-18 09:35:50 -07:00
R. Tyler Croy 09df83be00 Let Maven decide the appropriate amount of concurrency 2016-09-18 09:34:47 -07:00
Daniel Beck 705996566c Noting #2495, #2539, #2542 2016-09-17 21:59:24 -07:00
Matthew Reiter 0268b988d5 [FIXED JENKINS-31487] (#2542)
There were two issues preventing the build history from updating properly:
1) The next build number being fetched wasn't taking into account running builds, so any builds already running when the page is refreshed would be ignored. The fix was to use nextBuildNumberToFetch if it is available (which is the case if there are running builds) and to fall back to the next build otherwise.
2) The first transient build key (used to clear out builds from the history that are being updated) wasn't being set when the page first loads. This was fixed by making getHistoryPageFilter calculate the value so that it happens in all cases rather than just during the ajax call.
2016-09-17 21:52:23 -07:00
Jonathan Fuentes fbb4dc05b5 [FIXED JENKINS-36539] (#2495) 2016-09-17 21:41:14 -07:00
Oleg Nenashev e4820e4265 Revert FindBugs threshold back to High 2016-09-17 21:25:24 -07:00
lpancescu 096614a6d7 [JENKINS-10912] Use setInterval in refreshPart (#2539)
* [JENKINS-10912] Use setInterval in refreshPart

The current implementation of refreshPart creates a new closure every 5
seconds, which, in combination with XMLHttpRequest objects, results in a
significant memory leak in all major browsers. By using
window.setInterval to schedule periodic refreshes, only one closure per
id is created. Please see issue #10912 in the Jenkins tracker for
further details.

* Stop periodical calls if we can't find the div

* Don't check if isRunAsTest changed after page load
2016-09-17 21:15:23 -07:00
R. Tyler Croy 423fca9c97 Revamp the Jenkinsfile to use more recent @Symbol steps and to run well on ci.j.io (#2549) 2016-09-17 20:29:26 -07:00
christ66 8434afc250 Add unit test for atomic file writer. 2016-09-17 11:56:22 -07:00
Santiago Castro 4acaafdad1 Fix a Spanish legend text (#2535) 2016-09-17 11:00:01 -07:00
christ66 88a6f76c1b Commit should not perform a delete as it is already performing a move.
Add suffix to create temp file.
2016-09-17 10:09:22 -07:00
christ66 c960c75c86 Finish javadoc deprecated statement. 2016-09-17 00:27:29 -07:00
christ66 f9f10adf25 Perform ATOMIC_MOVE when copying the file. If we are unable to perform the ATOMIC_MOVE operation then we fallback to an operation which is supported by all OSes.
Create constructor for charsets.
Delete tempdir instead of destdir.
2016-09-17 00:11:30 -07:00
christ66 0a7b656af6 [JENKINS-34855] Make atomic file write more atomic by using JDK 7 apis. 2016-09-16 21:41:12 -07:00
Jesse Glick 307095b758 Missing @since versions for SECURITY-170 fix. (#2547) 2016-09-16 18:14:53 -07:00
Daniel Beck 0fc375e9e4 Add configuration for disabling admin monitors
Add display name for all admin monitors in core.
2016-09-16 18:06:16 -07:00
Daniel Beck 08def67a18 Noting #2525, #2526, #2529, #2534, #2536, #2540 2016-09-12 12:06:19 -07:00
Kohsuke Kawaguchi f2afd35699 updated changelog for release 2016-09-11 22:26:11 -07:00
Kohsuke Kawaguchi a34bc0d52d [maven-release-plugin] prepare for next development iteration 2016-09-11 22:18:56 -07:00
Kohsuke Kawaguchi 40f08710ae [maven-release-plugin] prepare release jenkins-2.22 jenkins-2.22 2016-09-11 22:18:56 -07:00
Jesse Glick ca5c597a1a sezpoz 1.12 - Better diagnostics of META-INF/annotations/hudson.Extension (#2525) 2016-09-09 17:07:30 +02:00
Vincent Latombe f4c9eb0322 [JENKINS-19142] Prompt user whether to add the job to the current view (#2529)
* [JENKINS-37857] Prompt user whether to add the job to the current view

* [JENKINS-37857] Fix review items from @daniel-beck
2016-09-09 15:38:45 +02:00
Andrew Bayer 75745f0042 [FIXED JENKINS-37731] Change symbol and constructor for SCMTrigger. (#2526)
* [FIXED JENKINS-37731] Change symbol and constructor for SCMTrigger.

Using "scm" as the @Symbol led to collisions with the "scm" global
variable in Pipeline, so that had to go. Changed it to "pollScm". Also
moved the @DataBoundConstructor to the single-parameter constructor,
deprecated the two-parameter constructor, created a @DataBoundSetter
for ignorePostCommitHooks, and added a getter for "scmpoll_spec" to
fix snippet generator and general syntactic goodness.

So now, with this, it's possible to do:

properties([
  pipelineTriggers([
    pollScm('@daily')
  ])
])

Tada.

Tests for the snippet generator and job property stuff will be landing
in a separate PR for workflow-multibranch.

* Review comments.

* Updating @since to 2.22
2016-09-09 15:34:59 +02:00
Kanstantsin Shautsou 5d3b23daf7 [FIXED JENKINS-37997] FIX NPE when descriptor is not in DescriptorList (#2536)
For example when Descriptor was defined as field and without @Extension .

Signed-off-by: Kanstantsin Shautsou <kanstantsin.sha@gmail.com>
2016-09-09 15:33:23 +02:00
Victor d4169af0f9 Fix Spanish localization typo in GlobalSecurityConfiguration (#2541) 2016-09-09 15:32:09 +02:00
Raphael Pionke feeda1dbaf [FIXED JENKINS-37814] make the icon of the script console configurable (#2528)
* make the icon of the script console configurable

* we don't need an extra variable

* use <j:choose>

(cherry picked from commit a6e1b0bebf)
2016-09-09 11:00:41 +02:00
dbroady1 349380aad7 [JENKINS-29956] Test Windows junctions before Java 7 symlink (#1787)
* Test Windows junctions before Java 7 symlink

Apparently Java 7 (and later) do not count Windows junctions as
symlinks.  When you drill down into the BasicFileAttributes structure,
reparse points are only counted under isOther.  So, since we already
have code that properly detects Windows Junctions, let's use that first
and then fallback to the Java 7 code.

* Add comment for change & link bug.

* Add test case

* Switch to Functions.isWindows().

* Use non-deprecated APIs for tmp file/dir mgmt

* Add better debugging.

* Allow spaces in junction name & dir name.

To do that, it was easier to use ProcessBuilder vs building up the correct
string in code to send to cmd.exe.

Also, I'll note that according to http://ss64.com/nt/syntax-internal.html,
mklink is in internal cmd.exe command.  So, it must be invoked through
"cmd.exe /c" for it to work.

* Remove comment mentioning bug number.

* Remove debugging output, per Baptiste's request

* Add newline at end of file.

* Make sure that the junction was removed.

* Use assertEquals to show retcode of Process.waitFor.

* Fix compilation errors by importing functions

(cherry picked from commit f4edf91782)
2016-09-09 10:53:48 +02:00
Joseph 78eaea116c [FIXED JENKINS-37549] - Fixed background color for ComboBoxList (#2511)
Hard to see anything with Gray background and White Text.
Style is in line with Selects and other form inputs.
(cherry picked from commit c505dec685)
2016-09-09 10:45:28 +02:00
Keith Zantow e889232b03 [FIX JENKINS-33374] - Correct Lifecycle-based restart behavior during setup wizard (#2515)
* JENKINS-33374 - correct restart behavior during setup wizard

* Add tests

* One more test

(cherry picked from commit 58ba65cacf)
2016-09-09 10:44:05 +02:00
Daniel Beck 065e1a3ae5 [FIX JENKINS-37360] Fix editing default view description with auto refresh (#2504)
(cherry picked from commit ee447af7e8)
2016-09-09 10:37:29 +02:00
Felix Belzunce Arcos a59dd9d45f [JENKINS-36748] Do not process null specs in triggers (#2482)
* [JENKINS-36748] Add a test case and not process null specs

* [JENKINS-36748] Correct license and add a minor comment

* [JENKINS-36748] Add a Waning logger when spec is null

(cherry picked from commit 4278804582)
2016-09-09 09:02:01 +02:00
Kohsuke Kawaguchi 8e2c7eced3 [maven-release-plugin] prepare for next development iteration 2016-09-08 12:36:00 -07:00
Kohsuke Kawaguchi 94b65affa4 [maven-release-plugin] prepare release jenkins-2.7.4 jenkins-2.7.4 2016-09-08 12:35:59 -07:00
R. Tyler Croy 51d9806327 Merge pull request #2540 from rtyler/34250
Use the appropriate 'Gear' icon on the Plugin Manager page
2016-09-07 07:40:14 -07:00
Oliver Gondža 5437b78ffc Merge pull request #2538 from olivergondza/trivial-groovy-error
Fix groovy test class declaration
2016-09-07 10:39:09 +02:00
R. Tyler Croy 4fbfe25797 Use the appropriate 'Gear' icon on the Plugin Manager page
This has annoyed me for long enough

Fixes JENKINS-34250
2016-09-06 15:08:39 -07:00
Oleg Nenashev 37edc1a3b0 [FIXED JENKINS-37332] - Prevent File descriptor leaks when reading manifests from JARs (#2516)
* [JENKINS-37332] - Improve diagnostics of non-closed streams during reading of the manifests in PluginManager

* [JENKINS-37332] - Leakless processing of JarUrlConnection during Manifest parsing

* [JENKINS-37332] - Also implement leak-safe method for retrieving file modification date

* [JENKINS-37332] - Add spotcheck methods for manifest file access + Javadoc

* [JENKINS-37332] - Also test multi-line and empty attributes in the test

(cherry picked from commit 96c97860b0)
2016-09-06 08:31:48 +02:00
Oleg Nenashev d154604e7b Update to SSHD module 1.7 (#2534)
Summary of changes:

* [JENKINS-36420](https://issues.jenkins-ci.org/browse/JENKINS-36420) - Allow setting up the the client idle timeout
* Upgrade to the new parent POM
* FindBugs cleanup, in particular https://github.com/jenkinsci/sshd-module/commit/66162e707189e6bda5708cf856e71b6130160cc1
2016-09-05 19:16:26 +02:00
Oliver Gondža d988964d5f Fix test class declaration 2016-09-05 16:29:57 +02:00
Oleg Nenashev b09043cb6d Noting #1835, #2532, #2523, #2528 and #2530 towards 2.21 2016-09-04 21:14:40 +02:00
Kohsuke Kawaguchi d6009e0e76 updated changelog for release 2016-09-04 08:29:32 -07:00
Kohsuke Kawaguchi d4fc22db17 [maven-release-plugin] prepare for next development iteration 2016-09-04 08:22:23 -07:00
Kohsuke Kawaguchi 5ed74894b7 [maven-release-plugin] prepare release jenkins-2.21 jenkins-2.21 2016-09-04 08:22:23 -07:00
Oleg Nenashev 0f45609fb2 [JENKINS-37874] - Print warnings if Jenkins startup/reload do not reach the COMPLETED state (#2530)
* [JENKINS-37874] - Log SEVERE messages if Jenkins does not reach COMPLETED stage during startup or reload

* [JENKINS-37874] - Add Administrative monitor for the COMPLETED state

* [JENKINS-37874] - Polish log messages
2016-09-03 14:14:45 +02:00
Raphael Pionke a6e1b0bebf [FIXED JENKINS-37814] make the icon of the script console configurable (#2528)
* make the icon of the script console configurable

* we don't need an extra variable

* use <j:choose>
2016-09-02 14:52:31 +02:00
valentina db61f470c3 remove restriction to be able to override the method in subclasses (#2523)
* remove restriction to be able to ovverride the method in subclasses

* since needs to be adjusted
2016-09-02 14:48:42 +02:00