Commit Graph
32590 Commits
Author SHA1 Message Date
Jesse Glick c54c363bfe Merge pull request #2188 from jglick/flakiness
Use rerunFailingTestsCount rather than @RandomlyFails
2016-03-30 10:56:19 -04:00
recena e74075ef84 [JENKINS-33755] Used checkJobName service for validating the item name 2016-03-30 16:43:16 +02:00
Kohsuke Kawaguchi 3a44687df5 Revert "[JENKINS-32190] Make UsageStatistics#isDue check Jenkins init level before generating stats."
This reverts commit d8a13ac07c.

I noticed a strange drop in usage statistics from the mid Jan 2016,
which corresponds to the time this change was released in the wild,
and further drop when LTS 1.642.2 is released with this change at
the end of Feb.

I spent some time trying to determine how this might cause instances
to stop sending data, but I couldn't come up with any. I left those
notes in JENKINS-32190. There was some strange behaviours, but none
explains what this is.

So I'd like to back out this change and see if that makes any impact
on the stats collection. If it backs up, then we know empirically
this change is to blame, so that would justify spending further
effort or come up with a fix from a different angle.

(cherry picked from commit b2013edbf7)
2016-03-30 12:39:03 +02:00
Kohsuke Kawaguchi ce866ddb3c Revert "[JENKINS-32190] Make UsageStatistics#isDue check Jenkins init level before generating stats."
This reverts commit d8a13ac07c.

I noticed a strange drop in usage statistics from the mid Jan 2016,
which corresponds to the time this change was released in the wild,
and further drop when LTS 1.642.2 is released with this change at
the end of Feb.

I spent some time trying to determine how this might cause instances
to stop sending data, but I couldn't come up with any. I left those
notes in JENKINS-32190. There was some strange behaviours, but none
explains what this is.

So I'd like to back out this change and see if that makes any impact
on the stats collection. If it backs up, then we know empirically
this change is to blame, so that would justify spending further
effort or come up with a fix from a different angle.

(cherry picked from commit b2013edbf7)
2016-03-30 12:36:28 +02:00
Jesse Glick 9ea9761adc [FIXED JENKINS-25440] Recursively resolve @Inject’ed extensions, too, looking for LinkageError’s.
(cherry picked from commit 1a2d82275c)
2016-03-30 12:30:35 +02:00
Kohsuke Kawaguchi af1a53d91c Merge pull request #2010 from jenkinsci/jnlp3
[FIXED JENKINS-26580][FIXED JENKINS-28289] Activate JNLP3 support
(cherry picked from commit 6d3e054396)
2016-03-30 12:24:37 +02:00
Stephen Connolly 5ca718ac01 [FIXED JENKINS-33377] Add a check for termination to Functions.isExtensionsAvailable()
(cherry picked from commit 1ed395aa06)
2016-03-30 12:05:20 +02:00
Emilio Escobar f24c536676 [JENKINS-28790] added valentina condition when the first argument is quoted.
(cherry picked from commit 344e917cc4)
2016-03-30 11:58:21 +02:00
Emilio Escobar 717c5f56bc [JENKINS-28790] NIT: tabulation issue
(cherry picked from commit 5423f695ab)
2016-03-30 11:58:21 +02:00
Emilio Escobar f6db6670a8 [JENKINS-28790] Baptiste comments fixed
(cherry picked from commit 7fb1ac9d9f)
2016-03-30 11:58:21 +02:00
Emilio Escobar 0782aa567b [JENKINS-28790] solved the issue masked parameters not masked in windows system. toWindowsCommand joins all args in one, missing masked.
(cherry picked from commit b9a72bcd96)
2016-03-30 11:58:21 +02:00
Valentina Armenise 951729c585 [JENKINS-32831] if metadata for tool installer does not exist should not fail
(cherry picked from commit d2b1f15fc5)
2016-03-30 11:00:38 +02:00
Vincent Latombe d57db1b1f2 [JENKINS-21486] Fix plugin dependencies resolution
* Check that dependencies are enabled. A disabled optional dependency
  will not prevent a plugin from loading.
* Check versions of dependencies declared by a plugin before loading it.
  If any dependency (even optional) is older than what is required,
  then the plugin isn't loaded.

This should prevent use cases where a plugin is loaded but one of its
dependencies is too old so that :
* its @Extension annotated classes cannot be loaded, causing the full
  Jenkins to blow up with crapload of exceptions which are tedious to
  investigate to understand the root cause.
* NoSuchMethodError and the likes at runtime even though boot has
  completed.

Version check (for setups where version list is manually crafted but yet
works) can be disabled by starting Jenkins with

-Dhudson.PluginWrapper.dependenciesVersionCheck.enabled=true

Minor fixes done while implementing this change :
* Fix version parsing in PluginWrapper.Dependency
* Dynamic plugin load didn't check for disabled flag
2016-03-30 10:40:12 +02:00
Stephen Connolly c57af86955 [FIXED JENKINS-33681] Plugin filters were failing to be removed and blocking restart
(cherry picked from commit a5febd7666)
2016-03-30 10:03:51 +02:00
Stephen Connolly d72076c47e [FIXED JENKINS-33384] clean up the PluginServletFilter instances on Jenkins.cleanUp()
(cherry picked from commit abf9fd3658)
2016-03-30 10:03:45 +02:00
gusreiber 3b9c22eb89 [FIX JENKINS-33804] adding style to banner 2016-03-29 19:43:16 -07:00
Christopher Orr 8dd9cbf6d5 Add note about empty environment variables not overriding existing ones. 2016-03-30 01:21:27 +02:00
Daniel Beck 4d01c07db6 Merge pull request #2190 from kzantow/JENKINS-33828-recommended-plugin-list-modifiable
[FIX JENKINS-33828] - setup wizard was modifying the recommended plugin list
2016-03-30 01:01:19 +02:00
Daniel Beck cbe9ea008a Merge pull request #2184 from kzantow/JENKINS-33813-graceful-setup-wizard-restart
[JENKINS-33813] - fix issues when errors happen during setup wizard
2016-03-30 00:55:28 +02:00
Christopher Orr 53a8e43b04 Remove some relative links from the agent configuration page.
These help files can be shown at two different levels in the URL hierarchy:
- /computer/createItem
- /computer/<name>/configure

Therefore a relative URL will not work in all cases.  To link to the desired
pages correctly would probably require using Jelly or code.
2016-03-30 00:37:57 +02:00
Christopher Orr d21677fb40 Improve documentation for number of agent executors. 2016-03-30 00:18:31 +02:00
kzantow ea6514a7b2 Setup Wizard not actually displaying the selected plugins properly in
the case of: deselect (e.g. click None), Back, install recommended
2016-03-29 16:39:17 -04:00
recena cd3302c686 Merge remote-tracking branch 'upstream/2.0' into newitem-polish 2016-03-29 20:45:15 +02:00
kzantow 1d4ca77cc9 Update loginError.jelly to match login.jelly setup wizard check 2016-03-29 14:28:11 -04:00
kzantow ae5c36979a Merge remote-tracking branch 'primary/2.0' into JENKINS-33800-initial-password-file-not-found 2016-03-29 14:24:05 -04:00
Jesse Glick e322322584 Merge pull request #2192 from jglick/checkJobName-JENKINS-20509
[JENKINS-20509] Move doCheckJobName to View
2016-03-29 13:47:10 -04:00
recena a2ace0b4e1 @jglick's comments were addresed 2016-03-29 19:40:47 +02:00
Jesse Glick 52bb332425 Merge pull request #2183 from jglick/SezpozModule-unique-ID-JENKINS-33772
[JENKINS-33772] ID was not sufficiently unique for SezpozModule
2016-03-29 13:06:13 -04:00
Vincent Latombe e629a5bf3b Update changelog for #2189 2016-03-29 19:05:29 +02:00
Vincent Latombe 06db9b86ef Merge pull request #2189 from yp-engineering/fix_jnlp_advertised_port
Fix advertised JNLP Port
2016-03-29 19:02:08 +02:00
Tom Fennelly b28da33651 Added InstallState override 2016-03-29 17:58:40 +01:00
Jesse Glick 0aa2858b2e [FIXED JENKINS-20509] Move doCheckJobName to View so that it can be used also from folders. 2016-03-29 12:47:36 -04:00
recena 4bfc5e18d2 Client-side form validation 2016-03-29 18:23:40 +02:00
kzantow 397ab3e2ca JENKINS-33828 - setup wizard was modifying the recommended plugin list
due to not returning a copy
2016-03-29 12:11:21 -04:00
kzantow 91b5590f27 Issue with timing determining install state; mark jenkins as upgrade if
jobs exist or security configuration was set up
2016-03-29 12:06:11 -04:00
Kohsuke Kawaguchi 62d0e0c268 Merge pull request #2175 from kohsuke/JENKINS-33799
[FIX JENKINS-33799] Enforce correct icon size in list view
2016-03-29 08:58:20 -07:00
bhenderson 6fe31014d8 Fix advertised JNLP Port
As far as I can figure, the /TcpSlaveAgentListener/ endpoint headers
tell the slaves what the JNLP port is. When I'm running jenkins behind a
proxy (marathon using the mesos plugin, which bridged networking), even
though I was setting the advertised port per a thread[1], it was not
accurately being returned in the header. This patch fixes that.

[1] https://groups.google.com/d/topic/jenkins-mesos/qUrXpDY07TQ/discussion
2016-03-29 08:30:20 -07:00
Jesse Glick bcbc0195b9 Merge pull request #2173 from jglick/JENKINS-33759-misc
Copy item in folder fixes
2016-03-29 11:26:24 -04:00
Kohsuke Kawaguchi b23cb10980 [JENKINS-33799]
As suggested by Tom, removing the tag name restriction
and correcting the xlg class name.

See the Icon class for more details
2016-03-29 07:57:42 -07:00
Jesse Glick 6cb93e6768 Use rerunFailingTestsCount rather than @RandomlyFails. 2016-03-29 10:39:50 -04:00
recena 143ccab9f4 Client-side form validation 2016-03-29 16:37:59 +02:00
recena 37440f15b4 Merge branch 'newitem-polish' of https://github.com/recena/jenkins into newitem-polish 2016-03-29 16:34:59 +02:00
recena 9906d324a3 Client-side form validation 2016-03-29 16:34:14 +02:00
Manuel Recena 45d75c224a Merge pull request #29 from amuniz/newitem-polish
Autocomplete on New Item - Copy from
2016-03-29 16:33:37 +02:00
Antonio Muñiz 930cda4176 Merge remote-tracking branch 'recena/newitem-polish' into newitem-polish
Conflicts:
	core/src/main/resources/hudson/model/View/newJob.jelly
2016-03-29 16:33:11 +02:00
recena dbaf7d08dc Client-side form validation 2016-03-29 16:28:24 +02:00
Antonio Muñiz 3aae1bbc8f [JENKINS-33774] Autocomplete on New Item - Copy From 2016-03-29 11:17:08 +02:00
Kohsuke Kawaguchi a5bede84e6 Merge pull request #2176 from jenkinsci/instance-initializer
initializer annotation on instance methods
2016-03-28 18:42:27 -07:00
kzantow b6f3585234 Relative URL for redirect 2016-03-28 21:06:54 -04:00
kzantow da3bb81fad JENKINS-33800 - fileNotFound exception if jenkins 1 installed, security
settings saved but global config is not - show normal login in this case
2016-03-28 20:16:42 -04:00