Commit Graph
32590 Commits
Author SHA1 Message Date
Stephen Connolly f68f5fb24f [FIXED JENKINS-33414] Added an API to allow identification of the Jenkins JVM
- Fix the ProxyConfiguration code to not require Jenkins class to be loaded in remote JVMs
2016-03-08 23:05:00 +00:00
gusreiber 2ee47a1930 fixing less variables for scrollspy 2016-03-08 14:54:30 -08:00
Stephen Connolly 96150d3a46 Jenkins.getInstance() will be @Nonnull in Jenkins 2.0+
- Code that is running from a plugin and on the master's JVM is guaranteed to never get null from this method (any cases where you do get null are bugs in core)
- Code that is running from a plugin and on a remote JVM should never be allowed to load the Jenkins class in their classloader, so should never use Jenkins.getInstance()... we are annotating the method with @Nullable so that such code can have some evolution time
- Code that is running in core and on one of two special paths should use the Jenkins.getInstanceOrNull() method so that the UI can be presented to users before the singleton has been instantiated / after the singleton has been destroyed
- The remaining 95% of uses in core (and 100% of uses in plugins) can safely assume that the instance is never null
2016-03-08 21:15:43 +00:00
Stephen Connolly d1dfbd2baf Revert "Jenkins.getInstance() should be non-null"
This reverts commit bb7c8fcedb.

Closes #2090, I'll redo this as a PR... though if that PR is subject to multiple rounds of review before being merged then I will take that of evidence of the exact problem that committing directly was supposed to resolve... namely exponentially multiplying the effort required to make actual improvements to the code base.
2016-03-08 21:09:28 +00:00
gusreiber daa52d7f2b PR-2046:removing junk comment 2016-03-08 11:07:09 -08:00
gusreiber d87d14e6a1 PR-2046:moving generalRow declaration inside if 2016-03-08 11:06:56 -08:00
gusreiber e39b2ab083 PR-2046:rounding hard edges of buttons and borders 2016-03-08 11:06:40 -08:00
tfennelly 8783076471 Fixed the background smudgie on the stapler=class-bad elements 2016-03-08 11:04:06 -08:00
tfennelly 968a762fe4 Fix build 2016-03-08 11:03:48 -08:00
gusreiber 99ba193c48 completing fix for draging regions 2016-03-08 10:59:01 -08:00
gusreiber 99f1414348 fixing drag bug 2016-03-08 10:58:30 -08:00
gusreiber ffe49d0be6 demoving debugger 2016-03-08 10:57:57 -08:00
gusreiber 1110906754 adding cleaner groupings to tabbed config update 2016-03-08 10:56:56 -08:00
kzantow bb8492db65 Setup wizard may run erroneously if system config page was never saved
while running the prior version of Jenkins
2016-03-08 13:20:04 -05:00
Daniel Beck 03291cf891 Merge branch '2.0' of github.com:jenkinsci/jenkins into JENKINS-14538
Conflicts:
	core/src/main/resources/hudson/model/Computer/sidepanel.jelly
2016-03-08 19:08:09 +01:00
Daniel Beck 4184b5ae27 Use gear icon for Configure to free tool icon for Configure Tools 2016-03-08 19:03:37 +01:00
kzantow e56ebc6295 Merge remote-tracking branch 'primary/2.0' into 2.0
# Conflicts:
#	core/src/main/resources/jenkins/install/pluginSetupWizard.properties
#	war/src/main/js/pluginSetupWizardGui.js
#	war/src/main/less/pluginSetupWizard.less
2016-03-08 12:33:54 -05:00
Daniel Beck ede925cae3 Merge pull request #2077 from kzantow/2.0-install-dependency-view
Fix dependency display in setup wizard: remove tooltip, clickable
2016-03-08 16:56:34 +01:00
James Nord 3c10f1f7b9 [FIXED JENKINS-33395] install an uncaught exception handler 2016-03-08 15:44:50 +00:00
Daniel Beck 074890c093 Merge pull request #2015 from escoem/JENKINS-28790
[FIX JENKINS-28790] Masked parameters are now hidden on Windows
2016-03-08 16:28:17 +01:00
kzantow 83050b618a Nesting bug, modify to use better structure, don't rely on label element
as plugin container
2016-03-08 10:00:25 -05:00
Stephen Connolly 2d9d7bbe21 Merge pull request #2091 from stephenc/jenkins-33377
[FIXED JENKINS-33377] Add a check for termination to Functions.isExtensionsAvailable()
2016-03-08 13:01:22 +00:00
Stephen Connolly abf9fd3658 [FIXED JENKINS-33384] clean up the PluginServletFilter instances on Jenkins.cleanUp() 2016-03-08 12:11:38 +00:00
Stephen Connolly 897363ffed Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
2016-03-08 11:44:23 +00:00
Stephen Connolly 8cee006c5e Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
2016-03-08 11:43:07 +00:00
Stephen Connolly c99fedec63 Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
- If it were somehow or other called after `Jenkins.theInstance == null` then at that point the queue has already been persisted so the trigger could have no effect anyway... much better to surface in the shutdown logs about the missed trigger than either return false or incorrectly report the job as triggered
2016-03-08 11:42:09 +00:00
Stephen Connolly b0e79d962f Should have been using ExtensionList.lookup(Class) anyway 2016-03-08 11:37:36 +00:00
Stephen Connolly c86d079387 Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
2016-03-08 11:33:40 +00:00
Stephen Connolly d4ed090dfe Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
2016-03-08 11:33:03 +00:00
Stephen Connolly cf362f3450 Fix javadoc comment 2016-03-08 11:32:21 +00:00
Stephen Connolly 4822f54898 It would be better if we had an explicit method to identify when code is run in a thread on the master vs in a thread on a slave
- because forcing the slave to load the Jenkins class into its classloader is probably not a good plan
2016-03-08 11:30:54 +00:00
Stephen Connolly a141122545 Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
- Only ever called from a thread on the master
2016-03-08 11:27:40 +00:00
Stephen Connolly b09a2a6097 It would be better if we had an explicit method to identify when code is run in a thread on the master vs in a thread on a slave
- because forcing the slave to load the Jenkins class into its classloader is probably not a good plan
2016-03-08 11:25:38 +00:00
Stephen Connolly 84bc8ecae2 Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
- Noting that the one valid check for null should actually be using a guard on extensions being available and not a check for null
2016-03-08 11:22:33 +00:00
Stephen Connolly f0e1ac7139 Arguably all these fireXXX methods should no-op if the extensions are not available 2016-03-08 11:19:01 +00:00
Stephen Connolly 9e6153a8cf Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
2016-03-08 10:58:01 +00:00
Stephen Connolly 0ef1c6f56a Noting that this usage required JENKINS-33377 before it can be fixed 2016-03-08 10:57:18 +00:00
Stephen Connolly 16eb3487c9 Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
2016-03-08 10:56:03 +00:00
Stephen Connolly f3675ff54e Noting that there is a >99% certainty that these can use getInstance()
- Plugins using these methods will be safe
- The code path I need to analyse is the `Jenkins.super()` constructor code path. As Jenkins extends AbstractCIBase if there is a call there that requires the queue lock during construction it may require these methods to be safe against being called before the singleton has been put in place
2016-03-08 10:55:01 +00:00
Stephen Connolly 6be1808040 Noting that there is a potentially valid argument for allowing this method to work without the singleton...
- But the type of tests here would be very restricted in what they could safely do anyway, so they would largely be restricted to verifying data migration during xml loading
2016-03-08 10:45:35 +00:00
Stephen Connolly f82e5fa949 Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
2016-03-08 10:39:46 +00:00
Stephen Connolly ed271401a2 Noting that there is a >99% certainty that these case use getInstance() 2016-03-08 10:37:29 +00:00
Stephen Connolly 10517dbd79 Noting that there is a >99% certainty that these case use getInstance() 2016-03-08 10:36:59 +00:00
Stephen Connolly ee1d04c0b0 Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
2016-03-08 10:34:27 +00:00
Stephen Connolly 1df97e99f9 Noting that there is a >99% certainty that these case use getInstance() 2016-03-08 10:31:36 +00:00
Stephen Connolly e9772f0ffd Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath while performing initialization and during termination before `Jenkins.theInstance` is set to `null`
2016-03-08 10:29:08 +00:00
Stephen Connolly b0bd44e8e9 Jenkins.getInstance() is safe to assume non-null (x1)
- This code path is only ever called after extensions are on the classpath and before termination
- The other code path may just possibly be called when `Jenkins.theInstance == null`, for clarification I assert that this can never happen, but as all it does is log the errors in a claimed failed startup I will leave this with just a TODO marker for now
2016-03-08 10:26:19 +00:00
Stephen Connolly 2f70b2fe8b Jenkins.getInstance() is safe to assume non-null
- Only ever called after extensions are on the classpath and before termination
2016-03-08 10:20:44 +00:00
Stephen Connolly b6594b7b3f Align open(URL) with getInputStream(URL) so that they both use the proxy settings valid at the point of call 2016-03-08 10:18:45 +00:00
Stephen Connolly 1ed395aa06 [FIXED JENKINS-33377] Add a check for termination to Functions.isExtensionsAvailable() 2016-03-08 10:08:32 +00:00