Commit Graph
32590 Commits
Author SHA1 Message Date
Jesse Glick b2ab469b6f Using ysoserial directly.
Trying to touch userContent rather than some random file, so that we can verify the result remotely.
Reducing rounds to two: one for capability, one for random transport commands.
2015-11-09 21:04:47 -05:00
Jesse Glick 430406cbac Merge remote-tracking branch 'security/SECURITY-218-tests' into SECURITY-218-blackbox 2015-11-09 20:21:54 -05:00
Jesse Glick 5bb0ed5c19 Reproduced original exploit. Framework of round tests, not yet confirmed to work. 2015-11-09 17:59:27 -05:00
Oleg Nenashev 83b41e40dc [SECURITY-218] - Rename tests to avoid conflicts with @jglick's changes 2015-11-10 01:33:10 +03:00
Oleg Nenashev 6a5157270d [SECURITY-218] - Refactor the test package to address comments from @jglick 2015-11-10 01:31:56 +03:00
Oleg Nenashev d3dc0e193a Fix NPE in tests 2015-11-10 01:27:54 +03:00
Jesse Glick 1503255313 Now operating at chunked transport level. 2015-11-09 17:02:55 -05:00
Jesse Glick e01d3c779c This is intended to be a true blackbox test: while we customize the client behavior, it can run against any server. 2015-11-09 14:56:46 -05:00
Jesse Glick 9e459755b3 CLI help command can run even against an instance with no anonymous read access, so use that. 2015-11-09 14:44:26 -05:00
Oleg Nenashev 93b8e00398 [SECURITY-218] - Fix Gadgets to make Spring test running 2015-11-09 20:24:35 +02:00
Oleg Nenashev 26cf74ea16 [SECURITY-218] - Adjust implementation to the remoting behavior after the fix 2015-11-09 20:14:32 +02:00
Oleg Nenashev ddf8d8a4aa [SECURITY-218] - Finalize the test implementatioin, the issue is reproducible 2015-11-09 19:32:30 +02:00
Oleg Nenashev 2056483870 [SECURITY-218] - Rework tests according to use fair class instance propagation over remoting 2015-11-09 17:45:31 +02:00
Kohsuke Kawaguchi 1f5da7f1f5 updated changelog for release 2015-11-08 21:21:43 -08:00
Kohsuke Kawaguchi 1241abdcba [maven-release-plugin] prepare for next development iteration 2015-11-08 21:15:07 -08:00
Kohsuke Kawaguchi 3c0ee935ef [maven-release-plugin] prepare release jenkins-1.637 jenkins-1.637 2015-11-08 21:15:07 -08:00
Jesse Glick a22f027a54 Merge branch 'master' into security-master 2015-11-08 07:35:38 -05:00
Kohsuke Kawaguchi 54a1a53147 Merge branch 'security-stable-1.625' into security-master 2015-11-07 21:43:35 -08:00
Kohsuke Kawaguchi f4e8db2549 Merge branch 'security-stable-1.609' into security-stable-1.625 2015-11-07 21:43:09 -08:00
Kohsuke Kawaguchi 4c0d5ea643 Merge branch 'security-stable-1.596' into security-stable-1.609
Conflicts:
	cli/src/test/java/hudson/cli/ConnectionTest.java
	pom.xml
2015-11-07 21:41:42 -08:00
Kohsuke Kawaguchi 6653b5199e Merge branch 'security-stable-1.580' into security-stable-1.596
Conflicts:
	pom.xml
2015-11-07 21:39:05 -08:00
Kohsuke Kawaguchi 5bd9b55a2a Merge pull request #44 from jenkinsci-cert/SECURITY-218
[FIXED SECURITY-218]
2015-11-07 21:34:54 -08:00
Kohsuke Kawaguchi cb588f93e5 Anchroing to a bless version created from 08456746a7ad0f08505017fed19e6c7501557d5a 2015-11-07 21:02:34 -08:00
Kohsuke Kawaguchi c7e0b79932 Adjusted to the additional fix in remoting 2015-11-07 20:26:56 -08:00
Oleg Nenashev b2b61cb200 Saved the progress 2015-11-08 06:07:42 +02:00
Jesse Glick bc69f8c11f Developed structure of blackbox test. 2015-11-07 18:39:27 -05:00
Kohsuke Kawaguchi aff88a0679 Test problem
anonymous Callable fails to serialize without this.

jnlpSlave(jenkins.security.Security218Test)  Time elapsed: 3.616 sec  <<< ERROR!
java.io.IOException: Unable to serialize jenkins.security.Security218Test$1@72a2ba17
    at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1180)
    at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1528)
    at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1493)
    at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1416)
    at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1174)
    at java.io.ObjectOutputStream.defaultWriteFields(ObjectOutputStream.java:1528)
    at java.io.ObjectOutputStream.writeSerialData(ObjectOutputStream.java:1493)
    at java.io.ObjectOutputStream.writeOrdinaryObject(ObjectOutputStream.java:1416)
    at java.io.ObjectOutputStream.writeObject0(ObjectOutputStream.java:1174)
    at java.io.ObjectOutputStream.writeObject(ObjectOutputStream.java:346)
    at hudson.remoting.UserRequest._serialize(UserRequest.java:158)
    at hudson.remoting.UserRequest.serialize(UserRequest.java:167)
    at hudson.remoting.UserRequest.<init>(UserRequest.java:63)
    at hudson.remoting.Channel.call(Channel.java:779)
    at jenkins.security.Security218Test.check(Security218Test.java:65)
    at jenkins.security.Security218Test.jnlpSlave(Security218Test.java:55)
2015-11-07 14:51:42 -08:00
Kohsuke Kawaguchi 8fd067938e Explaining how a simulated attack works 2015-11-07 14:06:40 -08:00
Kohsuke Kawaguchi 05b0a2a17c How is this payload rejected, you ask? 2015-11-07 14:00:46 -08:00
Kohsuke Kawaguchi b430d6d457 [SECURITY-218]
Added a test case for master/slave communication.
2015-11-07 14:00:46 -08:00
Kohsuke Kawaguchi a03c8b0763 Some ad-hoc integration-level testing with JenkinsRule 2015-11-07 12:01:29 -08:00
Kohsuke Kawaguchi 12a970dffa A modest test case for the change 2015-11-07 11:10:09 -08:00
Kohsuke Kawaguchi 2f617144e9 Updated to reflect changes in args4j SPI.
(cherry picked from commit 88e287a83b)
2015-11-06 22:10:07 -08:00
Kohsuke Kawaguchi 71b341013e Reworked the fix.
Most of the changes are now in remoting.
2015-11-06 19:50:47 -08:00
Kohsuke Kawaguchi 8622080ccf Switching to name based filtering
... in case plugins bring their own copies of those classes
2015-11-06 18:02:50 -08:00
Kohsuke Kawaguchi 0c8bbbfee8 The initial sketch of the classloader filtering 2015-11-06 17:19:57 -08:00
Oliver Gondža 9b293d02ae Merge pull request #1904 from csimons/inheritDoc
fix {@inheritDoc} syntax
2015-11-06 05:44:21 +01:00
Jesse Glick 8fafe3ff86 Merge branch 'security-stable-1.625' into security-master 2015-11-05 17:03:30 -05:00
Jesse Glick f76f795b44 Merge branch 'master' into security-master 2015-11-05 17:01:47 -05:00
Jesse Glick 21a3e63fae Merge branch 'master' of git://github.com/jenkinsci/jenkins 2015-11-05 17:01:42 -05:00
Jesse Glick 3ac40d3cfe Merge branch 'security-stable-1.609' into security-stable-1.625 2015-11-05 17:01:23 -05:00
Jesse Glick 1d32134b5d Merge branch 'security-stable-1.596' into security-stable-1.609 2015-11-05 17:00:47 -05:00
Jesse Glick dbe3b5f529 Merge branch 'security-stable-1.580' into security-stable-1.596 2015-11-05 17:00:08 -05:00
Kohsuke Kawaguchi ed407e66bc Merge pull request #41 from jenkinsci-cert/SECURITY-206
[SECURITY-206] Need to call ChannelConfigurator on JNLP slave channels
2015-11-05 13:53:47 -08:00
Daniel Beck 762fff4203 Noting #1896, #1888 2015-11-05 22:41:25 +01:00
Christopher Simons 6b352a112d VirtualFile.toString: fix @inheritDoc 2015-11-05 14:45:18 -05:00
Christopher Simons b1f49f164b VirtualFile.hashCode: fix @inheritDoc 2015-11-05 14:44:58 -05:00
Christopher Simons 4072df1c2a VirtualFile.equals: fix @inheritDoc 2015-11-05 14:44:37 -05:00
Christopher Simons 4a386807cf VirtualFile.compareTo: fix @inheritDoc 2015-11-05 14:44:11 -05:00
Christopher Simons b91e3495a6 BuildStepCompatibilityLayer: fix @inheritDoc 2015-11-05 14:43:07 -05:00