Commit Graph
32590 Commits
Author SHA1 Message Date
Kanstantsin Shautsou a2ba196e63 test-annotations -> 1.2
Allows @Issue(String[])
2015-08-21 21:46:52 +03:00
James Nord d72d7b83ba compiler tweaks and address review comments 2015-08-20 19:41:14 +01:00
James Nord 06f690dbb9 [JENKINS-30057] NodeProperties should be owned by the corresponding Saveable.
Node objects are owned by the Nodes class not by Jenkins so NodeProperties
and anything modifiying them needs to be updated.  Also modifying Nodes
requires a lock on the Queue so use this lock not Jenkins to prevent the
deadlock observed in JENKINS-30057
2015-08-20 15:27:53 +01:00
Nicolas De loof 1d3b96205b Merge pull request #1805 from ndeloof/JENKINS-30007
[JENKINS-30007] let Installable implement NodeSpecific
2015-08-20 08:49:08 +02:00
James Nord 9a63d6f8cb [JENKINS-29936] when removing an item use ACL.SYTEM.
The OldDataMonitor should be using ACL.system not the ACL of the calling
thread - this also avoids the deadlock when an authorization strategy is
being saved (locking the auth strategy) which will call into the ODM at
the same point the ODM is being called an a Run has been saved (which will
cause a lookup of the job which will do a permissions check).

(cherry picked from commit 8a077a8019)
2015-08-19 20:24:55 +02:00
Stephen Connolly db1e2d2a19 [FIXED JENKINS-29568] A better fix
- 252e129609 doesn't work for all cases as there are code paths
  where a pending launch can be removed from the pending list and not have spent() called.
- There was no reason for iterating the list twice anyway, as all of this takes place with the locks held
- My notifying each one as we process, if there is an Error, we will not leave any stranded. The next run
  through, if there is one, will cover those instances.

(cherry picked from commit 4f0ca16b01)
2015-08-19 19:11:27 +02:00
Stephen Connolly f2500bd51b The call to PlannedNode.spent() *must* always occur
- They have been removed from the pendingLaunches, so once we leave this method we have no reference to them
- Arguably the call to spent should take place when removing from the pendingLaunches, but that would change
  the method contract

(cherry picked from commit 252e129609)
2015-08-19 19:11:26 +02:00
Daniel Beck 832236fc0c Consistently use 'issue' instead of 'JENKINS' 2015-08-19 17:51:47 +02:00
Daniel Beck 2cf8446ba9 Disambiguate message for 1.623 2015-08-19 17:48:40 +02:00
Daniel Beck 190e9e849c Move entries from trunk to 1.625 2015-08-19 17:46:54 +02:00
James Nord b8f5342c73 Merge pull request #1784 from Vlatombe/JENKINS-29798
[FIXED JENKINS-29798] Failed to listen to incoming slave connection
2015-08-19 13:12:32 +01:00
Nicolas De Loof 906aaf7ca3 @since 2015-08-19 09:20:52 +02:00
Nicolas De Loof 115ccba4aa convenient decorator class to make Installable NodeSpecific 2015-08-19 08:51:26 +02:00
John Pederzolli 7795039e33 additional comments 2015-08-18 08:41:15 -07:00
John Pederzolli 1c0e94bfe9 minor cleanup to trigger pull request 2015-08-18 08:27:58 -07:00
Nicolas De Loof c775e25f40 [JENKINS-30007] let Installable implement NodeSpecific 2015-08-18 14:53:52 +02:00
Kohsuke Kawaguchi d81cd2bbf1 Merge remote-tracking branch 'origin/master' 2015-08-18 05:45:17 -07:00
Nicolas De Loof 0871030154 [JENKINS-30007] let Installable implement NodeSpecific 2015-08-18 14:38:32 +02:00
Oliver Gondža 8d9ef036b7 Merge pull request #1801 from KostyaSha/updJavadoc
Update javadoc-plugin version
2015-08-18 13:10:32 +02:00
Kohsuke Kawaguchi 1bc69577c3 updated changelog for release 2015-08-17 21:25:50 -07:00
Kohsuke Kawaguchi 8d8703a781 [maven-release-plugin] prepare release jenkins-1.625 jenkins-1.625 2015-08-17 21:19:42 -07:00
Kohsuke Kawaguchi b75cc47c97 [maven-release-plugin] prepare for next development iteration 2015-08-17 21:19:42 -07:00
John Pederzolli 60ebcfb3f1 Update RunIdMigrator to properly handle matrix and maven jobs
Properly revert job history for matrix and maven jobs (depending on
setup).

Examples paths include:

jobs/someproject/Environment=prod/builds
jobs/someproject/test$test/builds
2015-08-17 15:53:11 -07:00
Kanstantsin Shautsou dc27285173 Update javadoc-plugin version 2015-08-18 01:51:28 +03:00
Vincent Latombe d3f53b9304 Merge branch 'master' into JENKINS-29798 2015-08-17 15:22:42 +02:00
Daniel Beck 94d80ea4f2 Noting #1715, #1767 2015-08-17 13:19:19 +02:00
Daniel Beck 3944c1f2c5 Merge pull request #1789 from vlajos/typofixes-vlajos-20150807
typofix - https://github.com/vlajos/misspell_fixer
2015-08-17 13:15:03 +02:00
James Nord 68c1e351f8 Merge pull request #1799 from jtnord/changelog-JENKINS-29936
Noting JENKINS-29936
2015-08-17 10:35:04 +01:00
James Nord e0849bdaf8 Noting JENKINS-29936 2015-08-17 10:32:14 +01:00
Oliver Gondža 7add0d1646 Merge pull request #1793 from pjdarton/utiltest_enhancement
Improved unit test for Util.deleteFile & Util.deleteRecursive
2015-08-17 07:16:03 +02:00
Peter Darton 94efc7ba6a Improved unit test for Util.deleteFile(File)
Added unit test for Util.deleteRecursive(File)
2015-08-17 07:14:47 +02:00
Daniel Beck e46afb59fd Merge pull request #1715 from ikedam/feature/JENKINS-28440_HandleCriticalField
[JENKINS-28440] Reject configurations with errors in critical fields via REST / CLI
2015-08-16 11:38:51 +02:00
Daniel Beck c1b60f18b5 Merge pull request #1796 from jtnord/jenkins-29936
[JENKINS-29936] when removing an item use ACL.SYSTEM.
2015-08-16 11:31:37 +02:00
James Nord 8a077a8019 [JENKINS-29936] when removing an item use ACL.SYTEM.
The OldDataMonitor should be using ACL.system not the ACL of the calling
thread - this also avoids the deadlock when an authorization strategy is
being saved (locking the auth strategy) which will call into the ODM at
the same point the ODM is being called an a Run has been saved (which will
cause a lookup of the job which will do a permissions check).
2015-08-13 19:10:51 +01:00
Oliver Gondža 6bfbe0c79d Merge pull request #1795 from gastaldi/master
Fixed typos in pt_BR and pt_PT translations
2015-08-13 16:57:21 +02:00
George Gastaldi 697fe70f59 Fixed typos in pt_BR and pt_PT translations 2015-08-13 11:43:41 -03:00
Veres Lajos d58903558e typofix - https://github.com/vlajos/misspell_fixer 2015-08-11 16:34:13 +01:00
Daniel Beck b9b7f16369 Merge pull request #1767 from petermarcoen/JENKINS-2327
[FIXED JENKINS-2327] Do not display 'No changes' if changelog calcula…
2015-08-11 16:42:42 +02:00
Kohsuke Kawaguchi fea12f76f5 Merge branch 'stable-1.609' of github.com:jenkinsci/jenkins into stable-1.609 2015-08-11 00:29:40 -07:00
Stephen Connolly a80972307e Merge pull request #1786 from stephenc/jenkins-28690-correct-interrupt-override
[JENKINS-28690] Aha! So I believe this will fully resolve any of these kinds of deadlocks
2015-08-10 22:22:02 +01:00
Stephen Connolly 7ab816878b Merge pull request #1785 from stephenc/pr-1777-is-better-when-lockfree
[FIXES PR#1777] Make accessing pendingLaunches lock free
2015-08-10 22:21:21 +01:00
Daniel Beck 4b9318f504 Noting #1779 2015-08-10 20:49:49 +02:00
Oliver Gondža c898a2e3fa Merge pull request #1791 from BenjaminHerbert/update-groovy-link
Update link to Groovy
2015-08-10 20:07:17 +02:00
Benjamin Herbert fb82015520 Update link to Groovy
Codehaus terminated all services - now Groovy's new home is groovy-lang.org.
2015-08-10 16:39:28 +02:00
Kohsuke Kawaguchi 157cd10284 updated changelog for release 2015-08-09 10:34:03 -07:00
Kohsuke Kawaguchi a27638e110 [maven-release-plugin] prepare for next development iteration 2015-08-09 10:27:53 -07:00
Kohsuke Kawaguchi fe7514a599 [maven-release-plugin] prepare release jenkins-1.624 jenkins-1.624 2015-08-09 10:27:52 -07:00
Vincent Latombe 03bba48729 [JENKINS-29798] Add a lock to serialize updates of tcpSlaveAgentListener 2015-08-07 12:01:10 +02:00
Jesse Glick fd83a285b3 Merged #1747. 2015-08-07 05:16:05 -04:00
Jesse Glick 9bcd351eec arbitrary change 2015-08-06 14:59:48 -04:00