Oliver Gondža
e96f08d61a
Merge pull request #1458 from olivergondza/aggregate-validations
...
Aggregate multiple FormValidations into one
2014-11-08 10:36:08 +01:00
Jesse Glick
78fde58c30
Merge branch 'master' of git://github.com/jenkinsci/jenkins
builds/294
changes/294
2014-11-07 14:13:09 -05:00
Oliver Gondža
e451789ac7
Merge pull request #1456 from olivergondza/extract-label-validation
...
Expose AbstractProject.AbstractProjectDescriptor#validateLabelExpression for plugins
2014-11-07 19:42:03 +01:00
Jesse Glick
ae053472a0
Merging #1268 .
builds/293
changes/293
2014-11-07 13:08:53 -05:00
Jesse Glick
bfa557b16a
Merge branch 'JENKINS-23339' of github.com:synopsys-arc-oss/jenkins
2014-11-07 13:08:03 -05:00
Kohsuke Kawaguchi
ada8432fc5
[JENKINS-25144] Merge pull request #1427
builds/292
changes/292
2014-11-07 09:43:25 -08:00
Kohsuke Kawaguchi
9e81b8e4fe
[FIXED JENKINS-25144] Revisiting the attempted fix in the previous commit.
...
IIUC, the issue here is that the request in question contains both a
valid session cookie AND basic authentication header, and that path
results in a failure because BasicHeaderProcessor expects one of
BasicHeaderAuthenticators to validate the basic authentication header
(without knowing that there's already a valid Authentication object that
came from the HTTP session, yet no BasicHeaderAuthenticator actually
processes this because BasicHeaderRealPasswordAuthenticator backs away
from doing that.
I think the corect fix is for BasicHeaderRealPasswordAuthenticator to
get rid of authenticationIsRequired check. This check instead belongs to
BasicHeaderProcessor, where it should be used to check if any
BasicHeaderAuthenticator should be consulted or not.
The problem with having this logic in
BasicHeaderRealPasswordAuthenticator is that this is just an
implementation of an extension point, and thus it needs to be removable.
As it stands right now in this fix, if this impl is removed,
JENKINS-25144 will be back again.
2014-11-07 09:42:23 -08:00
Christof Schoell
0176b6d902
[JENKINS-25144]
...
return authentication object instead of null if authentication is not
required - otherwise valid login fails with basic authentication
2014-11-07 09:40:26 -08:00
Oleg Nenashev
e6c2e16f7a
[FIXED JENKINS-23339] - Introduce the validated Jenkins::getActiveInstance() method
...
jenkins.model.Jenkins::getInstance() method is marked as @CheckForNull, but the most of Jenkins code does not actually check the return value. It leads to tons of static analysis errors, hence it is hard to analyze the code.
The change also adds annotations to old methods like Hudson::getInstance()
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2014-11-07 20:07:52 +03:00
Oleg Nenashev
be835bfcfb
[JENKINS-19017] - Unit tests
...
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
(cherry picked from commit cc06ae78e3 )
2014-11-07 15:19:16 +01:00
Oleg Nenashev
fff888cc82
[FIXED JENKINS-19017] - FileParameter - Handle non-null file parameters as different values
...
The change prevents the issue when Jenkins merges builds with different files coming from one source (It may happen!).
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
(cherry picked from commit 7c4f6b7ef4 )
2014-11-07 15:19:16 +01:00
Daniel Beck
b73bb3d0af
Merge pull request #1306 from bkmeneguello/post-cancel-shutdown
...
[FIXED JENKINS-23020 JENKINS-23942] Convert the queue's cancel shutdown to POST
(cherry picked from commit fda84f456f )
2014-11-07 15:08:01 +01:00
Kohsuke Kawaguchi
68eb26633b
[FIXED JENKINS-20108]
...
Integrated the trilead with SecureRandom instantiation fix.
(cherry picked from commit 70f5968160 )
Conflicts:
changelog.html
core/pom.xml
2014-11-07 15:01:08 +01:00
Oleg Nenashev
1b0d8fb63a
[FIXED JENKINS-24340] - Do not disable jobs if supportsMakeDisabled() returns false
...
This changes prevents the improper usage of method without the preliminary supportsMakeDisabled() check.
As an example, Subversion plugin behaves in such way (JENKINS-24341)
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
(cherry picked from commit a78f1d3246 )
2014-11-07 14:59:51 +01:00
Jesse Glick
3eefad8d30
[FIXED JENKINS-25081] Memory leak in BoundObjectTable when ProgressiveRendering is used.
...
(cherry picked from commit aac8c23972 )
Conflicts:
changelog.html
2014-11-07 14:56:38 +01:00
Nicolas De Loof
03a13fcf97
test case for JENKINS-24825
...
(cherry picked from commit 8975b0e0b5 )
2014-11-07 14:47:14 +01:00
Nicolas De Loof
a4a28fb87f
[FIXED JENKINS-24825] define hudson.model.AbstractItem#movedTo
...
(cherry picked from commit 9b3f48853d )
Conflicts:
changelog.html
2014-11-07 14:47:12 +01:00
Oliver Gondža
34850200b2
Introduce FormValidation#aggregate
2014-11-07 09:20:06 +01:00
Jesse Glick
24c5e5e440
Javadoc note pertaining to #1454 .
builds/291
changes/291
2014-11-06 14:29:07 -05:00
Jesse Glick
bcdae275d0
[JENKINS-25473] Retroactively filing #1439 .
2014-11-06 09:48:32 -05:00
Oliver Gondža
e985ee69ff
Expose AbstractProject.AbstractProjectDescriptor#validateLabelExpression for plugins
2014-11-06 13:29:08 +01:00
Oliver Gondža
12ff0b249a
Junit 4
2014-11-06 12:30:33 +01:00
Jesse Glick
0b0b868805
[JENKINS-2786] Makes no sense for Computer.currentComputer to return MasterComputer when not on an executor thread.
2014-11-05 17:19:45 -05:00
Holger Voormann
c56362aba3
[FIXED JENKINS-22514] In ZIP archives file separator must be '/'
2014-11-05 08:41:56 +01:00
Kohsuke Kawaguchi
e607048d46
SSH slave 1.9 brings in a better error diagnostics.
2014-11-04 19:46:50 -08:00
Kohsuke Kawaguchi
96f97a4579
Integrated the new trilead library that has some minor diagnosability improvements.
2014-11-04 19:46:49 -08:00
Kohsuke Kawaguchi
41c788e2f1
Integrated a new version of remoting
2014-11-04 19:46:49 -08:00
Kohsuke Kawaguchi
e7d75dc538
Make stdout swapping more reliable.
...
This matches fb65a2c3c8584a9ac4daa49ecbce7a540dc7f5a5 in remoting.
2014-11-04 19:46:49 -08:00
Jesse Glick
3732aba5fe
Update Guice to 4.0-beta5.
2014-11-04 21:35:43 -05:00
Jesse Glick
22d433deae
So far unsuccessful attempt to make Jenkins startup more robust against bugs like JENKINS-25440.
...
Even though SezpozModule.configure catches and ignores the faulty component, Guice still dies:
… hudson.ExtensionFinder$GuiceFinder <init>
SEVERE: Failed to create Guice container from all the plugins
com.google.inject.internal.guava.collect.$ComputationException: java.lang.NoClassDefFoundError: org/eclipse/jgit/storage/file/FileRepository
at …
at com.google.inject.Guice.createInjector(Guice.java:73)
at hudson.ExtensionFinder$GuiceFinder.<init>(ExtensionFinder.java:279)
builds/290
changes/290
2014-11-04 17:45:52 -05:00
Jesse Glick
a6a3d5e166
[FIXED JENKINS-25400] Rework fix of JENKINS-22769 ( c04cdcd) to put the burden on each listener to impersonate ACL.SYSTEM if it needs to.
builds/288
changes/288
2014-11-04 15:36:01 -05:00
Jesse Glick
b486e46c4e
Better Javadoc for new impersonate overload.
2014-11-04 15:32:33 -05:00
Jesse Glick
ee13a9a930
junit 1.2-beta-4
builds/287
changes/287
2014-11-04 15:01:03 -05:00
Jesse Glick
06074f4bce
Noting merge of #1434 .
2014-11-04 13:12:33 -05:00
Oleg Nenashev
8f079fc434
[CID-1182126] - Resource leak in AsynchronousAdministrativeMonitor::run()
...
Properly close listeners for asynchronous threads.
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2014-11-04 15:54:13 +03:00
Oleg Nenashev
c873722726
[CID-1182132] - Resource leak in BootFailure::loadAttempts()
...
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2014-11-04 15:54:09 +03:00
Oleg Nenashev
5259996c44
[CID-1219446] - Resource leak in ClassicPluginStrategy
...
Resource leak may happen during the search of manifest file.
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2014-11-04 15:54:05 +03:00
Oleg Nenashev
2ea0276e7b
[CID-1205053] - Resource leak on fingerprint calculation in DirectoryBrowserSupport
...
The issue is related to JENKINS-18351.
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2014-11-04 15:54:02 +03:00
Oleg Nenashev
21ba31af42
[CID-1182127] - Resource leak in HsErrPidList constructor.
...
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2014-11-04 15:53:59 +03:00
Oleg Nenashev
3a8b81a0fc
[CID-992725] - Resource leak in ClientAuthenticationCache
...
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2014-11-04 15:53:55 +03:00
Oleg Nenashev
9e72099115
[CID-1182128] - Properly close InputStream in ConsoleCommand
...
Signed-off-by: Oleg Nenashev <o.v.nenashev@gmail.com >
2014-11-04 15:53:51 +03:00
Kohsuke Kawaguchi
b93a79ceeb
the trunk is toward 1.590-SNAPSHOT
2014-11-02 20:56:21 -08:00
Kohsuke Kawaguchi
28e0d01b18
creating an RC branch
2014-11-02 20:56:12 -08:00
Kohsuke Kawaguchi
8d0b026a1c
merged back the RC branch
2014-11-02 15:07:11 -08:00
Kohsuke Kawaguchi
316e6bba98
updated changelog as a part of the release
2014-11-02 15:07:08 -08:00
Oliver Gondža
8b71d13233
Merge pull request #1447 from mattmoor/labels
...
Adjust my prior change to better utilize structured form submission...
2014-11-02 23:42:53 +01:00
Kohsuke Kawaguchi
1522ff92ce
updated changelog for release
2014-11-02 10:33:22 -08:00
Kohsuke Kawaguchi
584c215b02
[maven-release-plugin] prepare for next development iteration
2014-11-02 10:25:58 -08:00
Kohsuke Kawaguchi
571ed3b5fa
[maven-release-plugin] prepare release jenkins-1.588
jenkins-1.588
2014-11-02 10:25:58 -08:00
Nick Dimiduk
fd2bb3febf
Include parameter name in exception when value is invalid
2014-11-01 13:11:23 -07:00